You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/08/06 00:49:02 UTC

[GitHub] [incubator-yunikorn-core] wilfred-s commented on pull request #292: YUNIKORN-783 The properties are not propagated to dynamic queue when …

wilfred-s commented on pull request #292:
URL: https://github.com/apache/incubator-yunikorn-core/pull/292#issuecomment-893920975


   The design was never intended for a hierarchical copy of the application sort policy. It was a simple fix for just the direct parent to a leaf queue. Anything else was supposed to become part of the template.
   
   There is a jira open to add a template that we can set for inheritance. [YUNIKORN-193](https://issues.apache.org/jira/browse/YUNIKORN-193). It has not been worked on but that is the solution we should really implement.
   
   From that point of view I am a -1 on this change.
   I left comments in YUNIKORN-193 and will be happy to work with you on getting that template properly defined and implemented.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org