You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/11/02 20:49:23 UTC
[GitHub] [cassandra] yifan-c commented on a diff in pull request #1931: CASSANDRA-17870 nodetool/rebuild: Add flag to exclude nodes from local DC
yifan-c commented on code in PR #1931:
URL: https://github.com/apache/cassandra/pull/1931#discussion_r1012244553
##########
src/java/org/apache/cassandra/service/StorageServiceMBean.java:
##########
@@ -769,9 +769,22 @@ default int upgradeSSTables(String keyspaceName, boolean excludeCurrentVersion,
* @param keyspace Name of the keyspace which to rebuild or null to rebuild all keyspaces.
* @param tokens Range of tokens to rebuild or null to rebuild all token ranges. In the format of:
* "(start_token_1,end_token_1],(start_token_2,end_token_2],...(start_token_n,end_token_n]"
+ * @param specificSources list of sources that can be used for rebuilding. Mostly other nodes in the cluster.
Review Comment:
nit: `list of sources that can be used for rebuilding. Must be other nodes in the cluster. The format of the string is comma separated values.`
##########
src/java/org/apache/cassandra/service/StorageServiceMBean.java:
##########
@@ -769,9 +769,22 @@ default int upgradeSSTables(String keyspaceName, boolean excludeCurrentVersion,
* @param keyspace Name of the keyspace which to rebuild or null to rebuild all keyspaces.
* @param tokens Range of tokens to rebuild or null to rebuild all token ranges. In the format of:
* "(start_token_1,end_token_1],(start_token_2,end_token_2],...(start_token_n,end_token_n]"
+ * @param specificSources list of sources that can be used for rebuilding. Mostly other nodes in the cluster.
*/
public void rebuild(String sourceDc, String keyspace, String tokens, String specificSources);
+ /**
+ * Same as {@link #rebuild(String)}, but only for specified keyspace and ranges. It excludes local data center nodes
+ *
+ * @param sourceDc Name of DC from which to select sources for streaming or null to pick any node
+ * @param keyspace Name of the keyspace which to rebuild or null to rebuild all keyspaces.
+ * @param tokens Range of tokens to rebuild or null to rebuild all token ranges. In the format of:
+ * "(start_token_1,end_token_1],(start_token_2,end_token_2],...(start_token_n,end_token_n]"
+ * @param specificSources list of sources that can be used for rebuilding. Mostly other nodes in the cluster.
+ * @param excludeLocalDatacenterNodes Flag to indicate whether local data center nodes should be excluded as a source for streaming.
Review Comment:
nit: `... be excluded as sources for streaming.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org