[GitHub] [iceberg] jackye1995 commented on a change in pull request #2565: Hive: unify catalog experience across engines

[GitBox <gi...@apache.org>]

jackye1995 commented on a change in pull request #2565:
URL: https://github.com/apache/iceberg/pull/2565#discussion_r629483663



##########
File path: mr/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java
##########
@@ -203,6 +202,44 @@ public static Schema readSchema(Configuration conf) {
     return readColumns != null && readColumns.length > 0 ? readColumns : null;
   }
 
+  /**
+   * Get Hadoop config key of catalog type based on catalog name and {@link #CATALOG_TYPE_TEMPLATE}
+   * @param catalogName catalog name
+   * @return Hadoop config key of catalog type for the catalog name
+   */
+  public static String catalogTypeConfigKey(String catalogName) {
+    return String.format(InputFormatConfig.CATALOG_TYPE_TEMPLATE, catalogName);

Review comment:
       It was not added because `type` is not consistent across engines. Flink has to use `catalog-type` instead of `type` because `type` is a reserved config key.
   
   With that being said, we can probably add it and specify that Flink has to use `catalog-type`. Let me do that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org