You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/10/06 21:23:15 UTC

[Impala-ASF-CR] IMPALA-12485: Remove Python 2 has key

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20541


Change subject: IMPALA-12485: Remove Python 2 has_key
......................................................................

IMPALA-12485: Remove Python 2 has_key

Switch calls to dict#has_key (Python 2-only) for 'key in dict' syntax.

Change-Id: I08e9f6667011d70ceddbf919a61d1be7d6e07ee4
---
M common/thrift/generate_metrics.py
M tests/common/test_vector.py
M tests/query_test/test_cancellation.py
3 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/20541/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I08e9f6667011d70ceddbf919a61d1be7d6e07ee4
Gerrit-Change-Number: 20541
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-12485: Remove Python 2 has key

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20541 )

Change subject: IMPALA-12485: Remove Python 2 has_key
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08e9f6667011d70ceddbf919a61d1be7d6e07ee4
Gerrit-Change-Number: 20541
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Oct 2023 21:53:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12485: Remove Python 2 has key

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20541 )

Change subject: IMPALA-12485: Remove Python 2 has_key
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9799/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08e9f6667011d70ceddbf919a61d1be7d6e07ee4
Gerrit-Change-Number: 20541
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Oct 2023 20:20:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12485: Remove Python 2 has key

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20541 )

Change subject: IMPALA-12485: Remove Python 2 has_key
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20541/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20541/1//COMMIT_MSG@9
PS1, Line 9: Switch calls to dict#has_key (Python 2-only) for 'key in dict' syntax.
There should be a pylint failure for this somewhere, but I don't see it when I look at the detailed output from check-pylint-py3k.sh.



-- 
To view, visit http://gerrit.cloudera.org:8080/20541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08e9f6667011d70ceddbf919a61d1be7d6e07ee4
Gerrit-Change-Number: 20541
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Oct 2023 21:29:44 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12485: Remove Python 2 has key

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20541 )

Change subject: IMPALA-12485: Remove Python 2 has_key
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08e9f6667011d70ceddbf919a61d1be7d6e07ee4
Gerrit-Change-Number: 20541
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Oct 2023 20:20:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12485: Remove Python 2 has key

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20541 )

Change subject: IMPALA-12485: Remove Python 2 has_key
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08e9f6667011d70ceddbf919a61d1be7d6e07ee4
Gerrit-Change-Number: 20541
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Oct 2023 00:44:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12485: Remove Python 2 has key

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20541 )

Change subject: IMPALA-12485: Remove Python 2 has_key
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9794/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08e9f6667011d70ceddbf919a61d1be7d6e07ee4
Gerrit-Change-Number: 20541
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Oct 2023 21:53:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12485: Remove Python 2 has key

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20541 )

Change subject: IMPALA-12485: Remove Python 2 has_key
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9794/


-- 
To view, visit http://gerrit.cloudera.org:8080/20541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08e9f6667011d70ceddbf919a61d1be7d6e07ee4
Gerrit-Change-Number: 20541
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Sat, 07 Oct 2023 02:16:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12485: Remove Python 2 has key

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20541 )

Change subject: IMPALA-12485: Remove Python 2 has_key
......................................................................

IMPALA-12485: Remove Python 2 has_key

Switch calls to dict#has_key (Python 2-only) for 'key in dict' syntax.

Change-Id: I08e9f6667011d70ceddbf919a61d1be7d6e07ee4
Reviewed-on: http://gerrit.cloudera.org:8080/20541
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M common/thrift/generate_metrics.py
M tests/common/test_vector.py
M tests/query_test/test_cancellation.py
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I08e9f6667011d70ceddbf919a61d1be7d6e07ee4
Gerrit-Change-Number: 20541
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-12485: Remove Python 2 has key

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20541 )

Change subject: IMPALA-12485: Remove Python 2 has_key
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14150/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08e9f6667011d70ceddbf919a61d1be7d6e07ee4
Gerrit-Change-Number: 20541
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Oct 2023 21:50:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12485: Remove Python 2 has key

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20541 )

Change subject: IMPALA-12485: Remove Python 2 has_key
......................................................................


Patch Set 1: Code-Review+2

This looks good to me


-- 
To view, visit http://gerrit.cloudera.org:8080/20541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08e9f6667011d70ceddbf919a61d1be7d6e07ee4
Gerrit-Change-Number: 20541
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Oct 2023 21:41:15 +0000
Gerrit-HasComments: No