You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/27 07:18:42 UTC

[GitHub] [doris] yiguolei commented on a diff in pull request #13585: [enhancement](memtracker) Refactor mem tracker limiter hierarchy and optimize the usage of bthread mem tracker

yiguolei commented on code in PR #13585:
URL: https://github.com/apache/doris/pull/13585#discussion_r1006489552


##########
be/src/runtime/memory/thread_mem_tracker_mgr.cpp:
##########
@@ -29,25 +29,25 @@ void ThreadMemTrackerMgr::attach_limiter_tracker(
         const std::shared_ptr<MemTrackerLimiter>& mem_tracker) {
     DCHECK(mem_tracker);
     flush_untracked_mem<false>();
-    _task_id_stack.push_back(task_id);
-    _fragment_instance_id_stack.push_back(fragment_instance_id);
-    _limiter_tracker_stack.push_back(mem_tracker);
+    _task_id = task_id;
+    _fragment_instance_id = fragment_instance_id;

Review Comment:
   instance id is useless, we need cancel query by query id.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org