[GitHub] [sedona] jiayuasu commented on a diff in pull request #956: [SEDONA-348] Support 4D Geometry in getDimension

["jiayuasu (via GitHub)" <gi...@apache.org>]

jiayuasu commented on code in PR #956:
URL: https://github.com/apache/sedona/pull/956#discussion_r1289524776


##########
common/src/main/java/org/apache/sedona/common/utils/GeomUtils.java:
##########
@@ -254,7 +254,17 @@ public static Geometry transform(Geometry geometry, CoordinateReferenceSystem so
     }
 
     public static int getDimension(Geometry geometry) {
-        return geometry.getCoordinate() != null && !java.lang.Double.isNaN(geometry.getCoordinate().getZ()) ? 3 : 2;
+        int dimension = 2;

Review Comment:
   This function is duplicate to nDims(): https://github.com/apache/sedona/blob/master/common/src/main/java/org/apache/sedona/common/Functions.java#L298
   
   Please copy the logic of nDims here and let nDims function call this getDimension function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org