You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Tobias Soloschenko <to...@googlemail.com> on 2015/03/04 08:50:20 UTC
[DISCUSSION] Remove .settings of projects in github
Hi everyone,
I saw that there were several commits to .settings the last time and I
wondered why this folder is required in the repository anymore. Here is a
list of the files in a .settings folder (wicket/.settings)
https://github.com/apache/wicket/blob/master/.settings/org.eclipse.core.resources.prefs
https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m2e.core.prefs
https://github.com/apache/wicket/blob/master/.settings/org.eclipse.pde.core.prefs
https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.common.component
https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.common.project.facet.core.xml
I think because maven is used to configure the projects we can remove those
files from the repository and configure it all in maven.
Encoding can be configured by (see
http://maven.apache.org/general.html#encoding-warning):
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
</properties>
Java Compile-Level can be configured with the compiler-plugin:
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.2</version>
<configuration>
<source>1.7</source>
<target>1.7</target>
</configuration>
</plugin>
</plugins>
The project facets are configured by "Maven Integration for Eclipse WTP"
and it receives the information of the web.xml and the packaging configured
in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
http://marketplace.eclipse.org/node/96737)
The only entries to be custom configured are in
org.eclipse.core.resources.prefs containing .deprecations and I wonder if
they are required anymore.
The only thing to be done after importing the project into workspace is to
configure it as maven project. The .settings folder is created through the
m2e plugin based on the pom.xml, web.xml.
Did I overlook something?
What do you think?
kind regards
Tobias
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Martin Grigorov <mg...@apache.org>.
On Wed, Mar 4, 2015 at 11:09 AM, Tobias Soloschenko <
tobiassoloschenko@googlemail.com> wrote:
> Hi Martin,
>
> maybe we can use the maven-eclipse-plugin to apply formatting rules:
>
>
> http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-code-styles.html
>
> The plugin itself is not well maintained, but we only need to apply the
> formatting rules to the IDE - I think on IDEA it is ignored, but we have to
> check it.
>
> Does this address your feature?
>
Everything works for me as far as the new code contributions try to
preserve the current format style of the file they touch.
>
> kind regards
>
> Tobias
>
>
> 2015-03-04 9:30 GMT+01:00 Martin Grigorov <mg...@apache.org>:
>
> > Hi Tobias,
> >
> > I personally use Intellij IDEA and these files are in not in use by me.
> > But AFAIR the most useful feature in them is the code formatting rules.
> We
> > try to keep Wicket code formatted the same style. IMO this helps a lot in
> > maintenance. I personally get distracted when debugging something and see
> > code snippet that is wrongly formatted, or doesn't use braces, or
> something
> > similar.
> >
> > I think I am the only user of IDEA in the team (except Peter Ertl, but he
> > is not very active lately) so I'm sure others will give their feedback on
> > this soon.
> >
> > Martin Grigorov
> > Wicket Training and Consulting
> > https://twitter.com/mtgrigorov
> >
> > On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
> > tobiassoloschenko@googlemail.com> wrote:
> >
> > > Hi everyone,
> > >
> > > I saw that there were several commits to .settings the last time and I
> > > wondered why this folder is required in the repository anymore. Here
> is a
> > > list of the files in a .settings folder (wicket/.settings)
> > >
> > >
> > >
> >
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.core.resources.prefs
> > >
> > >
> >
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m2e.core.prefs
> > >
> > >
> >
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.pde.core.prefs
> > >
> > >
> >
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.common.component
> > >
> > >
> >
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.common.project.facet.core.xml
> > >
> > > I think because maven is used to configure the projects we can remove
> > those
> > > files from the repository and configure it all in maven.
> > >
> > > Encoding can be configured by (see
> > > http://maven.apache.org/general.html#encoding-warning):
> > >
> > > <properties>
> > > <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
> > >
> > >
> >
> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
> > > </properties>
> > >
> > > Java Compile-Level can be configured with the compiler-plugin:
> > >
> > > <plugins>
> > > <plugin>
> > > <groupId>org.apache.maven.plugins</groupId>
> > > <artifactId>maven-compiler-plugin</artifactId>
> > > <version>3.2</version>
> > > <configuration>
> > > <source>1.7</source>
> > > <target>1.7</target>
> > > </configuration>
> > > </plugin>
> > > </plugins>
> > >
> > > The project facets are configured by "Maven Integration for Eclipse
> WTP"
> > > and it receives the information of the web.xml and the packaging
> > configured
> > > in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
> > > http://marketplace.eclipse.org/node/96737)
> > >
> > > The only entries to be custom configured are in
> > > org.eclipse.core.resources.prefs containing .deprecations and I wonder
> if
> > > they are required anymore.
> > >
> > > The only thing to be done after importing the project into workspace is
> > to
> > > configure it as maven project. The .settings folder is created through
> > the
> > > m2e plugin based on the pom.xml, web.xml.
> > >
> > > Did I overlook something?
> > >
> > > What do you think?
> > >
> > > kind regards
> > >
> > > Tobias
> > >
> >
>
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Tobias Soloschenko <to...@googlemail.com>.
One last thing. We have to adjust the servlet-api version in the web.xml
of wicket-example and other web modules (examples version is changed
with the media tags branch) - otherwise the project is created as
dynamic web module with version 2.5 through the m2e wtp integration.
kind regards
Tobias
Am 05.03.15 um 10:34 schrieb Emond Papegaaij:
> m2e cannot resolve plugin dependencies from your workspace, so your
> observation is correct. I don't think this is a big deal, because settings
> don't change very often. Perhaps it's best to keep this settings artifact
> completely separate from the wicket modules itself, in a subdirectory, with
> its own version and parent. We can release 1.0 (simply 1?) and keep it that
> way until a change is needed.
>
> Best regards,
> Emond
>
> On Thursday 05 March 2015 10:15:47 Tobias Soloschenko wrote:
>> Hi,
>>
>> I removed the parent of wicket-eclipse-settings, because otherwise the
>> plugin tries to apply the wicket-eclipse-settings to itself, which is
>> simply not working. :-)
>>
>> I added the additionalConfig section and put in the
>> org.eclipse.jdt.core.prefs and checked the location in the jar which is
>> "/org.eclipse.jdt.core.prefs"
>>
>> I installed the eclipse plugin from the markedplace.
>>
>> The only issue left is that you can't add a dependency only located in
>> your workspace. If I install wicket-eclipse-settings with "clean
>> install" and give it a right number like 1.0 and change the dependencies
>> like the following block - everything is fine (but with SNAPSHOT it is
>> not working):
>>
>> <dependencies>
>> ...
>> <dependency>
>> <groupId>org.apache.wicket</groupId>
>> <artifactId>wicket-eclipse-settings</artifactId>
>> <version>1.0</version>
>> </dependency>
>> ...
>> </dependencies>
>> ...
>> <plugin>
>> <groupId>org.apache.maven.plugins</groupId>
>> <artifactId>maven-eclipse-plugin</artifactId>
>> <version>2.9</version>
>> <configuration>
>> <downloadSources>true</downloadSources>
>> <additionalConfig>
>> <file>
>> <name>.settings/org.eclipse.jdt.core.prefs</name>
>> <location>/org.eclipse.jdt.core.prefs</location>
>> </file>
>> </additionalConfig>
>> </configuration>
>> <dependencies>
>> <dependency>
>> <groupId>org.apache.wicket</groupId>
>> <artifactId>wicket-eclipse-settings</artifactId>
>> <version>1.0</version>
>> </dependency>
>> </dependencies>
>> </plugin>
>>
>> kind regards
>>
>> Tobias
>>
>> Am 05.03.15 um 09:52 schrieb Emond Papegaaij:
>>> Hi Tobias,
>>>
>>> It seems you are missing the additionalConfig section in the
>>> maven-eclipse-
>>> plugin configuration. You need to list .prefs files from which settings
>>> need to be copied:
>>> <additionalConfig>
>>>
>>> <file>
>>>
>>> <name>.settings/org.eclipse.core.resources.prefs</name>
>>> <location>/org.eclipse.core.resources.prefs</location>
>>>
>>> </file>
>>> ...
>>>
>>> </additionalConfig>
>>>
>>> location is the location of the .prefs file in the jar, name is the
>>> location of the .prefs file relative to the project (so always starts
>>> with .settings/).
>>>
>>> Note that the m2e-settings plugin only uses the maven-eclipse-plugin
>>> configuration as a container for its configuration. You should not run mvn
>>> eclipse:eclipse.
>>>
>>> Best regards,
>>> Emond
>>>
>>> On Thursday 05 March 2015 09:19:07 Tobias Soloschenko wrote:
>>>> Ah, now I see. Thank you for the explanation! :-)
>>>>
>>>> @Emond: Would you be so kind and have a look if the way I configured it
>>>> in the branch https://github.com/klopfdreh/wicket/tree/WICKET-5848 is
>>>> like intended?
>>>>
>>>> @Martin: Is somewhere a still existing preference
>>>> (org.eclipse.jdt.ui.prefs) which shows how the code style formatting has
>>>> been applied before it has been removed from version control? I would
>>>> simply copy the file into the "files" folder of wicket-eclipse-settings
>>>> and as I understood eclipse then takes the setting for each project
>>>> which has the wicket/pom.xml with the maven-eclipse-plugin as parent.
>>>>
>>>> kind regards
>>>>
>>>> Tobias
>>>>
>>>> Am 05.03.15 um 08:16 schrieb Emond Papegaaij:
>>>>> Hi Tobias,
>>>>>
>>>>> This is a limitation (and feature) of the plugin. It does not simply
>>>>> copy
>>>>> files, but transfers settings. You can only use it with actual
>>>>> properties-
>>>>> files and existing settings. Eclipse does not like it when plugins
>>>>> overwrite settings files, so the plugin uses the actual eclipse
>>>>> preference API.
>>>>>
>>>>> Best regards,
>>>>> Emond
>>>>>
>>>>> On Wednesday 04 March 2015 23:45:21 Tobias Soloschenko wrote:
>>>>>> Hi Emond,
>>>>>>
>>>>>> I tried to get the plugin working for me but I failed. Maybe I missed
>>>>>> something.
>>>>>>
>>>>>> https://github.com/klopfdreh/wicket/commit/1f3ca3ffe2ba7633339719824fb5
>>>>>> e1
>>>>>> 219 7bcb243#diff-600376dffeb79835ede4a0b285078036R247
>>>>>>
>>>>>> Here is the root pom.xml
>>>>>>
>>>>>> https://github.com/klopfdreh/wicket/blob/1f3ca3ffe2ba7633339719824fb5e1
>>>>>> 21
>>>>>> 97b cb243/pom.xml
>>>>>>
>>>>>> 1. I added a submodule wicket-eclipse-settings with a folder called
>>>>>> files and put in an empty file "test"
>>>>>> 2. I added the module to the list of modules
>>>>>> <modules><module>wicket-eclipse-settings</module>........</modules>
>>>>>> 3. Then I added the dependency of wicket-eclipse-settings to the
>>>>>> project
>>>>>> dependencies and the maven-eclipse-plugin dependencies and placed in
>>>>>> additionalConfig to copy the "test"-file at the right position
>>>>>>
>>>>>> What I expected is that the test file is copied to
>>>>>> <working-dir>/wicket-core/.settings/test when I run a "clean package"
>>>>>> at
>>>>>> wicket-core.
>>>>>>
>>>>>> It seems that package doesn't run the maven-eclipse-plugin at all
>>>>>>
>>>>>> kind regards
>>>>>>
>>>>>> Tobias
>>>>>>
>>>>>> P.S.: Sorry for some missing spaces - if it is fixed I will commit the
>>>>>> pom well formatted - the commits can be squashed then.
>>>>>>
>>>>>> Am 04.03.15 um 10:28 schrieb Emond Papegaaij:
>>>>>>> The maven-eclipse-plugin is not maintained at all. Everyone should use
>>>>>>> m2e. We have developed an eclipse plugin to apply these settings
>>>>>>> automatically when using m2e:
>>>>>>> https://github.com/topicusonderwijs/m2e-settings
>>>>>>>
>>>>>>> I think we should create a wicket-eclipse-settings maven artifact and
>>>>>>> use
>>>>>>> that.
>>>>>>>
>>>>>>> Best regards,
>>>>>>> Emond
>>>>>>>
>>>>>>> On Wednesday 04 March 2015 10:09:31 Tobias Soloschenko wrote:
>>>>>>>> Hi Martin,
>>>>>>>>
>>>>>>>> maybe we can use the maven-eclipse-plugin to apply formatting rules:
>>>>>>>>
>>>>>>>> http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-co
>>>>>>>> de
>>>>>>>> -s
>>>>>>>> tyl es.html
>>>>>>>>
>>>>>>>> The plugin itself is not well maintained, but we only need to apply
>>>>>>>> the
>>>>>>>> formatting rules to the IDE - I think on IDEA it is ignored, but we
>>>>>>>> have
>>>>>>>> to
>>>>>>>> check it.
>>>>>>>>
>>>>>>>> Does this address your feature?
>>>>>>>>
>>>>>>>> kind regards
>>>>>>>>
>>>>>>>> Tobias
>>>>>>>>
>>>>>>>> 2015-03-04 9:30 GMT+01:00 Martin Grigorov <mg...@apache.org>:
>>>>>>>>> Hi Tobias,
>>>>>>>>>
>>>>>>>>> I personally use Intellij IDEA and these files are in not in use by
>>>>>>>>> me.
>>>>>>>>> But AFAIR the most useful feature in them is the code formatting
>>>>>>>>> rules.
>>>>>>>>> We
>>>>>>>>> try to keep Wicket code formatted the same style. IMO this helps a
>>>>>>>>> lot
>>>>>>>>> in
>>>>>>>>> maintenance. I personally get distracted when debugging something
>>>>>>>>> and
>>>>>>>>> see
>>>>>>>>> code snippet that is wrongly formatted, or doesn't use braces, or
>>>>>>>>> something
>>>>>>>>> similar.
>>>>>>>>>
>>>>>>>>> I think I am the only user of IDEA in the team (except Peter Ertl,
>>>>>>>>> but
>>>>>>>>> he
>>>>>>>>> is not very active lately) so I'm sure others will give their
>>>>>>>>> feedback
>>>>>>>>> on
>>>>>>>>> this soon.
>>>>>>>>>
>>>>>>>>> Martin Grigorov
>>>>>>>>> Wicket Training and Consulting
>>>>>>>>> https://twitter.com/mtgrigorov
>>>>>>>>>
>>>>>>>>> On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
>>>>>>>>>
>>>>>>>>> tobiassoloschenko@googlemail.com> wrote:
>>>>>>>>>> Hi everyone,
>>>>>>>>>>
>>>>>>>>>> I saw that there were several commits to .settings the last time
>>>>>>>>>> and
>>>>>>>>>> I
>>>>>>>>>> wondered why this folder is required in the repository anymore.
>>>>>>>>>> Here
>>>>>>>>>> is
>>>>>>>>>> a
>>>>>>>>>> list of the files in a .settings folder (wicket/.settings)
>>>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.c
>>>>>>>>> or
>>>>>>>>> e.
>>>>>>>>> re
>>>>>>>>> sources.prefs
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m
>>>>>>>>> 2e
>>>>>>>>> .c
>>>>>>>>> or
>>>>>>>>> e.prefs
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.p
>>>>>>>>> de
>>>>>>>>> .c
>>>>>>>>> or
>>>>>>>>> e.prefs
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.w
>>>>>>>>> st
>>>>>>>>> .c
>>>>>>>>> om
>>>>>>>>> mon.component
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.w
>>>>>>>>> st
>>>>>>>>> .c
>>>>>>>>> om
>>>>>>>>> mon.project.facet.core.xml>
>>>>>>>>>
>>>>>>>>>> I think because maven is used to configure the projects we can
>>>>>>>>>> remove
>>>>>>>>> those
>>>>>>>>>
>>>>>>>>>> files from the repository and configure it all in maven.
>>>>>>>>>>
>>>>>>>>>> Encoding can be configured by (see
>>>>>>>>>> http://maven.apache.org/general.html#encoding-warning):
>>>>>>>>>>
>>>>>>>>>> <properties>
>>>>>>>>>>
>>>>>>>>>> <project.build.sourceEncoding>UTF-8</project.build.sourceEnc
>>>>>>>>>> odi
>>>>>>>>>> ng>
>>>>>>>>> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEnc
>>>>>>>>> od
>>>>>>>>> in
>>>>>>>>> g>
>>>>>>>>>
>>>>>>>>>> </properties>
>>>>>>>>>>
>>>>>>>>>> Java Compile-Level can be configured with the compiler-plugin:
>>>>>>>>>> <plugins>
>>>>>>>>>>
>>>>>>>>>> <plugin>
>>>>>>>>>>
>>>>>>>>>> <groupId>org.apache.maven.plugins</groupId>
>>>>>>>>>> <artifactId>maven-compiler-plugin</artifactId>
>>>>>>>>>> <version>3.2</version>
>>>>>>>>>> <configuration>
>>>>>>>>>>
>>>>>>>>>> <source>1.7</source>
>>>>>>>>>> <target>1.7</target>
>>>>>>>>>>
>>>>>>>>>> </configuration>
>>>>>>>>>>
>>>>>>>>>> </plugin>
>>>>>>>>>>
>>>>>>>>>> </plugins>
>>>>>>>>>>
>>>>>>>>>> The project facets are configured by "Maven Integration for Eclipse
>>>>>>>>>> WTP"
>>>>>>>>>> and it receives the information of the web.xml and the packaging
>>>>>>>>> configured
>>>>>>>>>
>>>>>>>>>> in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
>>>>>>>>>> http://marketplace.eclipse.org/node/96737)
>>>>>>>>>>
>>>>>>>>>> The only entries to be custom configured are in
>>>>>>>>>> org.eclipse.core.resources.prefs containing .deprecations and I
>>>>>>>>>> wonder
>>>>>>>>>> if
>>>>>>>>>> they are required anymore.
>>>>>>>>>>
>>>>>>>>>> The only thing to be done after importing the project into
>>>>>>>>>> workspace
>>>>>>>>>> is
>>>>>>>>> to
>>>>>>>>>
>>>>>>>>>> configure it as maven project. The .settings folder is created
>>>>>>>>>> through
>>>>>>>>> the
>>>>>>>>>
>>>>>>>>>> m2e plugin based on the pom.xml, web.xml.
>>>>>>>>>>
>>>>>>>>>> Did I overlook something?
>>>>>>>>>>
>>>>>>>>>> What do you think?
>>>>>>>>>>
>>>>>>>>>> kind regards
>>>>>>>>>>
>>>>>>>>>> Tobias
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Tobias Soloschenko <to...@googlemail.com>.
Hi,
I prepared a commit for wicket-6.x, too. So if everything is ok with
master - I merge it for wicket-6.x.
kind regards
Tobias
Am 05.03.15 um 10:34 schrieb Emond Papegaaij:
> m2e cannot resolve plugin dependencies from your workspace, so your
> observation is correct. I don't think this is a big deal, because settings
> don't change very often. Perhaps it's best to keep this settings artifact
> completely separate from the wicket modules itself, in a subdirectory, with
> its own version and parent. We can release 1.0 (simply 1?) and keep it that
> way until a change is needed.
>
> Best regards,
> Emond
>
> On Thursday 05 March 2015 10:15:47 Tobias Soloschenko wrote:
>> Hi,
>>
>> I removed the parent of wicket-eclipse-settings, because otherwise the
>> plugin tries to apply the wicket-eclipse-settings to itself, which is
>> simply not working. :-)
>>
>> I added the additionalConfig section and put in the
>> org.eclipse.jdt.core.prefs and checked the location in the jar which is
>> "/org.eclipse.jdt.core.prefs"
>>
>> I installed the eclipse plugin from the markedplace.
>>
>> The only issue left is that you can't add a dependency only located in
>> your workspace. If I install wicket-eclipse-settings with "clean
>> install" and give it a right number like 1.0 and change the dependencies
>> like the following block - everything is fine (but with SNAPSHOT it is
>> not working):
>>
>> <dependencies>
>> ...
>> <dependency>
>> <groupId>org.apache.wicket</groupId>
>> <artifactId>wicket-eclipse-settings</artifactId>
>> <version>1.0</version>
>> </dependency>
>> ...
>> </dependencies>
>> ...
>> <plugin>
>> <groupId>org.apache.maven.plugins</groupId>
>> <artifactId>maven-eclipse-plugin</artifactId>
>> <version>2.9</version>
>> <configuration>
>> <downloadSources>true</downloadSources>
>> <additionalConfig>
>> <file>
>> <name>.settings/org.eclipse.jdt.core.prefs</name>
>> <location>/org.eclipse.jdt.core.prefs</location>
>> </file>
>> </additionalConfig>
>> </configuration>
>> <dependencies>
>> <dependency>
>> <groupId>org.apache.wicket</groupId>
>> <artifactId>wicket-eclipse-settings</artifactId>
>> <version>1.0</version>
>> </dependency>
>> </dependencies>
>> </plugin>
>>
>> kind regards
>>
>> Tobias
>>
>> Am 05.03.15 um 09:52 schrieb Emond Papegaaij:
>>> Hi Tobias,
>>>
>>> It seems you are missing the additionalConfig section in the
>>> maven-eclipse-
>>> plugin configuration. You need to list .prefs files from which settings
>>> need to be copied:
>>> <additionalConfig>
>>>
>>> <file>
>>>
>>> <name>.settings/org.eclipse.core.resources.prefs</name>
>>> <location>/org.eclipse.core.resources.prefs</location>
>>>
>>> </file>
>>> ...
>>>
>>> </additionalConfig>
>>>
>>> location is the location of the .prefs file in the jar, name is the
>>> location of the .prefs file relative to the project (so always starts
>>> with .settings/).
>>>
>>> Note that the m2e-settings plugin only uses the maven-eclipse-plugin
>>> configuration as a container for its configuration. You should not run mvn
>>> eclipse:eclipse.
>>>
>>> Best regards,
>>> Emond
>>>
>>> On Thursday 05 March 2015 09:19:07 Tobias Soloschenko wrote:
>>>> Ah, now I see. Thank you for the explanation! :-)
>>>>
>>>> @Emond: Would you be so kind and have a look if the way I configured it
>>>> in the branch https://github.com/klopfdreh/wicket/tree/WICKET-5848 is
>>>> like intended?
>>>>
>>>> @Martin: Is somewhere a still existing preference
>>>> (org.eclipse.jdt.ui.prefs) which shows how the code style formatting has
>>>> been applied before it has been removed from version control? I would
>>>> simply copy the file into the "files" folder of wicket-eclipse-settings
>>>> and as I understood eclipse then takes the setting for each project
>>>> which has the wicket/pom.xml with the maven-eclipse-plugin as parent.
>>>>
>>>> kind regards
>>>>
>>>> Tobias
>>>>
>>>> Am 05.03.15 um 08:16 schrieb Emond Papegaaij:
>>>>> Hi Tobias,
>>>>>
>>>>> This is a limitation (and feature) of the plugin. It does not simply
>>>>> copy
>>>>> files, but transfers settings. You can only use it with actual
>>>>> properties-
>>>>> files and existing settings. Eclipse does not like it when plugins
>>>>> overwrite settings files, so the plugin uses the actual eclipse
>>>>> preference API.
>>>>>
>>>>> Best regards,
>>>>> Emond
>>>>>
>>>>> On Wednesday 04 March 2015 23:45:21 Tobias Soloschenko wrote:
>>>>>> Hi Emond,
>>>>>>
>>>>>> I tried to get the plugin working for me but I failed. Maybe I missed
>>>>>> something.
>>>>>>
>>>>>> https://github.com/klopfdreh/wicket/commit/1f3ca3ffe2ba7633339719824fb5
>>>>>> e1
>>>>>> 219 7bcb243#diff-600376dffeb79835ede4a0b285078036R247
>>>>>>
>>>>>> Here is the root pom.xml
>>>>>>
>>>>>> https://github.com/klopfdreh/wicket/blob/1f3ca3ffe2ba7633339719824fb5e1
>>>>>> 21
>>>>>> 97b cb243/pom.xml
>>>>>>
>>>>>> 1. I added a submodule wicket-eclipse-settings with a folder called
>>>>>> files and put in an empty file "test"
>>>>>> 2. I added the module to the list of modules
>>>>>> <modules><module>wicket-eclipse-settings</module>........</modules>
>>>>>> 3. Then I added the dependency of wicket-eclipse-settings to the
>>>>>> project
>>>>>> dependencies and the maven-eclipse-plugin dependencies and placed in
>>>>>> additionalConfig to copy the "test"-file at the right position
>>>>>>
>>>>>> What I expected is that the test file is copied to
>>>>>> <working-dir>/wicket-core/.settings/test when I run a "clean package"
>>>>>> at
>>>>>> wicket-core.
>>>>>>
>>>>>> It seems that package doesn't run the maven-eclipse-plugin at all
>>>>>>
>>>>>> kind regards
>>>>>>
>>>>>> Tobias
>>>>>>
>>>>>> P.S.: Sorry for some missing spaces - if it is fixed I will commit the
>>>>>> pom well formatted - the commits can be squashed then.
>>>>>>
>>>>>> Am 04.03.15 um 10:28 schrieb Emond Papegaaij:
>>>>>>> The maven-eclipse-plugin is not maintained at all. Everyone should use
>>>>>>> m2e. We have developed an eclipse plugin to apply these settings
>>>>>>> automatically when using m2e:
>>>>>>> https://github.com/topicusonderwijs/m2e-settings
>>>>>>>
>>>>>>> I think we should create a wicket-eclipse-settings maven artifact and
>>>>>>> use
>>>>>>> that.
>>>>>>>
>>>>>>> Best regards,
>>>>>>> Emond
>>>>>>>
>>>>>>> On Wednesday 04 March 2015 10:09:31 Tobias Soloschenko wrote:
>>>>>>>> Hi Martin,
>>>>>>>>
>>>>>>>> maybe we can use the maven-eclipse-plugin to apply formatting rules:
>>>>>>>>
>>>>>>>> http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-co
>>>>>>>> de
>>>>>>>> -s
>>>>>>>> tyl es.html
>>>>>>>>
>>>>>>>> The plugin itself is not well maintained, but we only need to apply
>>>>>>>> the
>>>>>>>> formatting rules to the IDE - I think on IDEA it is ignored, but we
>>>>>>>> have
>>>>>>>> to
>>>>>>>> check it.
>>>>>>>>
>>>>>>>> Does this address your feature?
>>>>>>>>
>>>>>>>> kind regards
>>>>>>>>
>>>>>>>> Tobias
>>>>>>>>
>>>>>>>> 2015-03-04 9:30 GMT+01:00 Martin Grigorov <mg...@apache.org>:
>>>>>>>>> Hi Tobias,
>>>>>>>>>
>>>>>>>>> I personally use Intellij IDEA and these files are in not in use by
>>>>>>>>> me.
>>>>>>>>> But AFAIR the most useful feature in them is the code formatting
>>>>>>>>> rules.
>>>>>>>>> We
>>>>>>>>> try to keep Wicket code formatted the same style. IMO this helps a
>>>>>>>>> lot
>>>>>>>>> in
>>>>>>>>> maintenance. I personally get distracted when debugging something
>>>>>>>>> and
>>>>>>>>> see
>>>>>>>>> code snippet that is wrongly formatted, or doesn't use braces, or
>>>>>>>>> something
>>>>>>>>> similar.
>>>>>>>>>
>>>>>>>>> I think I am the only user of IDEA in the team (except Peter Ertl,
>>>>>>>>> but
>>>>>>>>> he
>>>>>>>>> is not very active lately) so I'm sure others will give their
>>>>>>>>> feedback
>>>>>>>>> on
>>>>>>>>> this soon.
>>>>>>>>>
>>>>>>>>> Martin Grigorov
>>>>>>>>> Wicket Training and Consulting
>>>>>>>>> https://twitter.com/mtgrigorov
>>>>>>>>>
>>>>>>>>> On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
>>>>>>>>>
>>>>>>>>> tobiassoloschenko@googlemail.com> wrote:
>>>>>>>>>> Hi everyone,
>>>>>>>>>>
>>>>>>>>>> I saw that there were several commits to .settings the last time
>>>>>>>>>> and
>>>>>>>>>> I
>>>>>>>>>> wondered why this folder is required in the repository anymore.
>>>>>>>>>> Here
>>>>>>>>>> is
>>>>>>>>>> a
>>>>>>>>>> list of the files in a .settings folder (wicket/.settings)
>>>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.c
>>>>>>>>> or
>>>>>>>>> e.
>>>>>>>>> re
>>>>>>>>> sources.prefs
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m
>>>>>>>>> 2e
>>>>>>>>> .c
>>>>>>>>> or
>>>>>>>>> e.prefs
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.p
>>>>>>>>> de
>>>>>>>>> .c
>>>>>>>>> or
>>>>>>>>> e.prefs
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.w
>>>>>>>>> st
>>>>>>>>> .c
>>>>>>>>> om
>>>>>>>>> mon.component
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.w
>>>>>>>>> st
>>>>>>>>> .c
>>>>>>>>> om
>>>>>>>>> mon.project.facet.core.xml>
>>>>>>>>>
>>>>>>>>>> I think because maven is used to configure the projects we can
>>>>>>>>>> remove
>>>>>>>>> those
>>>>>>>>>
>>>>>>>>>> files from the repository and configure it all in maven.
>>>>>>>>>>
>>>>>>>>>> Encoding can be configured by (see
>>>>>>>>>> http://maven.apache.org/general.html#encoding-warning):
>>>>>>>>>>
>>>>>>>>>> <properties>
>>>>>>>>>>
>>>>>>>>>> <project.build.sourceEncoding>UTF-8</project.build.sourceEnc
>>>>>>>>>> odi
>>>>>>>>>> ng>
>>>>>>>>> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEnc
>>>>>>>>> od
>>>>>>>>> in
>>>>>>>>> g>
>>>>>>>>>
>>>>>>>>>> </properties>
>>>>>>>>>>
>>>>>>>>>> Java Compile-Level can be configured with the compiler-plugin:
>>>>>>>>>> <plugins>
>>>>>>>>>>
>>>>>>>>>> <plugin>
>>>>>>>>>>
>>>>>>>>>> <groupId>org.apache.maven.plugins</groupId>
>>>>>>>>>> <artifactId>maven-compiler-plugin</artifactId>
>>>>>>>>>> <version>3.2</version>
>>>>>>>>>> <configuration>
>>>>>>>>>>
>>>>>>>>>> <source>1.7</source>
>>>>>>>>>> <target>1.7</target>
>>>>>>>>>>
>>>>>>>>>> </configuration>
>>>>>>>>>>
>>>>>>>>>> </plugin>
>>>>>>>>>>
>>>>>>>>>> </plugins>
>>>>>>>>>>
>>>>>>>>>> The project facets are configured by "Maven Integration for Eclipse
>>>>>>>>>> WTP"
>>>>>>>>>> and it receives the information of the web.xml and the packaging
>>>>>>>>> configured
>>>>>>>>>
>>>>>>>>>> in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
>>>>>>>>>> http://marketplace.eclipse.org/node/96737)
>>>>>>>>>>
>>>>>>>>>> The only entries to be custom configured are in
>>>>>>>>>> org.eclipse.core.resources.prefs containing .deprecations and I
>>>>>>>>>> wonder
>>>>>>>>>> if
>>>>>>>>>> they are required anymore.
>>>>>>>>>>
>>>>>>>>>> The only thing to be done after importing the project into
>>>>>>>>>> workspace
>>>>>>>>>> is
>>>>>>>>> to
>>>>>>>>>
>>>>>>>>>> configure it as maven project. The .settings folder is created
>>>>>>>>>> through
>>>>>>>>> the
>>>>>>>>>
>>>>>>>>>> m2e plugin based on the pom.xml, web.xml.
>>>>>>>>>>
>>>>>>>>>> Did I overlook something?
>>>>>>>>>>
>>>>>>>>>> What do you think?
>>>>>>>>>>
>>>>>>>>>> kind regards
>>>>>>>>>>
>>>>>>>>>> Tobias
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Tobias Soloschenko <to...@googlemail.com>.
Ok, I changed the parent pom and removed wicket-eclipse-settings from
the list of modules and changed the version number to 1. Someone has to
upload version 1 into the central repository, before the commit is
applied to wicket-master - otherwise there would be a lot of errors
while importing the projects. ;-)
I think there is no dedicated parent needed for the settings - we can
keep it as subfolder in wicket. What do you think?
So the way for a wicket developer using eclipse to ensure the formatting
rules would look like this:
1. Go into the markedplace and search for M2E Settings and install it
2. Import the project she/he wants to improve and apply code
For me this looks really simple. :-)
kind regards and thanks a lot for the support Emond!
Tobias
P.S.: I'm going to create the pull request later today - or if it is
required earlier it's the WICKET-5848 in my wicket repo.
Am 05.03.15 um 10:34 schrieb Emond Papegaaij:
> m2e cannot resolve plugin dependencies from your workspace, so your
> observation is correct. I don't think this is a big deal, because settings
> don't change very often. Perhaps it's best to keep this settings artifact
> completely separate from the wicket modules itself, in a subdirectory, with
> its own version and parent. We can release 1.0 (simply 1?) and keep it that
> way until a change is needed.
>
> Best regards,
> Emond
>
> On Thursday 05 March 2015 10:15:47 Tobias Soloschenko wrote:
>> Hi,
>>
>> I removed the parent of wicket-eclipse-settings, because otherwise the
>> plugin tries to apply the wicket-eclipse-settings to itself, which is
>> simply not working. :-)
>>
>> I added the additionalConfig section and put in the
>> org.eclipse.jdt.core.prefs and checked the location in the jar which is
>> "/org.eclipse.jdt.core.prefs"
>>
>> I installed the eclipse plugin from the markedplace.
>>
>> The only issue left is that you can't add a dependency only located in
>> your workspace. If I install wicket-eclipse-settings with "clean
>> install" and give it a right number like 1.0 and change the dependencies
>> like the following block - everything is fine (but with SNAPSHOT it is
>> not working):
>>
>> <dependencies>
>> ...
>> <dependency>
>> <groupId>org.apache.wicket</groupId>
>> <artifactId>wicket-eclipse-settings</artifactId>
>> <version>1.0</version>
>> </dependency>
>> ...
>> </dependencies>
>> ...
>> <plugin>
>> <groupId>org.apache.maven.plugins</groupId>
>> <artifactId>maven-eclipse-plugin</artifactId>
>> <version>2.9</version>
>> <configuration>
>> <downloadSources>true</downloadSources>
>> <additionalConfig>
>> <file>
>> <name>.settings/org.eclipse.jdt.core.prefs</name>
>> <location>/org.eclipse.jdt.core.prefs</location>
>> </file>
>> </additionalConfig>
>> </configuration>
>> <dependencies>
>> <dependency>
>> <groupId>org.apache.wicket</groupId>
>> <artifactId>wicket-eclipse-settings</artifactId>
>> <version>1.0</version>
>> </dependency>
>> </dependencies>
>> </plugin>
>>
>> kind regards
>>
>> Tobias
>>
>> Am 05.03.15 um 09:52 schrieb Emond Papegaaij:
>>> Hi Tobias,
>>>
>>> It seems you are missing the additionalConfig section in the
>>> maven-eclipse-
>>> plugin configuration. You need to list .prefs files from which settings
>>> need to be copied:
>>> <additionalConfig>
>>>
>>> <file>
>>>
>>> <name>.settings/org.eclipse.core.resources.prefs</name>
>>> <location>/org.eclipse.core.resources.prefs</location>
>>>
>>> </file>
>>> ...
>>>
>>> </additionalConfig>
>>>
>>> location is the location of the .prefs file in the jar, name is the
>>> location of the .prefs file relative to the project (so always starts
>>> with .settings/).
>>>
>>> Note that the m2e-settings plugin only uses the maven-eclipse-plugin
>>> configuration as a container for its configuration. You should not run mvn
>>> eclipse:eclipse.
>>>
>>> Best regards,
>>> Emond
>>>
>>> On Thursday 05 March 2015 09:19:07 Tobias Soloschenko wrote:
>>>> Ah, now I see. Thank you for the explanation! :-)
>>>>
>>>> @Emond: Would you be so kind and have a look if the way I configured it
>>>> in the branch https://github.com/klopfdreh/wicket/tree/WICKET-5848 is
>>>> like intended?
>>>>
>>>> @Martin: Is somewhere a still existing preference
>>>> (org.eclipse.jdt.ui.prefs) which shows how the code style formatting has
>>>> been applied before it has been removed from version control? I would
>>>> simply copy the file into the "files" folder of wicket-eclipse-settings
>>>> and as I understood eclipse then takes the setting for each project
>>>> which has the wicket/pom.xml with the maven-eclipse-plugin as parent.
>>>>
>>>> kind regards
>>>>
>>>> Tobias
>>>>
>>>> Am 05.03.15 um 08:16 schrieb Emond Papegaaij:
>>>>> Hi Tobias,
>>>>>
>>>>> This is a limitation (and feature) of the plugin. It does not simply
>>>>> copy
>>>>> files, but transfers settings. You can only use it with actual
>>>>> properties-
>>>>> files and existing settings. Eclipse does not like it when plugins
>>>>> overwrite settings files, so the plugin uses the actual eclipse
>>>>> preference API.
>>>>>
>>>>> Best regards,
>>>>> Emond
>>>>>
>>>>> On Wednesday 04 March 2015 23:45:21 Tobias Soloschenko wrote:
>>>>>> Hi Emond,
>>>>>>
>>>>>> I tried to get the plugin working for me but I failed. Maybe I missed
>>>>>> something.
>>>>>>
>>>>>> https://github.com/klopfdreh/wicket/commit/1f3ca3ffe2ba7633339719824fb5
>>>>>> e1
>>>>>> 219 7bcb243#diff-600376dffeb79835ede4a0b285078036R247
>>>>>>
>>>>>> Here is the root pom.xml
>>>>>>
>>>>>> https://github.com/klopfdreh/wicket/blob/1f3ca3ffe2ba7633339719824fb5e1
>>>>>> 21
>>>>>> 97b cb243/pom.xml
>>>>>>
>>>>>> 1. I added a submodule wicket-eclipse-settings with a folder called
>>>>>> files and put in an empty file "test"
>>>>>> 2. I added the module to the list of modules
>>>>>> <modules><module>wicket-eclipse-settings</module>........</modules>
>>>>>> 3. Then I added the dependency of wicket-eclipse-settings to the
>>>>>> project
>>>>>> dependencies and the maven-eclipse-plugin dependencies and placed in
>>>>>> additionalConfig to copy the "test"-file at the right position
>>>>>>
>>>>>> What I expected is that the test file is copied to
>>>>>> <working-dir>/wicket-core/.settings/test when I run a "clean package"
>>>>>> at
>>>>>> wicket-core.
>>>>>>
>>>>>> It seems that package doesn't run the maven-eclipse-plugin at all
>>>>>>
>>>>>> kind regards
>>>>>>
>>>>>> Tobias
>>>>>>
>>>>>> P.S.: Sorry for some missing spaces - if it is fixed I will commit the
>>>>>> pom well formatted - the commits can be squashed then.
>>>>>>
>>>>>> Am 04.03.15 um 10:28 schrieb Emond Papegaaij:
>>>>>>> The maven-eclipse-plugin is not maintained at all. Everyone should use
>>>>>>> m2e. We have developed an eclipse plugin to apply these settings
>>>>>>> automatically when using m2e:
>>>>>>> https://github.com/topicusonderwijs/m2e-settings
>>>>>>>
>>>>>>> I think we should create a wicket-eclipse-settings maven artifact and
>>>>>>> use
>>>>>>> that.
>>>>>>>
>>>>>>> Best regards,
>>>>>>> Emond
>>>>>>>
>>>>>>> On Wednesday 04 March 2015 10:09:31 Tobias Soloschenko wrote:
>>>>>>>> Hi Martin,
>>>>>>>>
>>>>>>>> maybe we can use the maven-eclipse-plugin to apply formatting rules:
>>>>>>>>
>>>>>>>> http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-co
>>>>>>>> de
>>>>>>>> -s
>>>>>>>> tyl es.html
>>>>>>>>
>>>>>>>> The plugin itself is not well maintained, but we only need to apply
>>>>>>>> the
>>>>>>>> formatting rules to the IDE - I think on IDEA it is ignored, but we
>>>>>>>> have
>>>>>>>> to
>>>>>>>> check it.
>>>>>>>>
>>>>>>>> Does this address your feature?
>>>>>>>>
>>>>>>>> kind regards
>>>>>>>>
>>>>>>>> Tobias
>>>>>>>>
>>>>>>>> 2015-03-04 9:30 GMT+01:00 Martin Grigorov <mg...@apache.org>:
>>>>>>>>> Hi Tobias,
>>>>>>>>>
>>>>>>>>> I personally use Intellij IDEA and these files are in not in use by
>>>>>>>>> me.
>>>>>>>>> But AFAIR the most useful feature in them is the code formatting
>>>>>>>>> rules.
>>>>>>>>> We
>>>>>>>>> try to keep Wicket code formatted the same style. IMO this helps a
>>>>>>>>> lot
>>>>>>>>> in
>>>>>>>>> maintenance. I personally get distracted when debugging something
>>>>>>>>> and
>>>>>>>>> see
>>>>>>>>> code snippet that is wrongly formatted, or doesn't use braces, or
>>>>>>>>> something
>>>>>>>>> similar.
>>>>>>>>>
>>>>>>>>> I think I am the only user of IDEA in the team (except Peter Ertl,
>>>>>>>>> but
>>>>>>>>> he
>>>>>>>>> is not very active lately) so I'm sure others will give their
>>>>>>>>> feedback
>>>>>>>>> on
>>>>>>>>> this soon.
>>>>>>>>>
>>>>>>>>> Martin Grigorov
>>>>>>>>> Wicket Training and Consulting
>>>>>>>>> https://twitter.com/mtgrigorov
>>>>>>>>>
>>>>>>>>> On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
>>>>>>>>>
>>>>>>>>> tobiassoloschenko@googlemail.com> wrote:
>>>>>>>>>> Hi everyone,
>>>>>>>>>>
>>>>>>>>>> I saw that there were several commits to .settings the last time
>>>>>>>>>> and
>>>>>>>>>> I
>>>>>>>>>> wondered why this folder is required in the repository anymore.
>>>>>>>>>> Here
>>>>>>>>>> is
>>>>>>>>>> a
>>>>>>>>>> list of the files in a .settings folder (wicket/.settings)
>>>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.c
>>>>>>>>> or
>>>>>>>>> e.
>>>>>>>>> re
>>>>>>>>> sources.prefs
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m
>>>>>>>>> 2e
>>>>>>>>> .c
>>>>>>>>> or
>>>>>>>>> e.prefs
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.p
>>>>>>>>> de
>>>>>>>>> .c
>>>>>>>>> or
>>>>>>>>> e.prefs
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.w
>>>>>>>>> st
>>>>>>>>> .c
>>>>>>>>> om
>>>>>>>>> mon.component
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.w
>>>>>>>>> st
>>>>>>>>> .c
>>>>>>>>> om
>>>>>>>>> mon.project.facet.core.xml>
>>>>>>>>>
>>>>>>>>>> I think because maven is used to configure the projects we can
>>>>>>>>>> remove
>>>>>>>>> those
>>>>>>>>>
>>>>>>>>>> files from the repository and configure it all in maven.
>>>>>>>>>>
>>>>>>>>>> Encoding can be configured by (see
>>>>>>>>>> http://maven.apache.org/general.html#encoding-warning):
>>>>>>>>>>
>>>>>>>>>> <properties>
>>>>>>>>>>
>>>>>>>>>> <project.build.sourceEncoding>UTF-8</project.build.sourceEnc
>>>>>>>>>> odi
>>>>>>>>>> ng>
>>>>>>>>> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEnc
>>>>>>>>> od
>>>>>>>>> in
>>>>>>>>> g>
>>>>>>>>>
>>>>>>>>>> </properties>
>>>>>>>>>>
>>>>>>>>>> Java Compile-Level can be configured with the compiler-plugin:
>>>>>>>>>> <plugins>
>>>>>>>>>>
>>>>>>>>>> <plugin>
>>>>>>>>>>
>>>>>>>>>> <groupId>org.apache.maven.plugins</groupId>
>>>>>>>>>> <artifactId>maven-compiler-plugin</artifactId>
>>>>>>>>>> <version>3.2</version>
>>>>>>>>>> <configuration>
>>>>>>>>>>
>>>>>>>>>> <source>1.7</source>
>>>>>>>>>> <target>1.7</target>
>>>>>>>>>>
>>>>>>>>>> </configuration>
>>>>>>>>>>
>>>>>>>>>> </plugin>
>>>>>>>>>>
>>>>>>>>>> </plugins>
>>>>>>>>>>
>>>>>>>>>> The project facets are configured by "Maven Integration for Eclipse
>>>>>>>>>> WTP"
>>>>>>>>>> and it receives the information of the web.xml and the packaging
>>>>>>>>> configured
>>>>>>>>>
>>>>>>>>>> in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
>>>>>>>>>> http://marketplace.eclipse.org/node/96737)
>>>>>>>>>>
>>>>>>>>>> The only entries to be custom configured are in
>>>>>>>>>> org.eclipse.core.resources.prefs containing .deprecations and I
>>>>>>>>>> wonder
>>>>>>>>>> if
>>>>>>>>>> they are required anymore.
>>>>>>>>>>
>>>>>>>>>> The only thing to be done after importing the project into
>>>>>>>>>> workspace
>>>>>>>>>> is
>>>>>>>>> to
>>>>>>>>>
>>>>>>>>>> configure it as maven project. The .settings folder is created
>>>>>>>>>> through
>>>>>>>>> the
>>>>>>>>>
>>>>>>>>>> m2e plugin based on the pom.xml, web.xml.
>>>>>>>>>>
>>>>>>>>>> Did I overlook something?
>>>>>>>>>>
>>>>>>>>>> What do you think?
>>>>>>>>>>
>>>>>>>>>> kind regards
>>>>>>>>>>
>>>>>>>>>> Tobias
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Emond Papegaaij <em...@topicus.nl>.
m2e cannot resolve plugin dependencies from your workspace, so your
observation is correct. I don't think this is a big deal, because settings
don't change very often. Perhaps it's best to keep this settings artifact
completely separate from the wicket modules itself, in a subdirectory, with
its own version and parent. We can release 1.0 (simply 1?) and keep it that
way until a change is needed.
Best regards,
Emond
On Thursday 05 March 2015 10:15:47 Tobias Soloschenko wrote:
> Hi,
>
> I removed the parent of wicket-eclipse-settings, because otherwise the
> plugin tries to apply the wicket-eclipse-settings to itself, which is
> simply not working. :-)
>
> I added the additionalConfig section and put in the
> org.eclipse.jdt.core.prefs and checked the location in the jar which is
> "/org.eclipse.jdt.core.prefs"
>
> I installed the eclipse plugin from the markedplace.
>
> The only issue left is that you can't add a dependency only located in
> your workspace. If I install wicket-eclipse-settings with "clean
> install" and give it a right number like 1.0 and change the dependencies
> like the following block - everything is fine (but with SNAPSHOT it is
> not working):
>
> <dependencies>
> ...
> <dependency>
> <groupId>org.apache.wicket</groupId>
> <artifactId>wicket-eclipse-settings</artifactId>
> <version>1.0</version>
> </dependency>
> ...
> </dependencies>
> ...
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-eclipse-plugin</artifactId>
> <version>2.9</version>
> <configuration>
> <downloadSources>true</downloadSources>
> <additionalConfig>
> <file>
> <name>.settings/org.eclipse.jdt.core.prefs</name>
> <location>/org.eclipse.jdt.core.prefs</location>
> </file>
> </additionalConfig>
> </configuration>
> <dependencies>
> <dependency>
> <groupId>org.apache.wicket</groupId>
> <artifactId>wicket-eclipse-settings</artifactId>
> <version>1.0</version>
> </dependency>
> </dependencies>
> </plugin>
>
> kind regards
>
> Tobias
>
> Am 05.03.15 um 09:52 schrieb Emond Papegaaij:
> > Hi Tobias,
> >
> > It seems you are missing the additionalConfig section in the
> > maven-eclipse-
> > plugin configuration. You need to list .prefs files from which settings
> > need to be copied:
> > <additionalConfig>
> >
> > <file>
> >
> > <name>.settings/org.eclipse.core.resources.prefs</name>
> > <location>/org.eclipse.core.resources.prefs</location>
> >
> > </file>
> > ...
> >
> > </additionalConfig>
> >
> > location is the location of the .prefs file in the jar, name is the
> > location of the .prefs file relative to the project (so always starts
> > with .settings/).
> >
> > Note that the m2e-settings plugin only uses the maven-eclipse-plugin
> > configuration as a container for its configuration. You should not run mvn
> > eclipse:eclipse.
> >
> > Best regards,
> > Emond
> >
> > On Thursday 05 March 2015 09:19:07 Tobias Soloschenko wrote:
> >> Ah, now I see. Thank you for the explanation! :-)
> >>
> >> @Emond: Would you be so kind and have a look if the way I configured it
> >> in the branch https://github.com/klopfdreh/wicket/tree/WICKET-5848 is
> >> like intended?
> >>
> >> @Martin: Is somewhere a still existing preference
> >> (org.eclipse.jdt.ui.prefs) which shows how the code style formatting has
> >> been applied before it has been removed from version control? I would
> >> simply copy the file into the "files" folder of wicket-eclipse-settings
> >> and as I understood eclipse then takes the setting for each project
> >> which has the wicket/pom.xml with the maven-eclipse-plugin as parent.
> >>
> >> kind regards
> >>
> >> Tobias
> >>
> >> Am 05.03.15 um 08:16 schrieb Emond Papegaaij:
> >>> Hi Tobias,
> >>>
> >>> This is a limitation (and feature) of the plugin. It does not simply
> >>> copy
> >>> files, but transfers settings. You can only use it with actual
> >>> properties-
> >>> files and existing settings. Eclipse does not like it when plugins
> >>> overwrite settings files, so the plugin uses the actual eclipse
> >>> preference API.
> >>>
> >>> Best regards,
> >>> Emond
> >>>
> >>> On Wednesday 04 March 2015 23:45:21 Tobias Soloschenko wrote:
> >>>> Hi Emond,
> >>>>
> >>>> I tried to get the plugin working for me but I failed. Maybe I missed
> >>>> something.
> >>>>
> >>>> https://github.com/klopfdreh/wicket/commit/1f3ca3ffe2ba7633339719824fb5
> >>>> e1
> >>>> 219 7bcb243#diff-600376dffeb79835ede4a0b285078036R247
> >>>>
> >>>> Here is the root pom.xml
> >>>>
> >>>> https://github.com/klopfdreh/wicket/blob/1f3ca3ffe2ba7633339719824fb5e1
> >>>> 21
> >>>> 97b cb243/pom.xml
> >>>>
> >>>> 1. I added a submodule wicket-eclipse-settings with a folder called
> >>>> files and put in an empty file "test"
> >>>> 2. I added the module to the list of modules
> >>>> <modules><module>wicket-eclipse-settings</module>........</modules>
> >>>> 3. Then I added the dependency of wicket-eclipse-settings to the
> >>>> project
> >>>> dependencies and the maven-eclipse-plugin dependencies and placed in
> >>>> additionalConfig to copy the "test"-file at the right position
> >>>>
> >>>> What I expected is that the test file is copied to
> >>>> <working-dir>/wicket-core/.settings/test when I run a "clean package"
> >>>> at
> >>>> wicket-core.
> >>>>
> >>>> It seems that package doesn't run the maven-eclipse-plugin at all
> >>>>
> >>>> kind regards
> >>>>
> >>>> Tobias
> >>>>
> >>>> P.S.: Sorry for some missing spaces - if it is fixed I will commit the
> >>>> pom well formatted - the commits can be squashed then.
> >>>>
> >>>> Am 04.03.15 um 10:28 schrieb Emond Papegaaij:
> >>>>> The maven-eclipse-plugin is not maintained at all. Everyone should use
> >>>>> m2e. We have developed an eclipse plugin to apply these settings
> >>>>> automatically when using m2e:
> >>>>> https://github.com/topicusonderwijs/m2e-settings
> >>>>>
> >>>>> I think we should create a wicket-eclipse-settings maven artifact and
> >>>>> use
> >>>>> that.
> >>>>>
> >>>>> Best regards,
> >>>>> Emond
> >>>>>
> >>>>> On Wednesday 04 March 2015 10:09:31 Tobias Soloschenko wrote:
> >>>>>> Hi Martin,
> >>>>>>
> >>>>>> maybe we can use the maven-eclipse-plugin to apply formatting rules:
> >>>>>>
> >>>>>> http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-co
> >>>>>> de
> >>>>>> -s
> >>>>>> tyl es.html
> >>>>>>
> >>>>>> The plugin itself is not well maintained, but we only need to apply
> >>>>>> the
> >>>>>> formatting rules to the IDE - I think on IDEA it is ignored, but we
> >>>>>> have
> >>>>>> to
> >>>>>> check it.
> >>>>>>
> >>>>>> Does this address your feature?
> >>>>>>
> >>>>>> kind regards
> >>>>>>
> >>>>>> Tobias
> >>>>>>
> >>>>>> 2015-03-04 9:30 GMT+01:00 Martin Grigorov <mg...@apache.org>:
> >>>>>>> Hi Tobias,
> >>>>>>>
> >>>>>>> I personally use Intellij IDEA and these files are in not in use by
> >>>>>>> me.
> >>>>>>> But AFAIR the most useful feature in them is the code formatting
> >>>>>>> rules.
> >>>>>>> We
> >>>>>>> try to keep Wicket code formatted the same style. IMO this helps a
> >>>>>>> lot
> >>>>>>> in
> >>>>>>> maintenance. I personally get distracted when debugging something
> >>>>>>> and
> >>>>>>> see
> >>>>>>> code snippet that is wrongly formatted, or doesn't use braces, or
> >>>>>>> something
> >>>>>>> similar.
> >>>>>>>
> >>>>>>> I think I am the only user of IDEA in the team (except Peter Ertl,
> >>>>>>> but
> >>>>>>> he
> >>>>>>> is not very active lately) so I'm sure others will give their
> >>>>>>> feedback
> >>>>>>> on
> >>>>>>> this soon.
> >>>>>>>
> >>>>>>> Martin Grigorov
> >>>>>>> Wicket Training and Consulting
> >>>>>>> https://twitter.com/mtgrigorov
> >>>>>>>
> >>>>>>> On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
> >>>>>>>
> >>>>>>> tobiassoloschenko@googlemail.com> wrote:
> >>>>>>>> Hi everyone,
> >>>>>>>>
> >>>>>>>> I saw that there were several commits to .settings the last time
> >>>>>>>> and
> >>>>>>>> I
> >>>>>>>> wondered why this folder is required in the repository anymore.
> >>>>>>>> Here
> >>>>>>>> is
> >>>>>>>> a
> >>>>>>>> list of the files in a .settings folder (wicket/.settings)
> >>>>>>>
> >>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.c
> >>>>>>> or
> >>>>>>> e.
> >>>>>>> re
> >>>>>>> sources.prefs
> >>>>>>>
> >>>>>>>
> >>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m
> >>>>>>> 2e
> >>>>>>> .c
> >>>>>>> or
> >>>>>>> e.prefs
> >>>>>>>
> >>>>>>>
> >>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.p
> >>>>>>> de
> >>>>>>> .c
> >>>>>>> or
> >>>>>>> e.prefs
> >>>>>>>
> >>>>>>>
> >>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.w
> >>>>>>> st
> >>>>>>> .c
> >>>>>>> om
> >>>>>>> mon.component
> >>>>>>>
> >>>>>>>
> >>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.w
> >>>>>>> st
> >>>>>>> .c
> >>>>>>> om
> >>>>>>> mon.project.facet.core.xml>
> >>>>>>>
> >>>>>>>> I think because maven is used to configure the projects we can
> >>>>>>>> remove
> >>>>>>>
> >>>>>>> those
> >>>>>>>
> >>>>>>>> files from the repository and configure it all in maven.
> >>>>>>>>
> >>>>>>>> Encoding can be configured by (see
> >>>>>>>> http://maven.apache.org/general.html#encoding-warning):
> >>>>>>>>
> >>>>>>>> <properties>
> >>>>>>>>
> >>>>>>>> <project.build.sourceEncoding>UTF-8</project.build.sourceEnc
> >>>>>>>> odi
> >>>>>>>> ng>
> >>>>>>>
> >>>>>>> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEnc
> >>>>>>> od
> >>>>>>> in
> >>>>>>> g>
> >>>>>>>
> >>>>>>>> </properties>
> >>>>>>>>
> >>>>>>>> Java Compile-Level can be configured with the compiler-plugin:
> >>>>>>>> <plugins>
> >>>>>>>>
> >>>>>>>> <plugin>
> >>>>>>>>
> >>>>>>>> <groupId>org.apache.maven.plugins</groupId>
> >>>>>>>> <artifactId>maven-compiler-plugin</artifactId>
> >>>>>>>> <version>3.2</version>
> >>>>>>>> <configuration>
> >>>>>>>>
> >>>>>>>> <source>1.7</source>
> >>>>>>>> <target>1.7</target>
> >>>>>>>>
> >>>>>>>> </configuration>
> >>>>>>>>
> >>>>>>>> </plugin>
> >>>>>>>>
> >>>>>>>> </plugins>
> >>>>>>>>
> >>>>>>>> The project facets are configured by "Maven Integration for Eclipse
> >>>>>>>> WTP"
> >>>>>>>> and it receives the information of the web.xml and the packaging
> >>>>>>>
> >>>>>>> configured
> >>>>>>>
> >>>>>>>> in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
> >>>>>>>> http://marketplace.eclipse.org/node/96737)
> >>>>>>>>
> >>>>>>>> The only entries to be custom configured are in
> >>>>>>>> org.eclipse.core.resources.prefs containing .deprecations and I
> >>>>>>>> wonder
> >>>>>>>> if
> >>>>>>>> they are required anymore.
> >>>>>>>>
> >>>>>>>> The only thing to be done after importing the project into
> >>>>>>>> workspace
> >>>>>>>> is
> >>>>>>>
> >>>>>>> to
> >>>>>>>
> >>>>>>>> configure it as maven project. The .settings folder is created
> >>>>>>>> through
> >>>>>>>
> >>>>>>> the
> >>>>>>>
> >>>>>>>> m2e plugin based on the pom.xml, web.xml.
> >>>>>>>>
> >>>>>>>> Did I overlook something?
> >>>>>>>>
> >>>>>>>> What do you think?
> >>>>>>>>
> >>>>>>>> kind regards
> >>>>>>>>
> >>>>>>>> Tobias
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Tobias Soloschenko <to...@googlemail.com>.
Hi,
I removed the parent of wicket-eclipse-settings, because otherwise the
plugin tries to apply the wicket-eclipse-settings to itself, which is
simply not working. :-)
I added the additionalConfig section and put in the
org.eclipse.jdt.core.prefs and checked the location in the jar which is
"/org.eclipse.jdt.core.prefs"
I installed the eclipse plugin from the markedplace.
The only issue left is that you can't add a dependency only located in
your workspace. If I install wicket-eclipse-settings with "clean
install" and give it a right number like 1.0 and change the dependencies
like the following block - everything is fine (but with SNAPSHOT it is
not working):
<dependencies>
...
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-eclipse-settings</artifactId>
<version>1.0</version>
</dependency>
...
</dependencies>
...
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-eclipse-plugin</artifactId>
<version>2.9</version>
<configuration>
<downloadSources>true</downloadSources>
<additionalConfig>
<file>
<name>.settings/org.eclipse.jdt.core.prefs</name>
<location>/org.eclipse.jdt.core.prefs</location>
</file>
</additionalConfig>
</configuration>
<dependencies>
<dependency>
<groupId>org.apache.wicket</groupId>
<artifactId>wicket-eclipse-settings</artifactId>
<version>1.0</version>
</dependency>
</dependencies>
</plugin>
kind regards
Tobias
Am 05.03.15 um 09:52 schrieb Emond Papegaaij:
> Hi Tobias,
>
> It seems you are missing the additionalConfig section in the maven-eclipse-
> plugin configuration. You need to list .prefs files from which settings need
> to be copied:
> <additionalConfig>
> <file>
> <name>.settings/org.eclipse.core.resources.prefs</name>
> <location>/org.eclipse.core.resources.prefs</location>
> </file>
> ...
> </additionalConfig>
>
> location is the location of the .prefs file in the jar, name is the location
> of the .prefs file relative to the project (so always starts with .settings/).
>
> Note that the m2e-settings plugin only uses the maven-eclipse-plugin
> configuration as a container for its configuration. You should not run mvn
> eclipse:eclipse.
>
> Best regards,
> Emond
>
> On Thursday 05 March 2015 09:19:07 Tobias Soloschenko wrote:
>> Ah, now I see. Thank you for the explanation! :-)
>>
>> @Emond: Would you be so kind and have a look if the way I configured it
>> in the branch https://github.com/klopfdreh/wicket/tree/WICKET-5848 is
>> like intended?
>>
>> @Martin: Is somewhere a still existing preference
>> (org.eclipse.jdt.ui.prefs) which shows how the code style formatting has
>> been applied before it has been removed from version control? I would
>> simply copy the file into the "files" folder of wicket-eclipse-settings
>> and as I understood eclipse then takes the setting for each project
>> which has the wicket/pom.xml with the maven-eclipse-plugin as parent.
>>
>> kind regards
>>
>> Tobias
>>
>> Am 05.03.15 um 08:16 schrieb Emond Papegaaij:
>>> Hi Tobias,
>>>
>>> This is a limitation (and feature) of the plugin. It does not simply copy
>>> files, but transfers settings. You can only use it with actual properties-
>>> files and existing settings. Eclipse does not like it when plugins
>>> overwrite settings files, so the plugin uses the actual eclipse
>>> preference API.
>>>
>>> Best regards,
>>> Emond
>>>
>>> On Wednesday 04 March 2015 23:45:21 Tobias Soloschenko wrote:
>>>> Hi Emond,
>>>>
>>>> I tried to get the plugin working for me but I failed. Maybe I missed
>>>> something.
>>>>
>>>> https://github.com/klopfdreh/wicket/commit/1f3ca3ffe2ba7633339719824fb5e1
>>>> 219 7bcb243#diff-600376dffeb79835ede4a0b285078036R247
>>>>
>>>> Here is the root pom.xml
>>>>
>>>> https://github.com/klopfdreh/wicket/blob/1f3ca3ffe2ba7633339719824fb5e121
>>>> 97b cb243/pom.xml
>>>>
>>>> 1. I added a submodule wicket-eclipse-settings with a folder called
>>>> files and put in an empty file "test"
>>>> 2. I added the module to the list of modules
>>>> <modules><module>wicket-eclipse-settings</module>........</modules>
>>>> 3. Then I added the dependency of wicket-eclipse-settings to the project
>>>> dependencies and the maven-eclipse-plugin dependencies and placed in
>>>> additionalConfig to copy the "test"-file at the right position
>>>>
>>>> What I expected is that the test file is copied to
>>>> <working-dir>/wicket-core/.settings/test when I run a "clean package" at
>>>> wicket-core.
>>>>
>>>> It seems that package doesn't run the maven-eclipse-plugin at all
>>>>
>>>> kind regards
>>>>
>>>> Tobias
>>>>
>>>> P.S.: Sorry for some missing spaces - if it is fixed I will commit the
>>>> pom well formatted - the commits can be squashed then.
>>>>
>>>> Am 04.03.15 um 10:28 schrieb Emond Papegaaij:
>>>>> The maven-eclipse-plugin is not maintained at all. Everyone should use
>>>>> m2e. We have developed an eclipse plugin to apply these settings
>>>>> automatically when using m2e:
>>>>> https://github.com/topicusonderwijs/m2e-settings
>>>>>
>>>>> I think we should create a wicket-eclipse-settings maven artifact and
>>>>> use
>>>>> that.
>>>>>
>>>>> Best regards,
>>>>> Emond
>>>>>
>>>>> On Wednesday 04 March 2015 10:09:31 Tobias Soloschenko wrote:
>>>>>> Hi Martin,
>>>>>>
>>>>>> maybe we can use the maven-eclipse-plugin to apply formatting rules:
>>>>>>
>>>>>> http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-code
>>>>>> -s
>>>>>> tyl es.html
>>>>>>
>>>>>> The plugin itself is not well maintained, but we only need to apply the
>>>>>> formatting rules to the IDE - I think on IDEA it is ignored, but we
>>>>>> have
>>>>>> to
>>>>>> check it.
>>>>>>
>>>>>> Does this address your feature?
>>>>>>
>>>>>> kind regards
>>>>>>
>>>>>> Tobias
>>>>>>
>>>>>> 2015-03-04 9:30 GMT+01:00 Martin Grigorov <mg...@apache.org>:
>>>>>>> Hi Tobias,
>>>>>>>
>>>>>>> I personally use Intellij IDEA and these files are in not in use by
>>>>>>> me.
>>>>>>> But AFAIR the most useful feature in them is the code formatting
>>>>>>> rules.
>>>>>>> We
>>>>>>> try to keep Wicket code formatted the same style. IMO this helps a lot
>>>>>>> in
>>>>>>> maintenance. I personally get distracted when debugging something and
>>>>>>> see
>>>>>>> code snippet that is wrongly formatted, or doesn't use braces, or
>>>>>>> something
>>>>>>> similar.
>>>>>>>
>>>>>>> I think I am the only user of IDEA in the team (except Peter Ertl, but
>>>>>>> he
>>>>>>> is not very active lately) so I'm sure others will give their feedback
>>>>>>> on
>>>>>>> this soon.
>>>>>>>
>>>>>>> Martin Grigorov
>>>>>>> Wicket Training and Consulting
>>>>>>> https://twitter.com/mtgrigorov
>>>>>>>
>>>>>>> On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
>>>>>>>
>>>>>>> tobiassoloschenko@googlemail.com> wrote:
>>>>>>>> Hi everyone,
>>>>>>>>
>>>>>>>> I saw that there were several commits to .settings the last time and
>>>>>>>> I
>>>>>>>> wondered why this folder is required in the repository anymore. Here
>>>>>>>> is
>>>>>>>> a
>>>>>>>> list of the files in a .settings folder (wicket/.settings)
>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.cor
>>>>>>> e.
>>>>>>> re
>>>>>>> sources.prefs
>>>>>>>
>>>>>>>
>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m2e
>>>>>>> .c
>>>>>>> or
>>>>>>> e.prefs
>>>>>>>
>>>>>>>
>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.pde
>>>>>>> .c
>>>>>>> or
>>>>>>> e.prefs
>>>>>>>
>>>>>>>
>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst
>>>>>>> .c
>>>>>>> om
>>>>>>> mon.component
>>>>>>>
>>>>>>>
>>>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst
>>>>>>> .c
>>>>>>> om
>>>>>>> mon.project.facet.core.xml>
>>>>>>>
>>>>>>>> I think because maven is used to configure the projects we can remove
>>>>>>> those
>>>>>>>
>>>>>>>> files from the repository and configure it all in maven.
>>>>>>>>
>>>>>>>> Encoding can be configured by (see
>>>>>>>> http://maven.apache.org/general.html#encoding-warning):
>>>>>>>>
>>>>>>>> <properties>
>>>>>>>>
>>>>>>>> <project.build.sourceEncoding>UTF-8</project.build.sourceEncodi
>>>>>>>> ng>
>>>>>>> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncod
>>>>>>> in
>>>>>>> g>
>>>>>>>
>>>>>>>> </properties>
>>>>>>>>
>>>>>>>> Java Compile-Level can be configured with the compiler-plugin:
>>>>>>>> <plugins>
>>>>>>>>
>>>>>>>> <plugin>
>>>>>>>>
>>>>>>>> <groupId>org.apache.maven.plugins</groupId>
>>>>>>>> <artifactId>maven-compiler-plugin</artifactId>
>>>>>>>> <version>3.2</version>
>>>>>>>> <configuration>
>>>>>>>>
>>>>>>>> <source>1.7</source>
>>>>>>>> <target>1.7</target>
>>>>>>>>
>>>>>>>> </configuration>
>>>>>>>>
>>>>>>>> </plugin>
>>>>>>>>
>>>>>>>> </plugins>
>>>>>>>>
>>>>>>>> The project facets are configured by "Maven Integration for Eclipse
>>>>>>>> WTP"
>>>>>>>> and it receives the information of the web.xml and the packaging
>>>>>>> configured
>>>>>>>
>>>>>>>> in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
>>>>>>>> http://marketplace.eclipse.org/node/96737)
>>>>>>>>
>>>>>>>> The only entries to be custom configured are in
>>>>>>>> org.eclipse.core.resources.prefs containing .deprecations and I
>>>>>>>> wonder
>>>>>>>> if
>>>>>>>> they are required anymore.
>>>>>>>>
>>>>>>>> The only thing to be done after importing the project into workspace
>>>>>>>> is
>>>>>>> to
>>>>>>>
>>>>>>>> configure it as maven project. The .settings folder is created
>>>>>>>> through
>>>>>>> the
>>>>>>>
>>>>>>>> m2e plugin based on the pom.xml, web.xml.
>>>>>>>>
>>>>>>>> Did I overlook something?
>>>>>>>>
>>>>>>>> What do you think?
>>>>>>>>
>>>>>>>> kind regards
>>>>>>>>
>>>>>>>> Tobias
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Emond Papegaaij <em...@topicus.nl>.
Hi Tobias,
It seems you are missing the additionalConfig section in the maven-eclipse-
plugin configuration. You need to list .prefs files from which settings need
to be copied:
<additionalConfig>
<file>
<name>.settings/org.eclipse.core.resources.prefs</name>
<location>/org.eclipse.core.resources.prefs</location>
</file>
...
</additionalConfig>
location is the location of the .prefs file in the jar, name is the location
of the .prefs file relative to the project (so always starts with .settings/).
Note that the m2e-settings plugin only uses the maven-eclipse-plugin
configuration as a container for its configuration. You should not run mvn
eclipse:eclipse.
Best regards,
Emond
On Thursday 05 March 2015 09:19:07 Tobias Soloschenko wrote:
> Ah, now I see. Thank you for the explanation! :-)
>
> @Emond: Would you be so kind and have a look if the way I configured it
> in the branch https://github.com/klopfdreh/wicket/tree/WICKET-5848 is
> like intended?
>
> @Martin: Is somewhere a still existing preference
> (org.eclipse.jdt.ui.prefs) which shows how the code style formatting has
> been applied before it has been removed from version control? I would
> simply copy the file into the "files" folder of wicket-eclipse-settings
> and as I understood eclipse then takes the setting for each project
> which has the wicket/pom.xml with the maven-eclipse-plugin as parent.
>
> kind regards
>
> Tobias
>
> Am 05.03.15 um 08:16 schrieb Emond Papegaaij:
> > Hi Tobias,
> >
> > This is a limitation (and feature) of the plugin. It does not simply copy
> > files, but transfers settings. You can only use it with actual properties-
> > files and existing settings. Eclipse does not like it when plugins
> > overwrite settings files, so the plugin uses the actual eclipse
> > preference API.
> >
> > Best regards,
> > Emond
> >
> > On Wednesday 04 March 2015 23:45:21 Tobias Soloschenko wrote:
> >> Hi Emond,
> >>
> >> I tried to get the plugin working for me but I failed. Maybe I missed
> >> something.
> >>
> >> https://github.com/klopfdreh/wicket/commit/1f3ca3ffe2ba7633339719824fb5e1
> >> 219 7bcb243#diff-600376dffeb79835ede4a0b285078036R247
> >>
> >> Here is the root pom.xml
> >>
> >> https://github.com/klopfdreh/wicket/blob/1f3ca3ffe2ba7633339719824fb5e121
> >> 97b cb243/pom.xml
> >>
> >> 1. I added a submodule wicket-eclipse-settings with a folder called
> >> files and put in an empty file "test"
> >> 2. I added the module to the list of modules
> >> <modules><module>wicket-eclipse-settings</module>........</modules>
> >> 3. Then I added the dependency of wicket-eclipse-settings to the project
> >> dependencies and the maven-eclipse-plugin dependencies and placed in
> >> additionalConfig to copy the "test"-file at the right position
> >>
> >> What I expected is that the test file is copied to
> >> <working-dir>/wicket-core/.settings/test when I run a "clean package" at
> >> wicket-core.
> >>
> >> It seems that package doesn't run the maven-eclipse-plugin at all
> >>
> >> kind regards
> >>
> >> Tobias
> >>
> >> P.S.: Sorry for some missing spaces - if it is fixed I will commit the
> >> pom well formatted - the commits can be squashed then.
> >>
> >> Am 04.03.15 um 10:28 schrieb Emond Papegaaij:
> >>> The maven-eclipse-plugin is not maintained at all. Everyone should use
> >>> m2e. We have developed an eclipse plugin to apply these settings
> >>> automatically when using m2e:
> >>> https://github.com/topicusonderwijs/m2e-settings
> >>>
> >>> I think we should create a wicket-eclipse-settings maven artifact and
> >>> use
> >>> that.
> >>>
> >>> Best regards,
> >>> Emond
> >>>
> >>> On Wednesday 04 March 2015 10:09:31 Tobias Soloschenko wrote:
> >>>> Hi Martin,
> >>>>
> >>>> maybe we can use the maven-eclipse-plugin to apply formatting rules:
> >>>>
> >>>> http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-code
> >>>> -s
> >>>> tyl es.html
> >>>>
> >>>> The plugin itself is not well maintained, but we only need to apply the
> >>>> formatting rules to the IDE - I think on IDEA it is ignored, but we
> >>>> have
> >>>> to
> >>>> check it.
> >>>>
> >>>> Does this address your feature?
> >>>>
> >>>> kind regards
> >>>>
> >>>> Tobias
> >>>>
> >>>> 2015-03-04 9:30 GMT+01:00 Martin Grigorov <mg...@apache.org>:
> >>>>> Hi Tobias,
> >>>>>
> >>>>> I personally use Intellij IDEA and these files are in not in use by
> >>>>> me.
> >>>>> But AFAIR the most useful feature in them is the code formatting
> >>>>> rules.
> >>>>> We
> >>>>> try to keep Wicket code formatted the same style. IMO this helps a lot
> >>>>> in
> >>>>> maintenance. I personally get distracted when debugging something and
> >>>>> see
> >>>>> code snippet that is wrongly formatted, or doesn't use braces, or
> >>>>> something
> >>>>> similar.
> >>>>>
> >>>>> I think I am the only user of IDEA in the team (except Peter Ertl, but
> >>>>> he
> >>>>> is not very active lately) so I'm sure others will give their feedback
> >>>>> on
> >>>>> this soon.
> >>>>>
> >>>>> Martin Grigorov
> >>>>> Wicket Training and Consulting
> >>>>> https://twitter.com/mtgrigorov
> >>>>>
> >>>>> On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
> >>>>>
> >>>>> tobiassoloschenko@googlemail.com> wrote:
> >>>>>> Hi everyone,
> >>>>>>
> >>>>>> I saw that there were several commits to .settings the last time and
> >>>>>> I
> >>>>>> wondered why this folder is required in the repository anymore. Here
> >>>>>> is
> >>>>>> a
> >>>>>> list of the files in a .settings folder (wicket/.settings)
> >>>>>
> >>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.cor
> >>>>> e.
> >>>>> re
> >>>>> sources.prefs
> >>>>>
> >>>>>
> >>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m2e
> >>>>> .c
> >>>>> or
> >>>>> e.prefs
> >>>>>
> >>>>>
> >>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.pde
> >>>>> .c
> >>>>> or
> >>>>> e.prefs
> >>>>>
> >>>>>
> >>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst
> >>>>> .c
> >>>>> om
> >>>>> mon.component
> >>>>>
> >>>>>
> >>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst
> >>>>> .c
> >>>>> om
> >>>>> mon.project.facet.core.xml>
> >>>>>
> >>>>>> I think because maven is used to configure the projects we can remove
> >>>>>
> >>>>> those
> >>>>>
> >>>>>> files from the repository and configure it all in maven.
> >>>>>>
> >>>>>> Encoding can be configured by (see
> >>>>>> http://maven.apache.org/general.html#encoding-warning):
> >>>>>>
> >>>>>> <properties>
> >>>>>>
> >>>>>> <project.build.sourceEncoding>UTF-8</project.build.sourceEncodi
> >>>>>> ng>
> >>>>>
> >>>>> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncod
> >>>>> in
> >>>>> g>
> >>>>>
> >>>>>> </properties>
> >>>>>>
> >>>>>> Java Compile-Level can be configured with the compiler-plugin:
> >>>>>> <plugins>
> >>>>>>
> >>>>>> <plugin>
> >>>>>>
> >>>>>> <groupId>org.apache.maven.plugins</groupId>
> >>>>>> <artifactId>maven-compiler-plugin</artifactId>
> >>>>>> <version>3.2</version>
> >>>>>> <configuration>
> >>>>>>
> >>>>>> <source>1.7</source>
> >>>>>> <target>1.7</target>
> >>>>>>
> >>>>>> </configuration>
> >>>>>>
> >>>>>> </plugin>
> >>>>>>
> >>>>>> </plugins>
> >>>>>>
> >>>>>> The project facets are configured by "Maven Integration for Eclipse
> >>>>>> WTP"
> >>>>>> and it receives the information of the web.xml and the packaging
> >>>>>
> >>>>> configured
> >>>>>
> >>>>>> in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
> >>>>>> http://marketplace.eclipse.org/node/96737)
> >>>>>>
> >>>>>> The only entries to be custom configured are in
> >>>>>> org.eclipse.core.resources.prefs containing .deprecations and I
> >>>>>> wonder
> >>>>>> if
> >>>>>> they are required anymore.
> >>>>>>
> >>>>>> The only thing to be done after importing the project into workspace
> >>>>>> is
> >>>>>
> >>>>> to
> >>>>>
> >>>>>> configure it as maven project. The .settings folder is created
> >>>>>> through
> >>>>>
> >>>>> the
> >>>>>
> >>>>>> m2e plugin based on the pom.xml, web.xml.
> >>>>>>
> >>>>>> Did I overlook something?
> >>>>>>
> >>>>>> What do you think?
> >>>>>>
> >>>>>> kind regards
> >>>>>>
> >>>>>> Tobias
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Martin Grigorov <mg...@apache.org>.
https://github.com/apache/wicket/commit/9852fc794d7e961ce408ee46641ded2699d22dbe
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Thu, Mar 5, 2015 at 10:19 AM, Tobias Soloschenko <
tobiassoloschenko@googlemail.com> wrote:
> Ah, now I see. Thank you for the explanation! :-)
>
> @Emond: Would you be so kind and have a look if the way I configured it in
> the branch https://github.com/klopfdreh/wicket/tree/WICKET-5848 is like
> intended?
>
> @Martin: Is somewhere a still existing preference
> (org.eclipse.jdt.ui.prefs) which shows how the code style formatting has
> been applied before it has been removed from version control? I would
> simply copy the file into the "files" folder of wicket-eclipse-settings and
> as I understood eclipse then takes the setting for each project which has
> the wicket/pom.xml with the maven-eclipse-plugin as parent.
>
> kind regards
>
> Tobias
>
> Am 05.03.15 um 08:16 schrieb Emond Papegaaij:
>
> Hi Tobias,
>>
>> This is a limitation (and feature) of the plugin. It does not simply copy
>> files, but transfers settings. You can only use it with actual properties-
>> files and existing settings. Eclipse does not like it when plugins
>> overwrite
>> settings files, so the plugin uses the actual eclipse preference API.
>>
>> Best regards,
>> Emond
>>
>> On Wednesday 04 March 2015 23:45:21 Tobias Soloschenko wrote:
>>
>>> Hi Emond,
>>>
>>> I tried to get the plugin working for me but I failed. Maybe I missed
>>> something.
>>>
>>> https://github.com/klopfdreh/wicket/commit/
>>> 1f3ca3ffe2ba7633339719824fb5e1219
>>> 7bcb243#diff-600376dffeb79835ede4a0b285078036R247
>>>
>>> Here is the root pom.xml
>>>
>>> https://github.com/klopfdreh/wicket/blob/1f3ca3ffe2ba7633339719824fb5e1
>>> 2197b
>>> cb243/pom.xml
>>>
>>> 1. I added a submodule wicket-eclipse-settings with a folder called
>>> files and put in an empty file "test"
>>> 2. I added the module to the list of modules
>>> <modules><module>wicket-eclipse-settings</module>........</modules>
>>> 3. Then I added the dependency of wicket-eclipse-settings to the project
>>> dependencies and the maven-eclipse-plugin dependencies and placed in
>>> additionalConfig to copy the "test"-file at the right position
>>>
>>> What I expected is that the test file is copied to
>>> <working-dir>/wicket-core/.settings/test when I run a "clean package" at
>>> wicket-core.
>>>
>>> It seems that package doesn't run the maven-eclipse-plugin at all
>>>
>>> kind regards
>>>
>>> Tobias
>>>
>>> P.S.: Sorry for some missing spaces - if it is fixed I will commit the
>>> pom well formatted - the commits can be squashed then.
>>>
>>> Am 04.03.15 um 10:28 schrieb Emond Papegaaij:
>>>
>>>> The maven-eclipse-plugin is not maintained at all. Everyone should use
>>>> m2e. We have developed an eclipse plugin to apply these settings
>>>> automatically when using m2e:
>>>> https://github.com/topicusonderwijs/m2e-settings
>>>>
>>>> I think we should create a wicket-eclipse-settings maven artifact and
>>>> use
>>>> that.
>>>>
>>>> Best regards,
>>>> Emond
>>>>
>>>> On Wednesday 04 March 2015 10:09:31 Tobias Soloschenko wrote:
>>>>
>>>>> Hi Martin,
>>>>>
>>>>> maybe we can use the maven-eclipse-plugin to apply formatting rules:
>>>>>
>>>>> http://maven.apache.org/plugins/maven-eclipse-plugin/
>>>>> examples/load-code-s
>>>>> tyl es.html
>>>>>
>>>>> The plugin itself is not well maintained, but we only need to apply the
>>>>> formatting rules to the IDE - I think on IDEA it is ignored, but we
>>>>> have
>>>>> to
>>>>> check it.
>>>>>
>>>>> Does this address your feature?
>>>>>
>>>>> kind regards
>>>>>
>>>>> Tobias
>>>>>
>>>>> 2015-03-04 9:30 GMT+01:00 Martin Grigorov <mg...@apache.org>:
>>>>>
>>>>>> Hi Tobias,
>>>>>>
>>>>>> I personally use Intellij IDEA and these files are in not in use by
>>>>>> me.
>>>>>> But AFAIR the most useful feature in them is the code formatting
>>>>>> rules.
>>>>>> We
>>>>>> try to keep Wicket code formatted the same style. IMO this helps a lot
>>>>>> in
>>>>>> maintenance. I personally get distracted when debugging something and
>>>>>> see
>>>>>> code snippet that is wrongly formatted, or doesn't use braces, or
>>>>>> something
>>>>>> similar.
>>>>>>
>>>>>> I think I am the only user of IDEA in the team (except Peter Ertl, but
>>>>>> he
>>>>>> is not very active lately) so I'm sure others will give their feedback
>>>>>> on
>>>>>> this soon.
>>>>>>
>>>>>> Martin Grigorov
>>>>>> Wicket Training and Consulting
>>>>>> https://twitter.com/mtgrigorov
>>>>>>
>>>>>> On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
>>>>>>
>>>>>> tobiassoloschenko@googlemail.com> wrote:
>>>>>>
>>>>>>> Hi everyone,
>>>>>>>
>>>>>>> I saw that there were several commits to .settings the last time and
>>>>>>> I
>>>>>>> wondered why this folder is required in the repository anymore. Here
>>>>>>> is
>>>>>>> a
>>>>>>> list of the files in a .settings folder (wicket/.settings)
>>>>>>>
>>>>>> https://github.com/apache/wicket/blob/master/.settings/
>>>>>> org.eclipse.core.
>>>>>> re
>>>>>> sources.prefs
>>>>>>
>>>>>>
>>>>>> https://github.com/apache/wicket/blob/master/.settings/
>>>>>> org.eclipse.m2e.c
>>>>>> or
>>>>>> e.prefs
>>>>>>
>>>>>>
>>>>>> https://github.com/apache/wicket/blob/master/.settings/
>>>>>> org.eclipse.pde.c
>>>>>> or
>>>>>> e.prefs
>>>>>>
>>>>>>
>>>>>> https://github.com/apache/wicket/blob/master/.settings/
>>>>>> org.eclipse.wst.c
>>>>>> om
>>>>>> mon.component
>>>>>>
>>>>>>
>>>>>> https://github.com/apache/wicket/blob/master/.settings/
>>>>>> org.eclipse.wst.c
>>>>>> om
>>>>>> mon.project.facet.core.xml>
>>>>>>
>>>>>> I think because maven is used to configure the projects we can remove
>>>>>>>
>>>>>> those
>>>>>>
>>>>>> files from the repository and configure it all in maven.
>>>>>>>
>>>>>>> Encoding can be configured by (see
>>>>>>> http://maven.apache.org/general.html#encoding-warning):
>>>>>>>
>>>>>>> <properties>
>>>>>>>
>>>>>>> <project.build.sourceEncoding>UTF-8</project.build.
>>>>>>> sourceEncoding>
>>>>>>>
>>>>>> <project.reporting.outputEncoding>UTF-8</project.
>>>>>> reporting.outputEncodin
>>>>>> g>
>>>>>>
>>>>>> </properties>
>>>>>>>
>>>>>>> Java Compile-Level can be configured with the compiler-plugin:
>>>>>>> <plugins>
>>>>>>> <plugin>
>>>>>>> <groupId>org.apache.maven.plugins</groupId>
>>>>>>> <artifactId>maven-compiler-plugin</artifactId>
>>>>>>> <version>3.2</version>
>>>>>>> <configuration>
>>>>>>> <source>1.7</source>
>>>>>>> <target>1.7</target>
>>>>>>> </configuration>
>>>>>>> </plugin>
>>>>>>> </plugins>
>>>>>>>
>>>>>>> The project facets are configured by "Maven Integration for Eclipse
>>>>>>> WTP"
>>>>>>> and it receives the information of the web.xml and the packaging
>>>>>>>
>>>>>> configured
>>>>>>
>>>>>> in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
>>>>>>> http://marketplace.eclipse.org/node/96737)
>>>>>>>
>>>>>>> The only entries to be custom configured are in
>>>>>>> org.eclipse.core.resources.prefs containing .deprecations and I
>>>>>>> wonder
>>>>>>> if
>>>>>>> they are required anymore.
>>>>>>>
>>>>>>> The only thing to be done after importing the project into workspace
>>>>>>> is
>>>>>>>
>>>>>> to
>>>>>>
>>>>>> configure it as maven project. The .settings folder is created
>>>>>>> through
>>>>>>>
>>>>>> the
>>>>>>
>>>>>> m2e plugin based on the pom.xml, web.xml.
>>>>>>>
>>>>>>> Did I overlook something?
>>>>>>>
>>>>>>> What do you think?
>>>>>>>
>>>>>>> kind regards
>>>>>>>
>>>>>>> Tobias
>>>>>>>
>>>>>>
>
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Tobias Soloschenko <to...@googlemail.com>.
Ah, now I see. Thank you for the explanation! :-)
@Emond: Would you be so kind and have a look if the way I configured it
in the branch https://github.com/klopfdreh/wicket/tree/WICKET-5848 is
like intended?
@Martin: Is somewhere a still existing preference
(org.eclipse.jdt.ui.prefs) which shows how the code style formatting has
been applied before it has been removed from version control? I would
simply copy the file into the "files" folder of wicket-eclipse-settings
and as I understood eclipse then takes the setting for each project
which has the wicket/pom.xml with the maven-eclipse-plugin as parent.
kind regards
Tobias
Am 05.03.15 um 08:16 schrieb Emond Papegaaij:
> Hi Tobias,
>
> This is a limitation (and feature) of the plugin. It does not simply copy
> files, but transfers settings. You can only use it with actual properties-
> files and existing settings. Eclipse does not like it when plugins overwrite
> settings files, so the plugin uses the actual eclipse preference API.
>
> Best regards,
> Emond
>
> On Wednesday 04 March 2015 23:45:21 Tobias Soloschenko wrote:
>> Hi Emond,
>>
>> I tried to get the plugin working for me but I failed. Maybe I missed
>> something.
>>
>> https://github.com/klopfdreh/wicket/commit/1f3ca3ffe2ba7633339719824fb5e1219
>> 7bcb243#diff-600376dffeb79835ede4a0b285078036R247
>>
>> Here is the root pom.xml
>>
>> https://github.com/klopfdreh/wicket/blob/1f3ca3ffe2ba7633339719824fb5e12197b
>> cb243/pom.xml
>>
>> 1. I added a submodule wicket-eclipse-settings with a folder called
>> files and put in an empty file "test"
>> 2. I added the module to the list of modules
>> <modules><module>wicket-eclipse-settings</module>........</modules>
>> 3. Then I added the dependency of wicket-eclipse-settings to the project
>> dependencies and the maven-eclipse-plugin dependencies and placed in
>> additionalConfig to copy the "test"-file at the right position
>>
>> What I expected is that the test file is copied to
>> <working-dir>/wicket-core/.settings/test when I run a "clean package" at
>> wicket-core.
>>
>> It seems that package doesn't run the maven-eclipse-plugin at all
>>
>> kind regards
>>
>> Tobias
>>
>> P.S.: Sorry for some missing spaces - if it is fixed I will commit the
>> pom well formatted - the commits can be squashed then.
>>
>> Am 04.03.15 um 10:28 schrieb Emond Papegaaij:
>>> The maven-eclipse-plugin is not maintained at all. Everyone should use
>>> m2e. We have developed an eclipse plugin to apply these settings
>>> automatically when using m2e:
>>> https://github.com/topicusonderwijs/m2e-settings
>>>
>>> I think we should create a wicket-eclipse-settings maven artifact and use
>>> that.
>>>
>>> Best regards,
>>> Emond
>>>
>>> On Wednesday 04 March 2015 10:09:31 Tobias Soloschenko wrote:
>>>> Hi Martin,
>>>>
>>>> maybe we can use the maven-eclipse-plugin to apply formatting rules:
>>>>
>>>> http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-code-s
>>>> tyl es.html
>>>>
>>>> The plugin itself is not well maintained, but we only need to apply the
>>>> formatting rules to the IDE - I think on IDEA it is ignored, but we have
>>>> to
>>>> check it.
>>>>
>>>> Does this address your feature?
>>>>
>>>> kind regards
>>>>
>>>> Tobias
>>>>
>>>> 2015-03-04 9:30 GMT+01:00 Martin Grigorov <mg...@apache.org>:
>>>>> Hi Tobias,
>>>>>
>>>>> I personally use Intellij IDEA and these files are in not in use by me.
>>>>> But AFAIR the most useful feature in them is the code formatting rules.
>>>>> We
>>>>> try to keep Wicket code formatted the same style. IMO this helps a lot
>>>>> in
>>>>> maintenance. I personally get distracted when debugging something and
>>>>> see
>>>>> code snippet that is wrongly formatted, or doesn't use braces, or
>>>>> something
>>>>> similar.
>>>>>
>>>>> I think I am the only user of IDEA in the team (except Peter Ertl, but
>>>>> he
>>>>> is not very active lately) so I'm sure others will give their feedback
>>>>> on
>>>>> this soon.
>>>>>
>>>>> Martin Grigorov
>>>>> Wicket Training and Consulting
>>>>> https://twitter.com/mtgrigorov
>>>>>
>>>>> On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
>>>>>
>>>>> tobiassoloschenko@googlemail.com> wrote:
>>>>>> Hi everyone,
>>>>>>
>>>>>> I saw that there were several commits to .settings the last time and I
>>>>>> wondered why this folder is required in the repository anymore. Here is
>>>>>> a
>>>>>> list of the files in a .settings folder (wicket/.settings)
>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.core.
>>>>> re
>>>>> sources.prefs
>>>>>
>>>>>
>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m2e.c
>>>>> or
>>>>> e.prefs
>>>>>
>>>>>
>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.pde.c
>>>>> or
>>>>> e.prefs
>>>>>
>>>>>
>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.c
>>>>> om
>>>>> mon.component
>>>>>
>>>>>
>>>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.c
>>>>> om
>>>>> mon.project.facet.core.xml>
>>>>>
>>>>>> I think because maven is used to configure the projects we can remove
>>>>> those
>>>>>
>>>>>> files from the repository and configure it all in maven.
>>>>>>
>>>>>> Encoding can be configured by (see
>>>>>> http://maven.apache.org/general.html#encoding-warning):
>>>>>>
>>>>>> <properties>
>>>>>>
>>>>>> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
>>>>> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncodin
>>>>> g>
>>>>>
>>>>>> </properties>
>>>>>>
>>>>>> Java Compile-Level can be configured with the compiler-plugin:
>>>>>> <plugins>
>>>>>>
>>>>>> <plugin>
>>>>>>
>>>>>> <groupId>org.apache.maven.plugins</groupId>
>>>>>> <artifactId>maven-compiler-plugin</artifactId>
>>>>>> <version>3.2</version>
>>>>>> <configuration>
>>>>>>
>>>>>> <source>1.7</source>
>>>>>> <target>1.7</target>
>>>>>>
>>>>>> </configuration>
>>>>>>
>>>>>> </plugin>
>>>>>>
>>>>>> </plugins>
>>>>>>
>>>>>> The project facets are configured by "Maven Integration for Eclipse
>>>>>> WTP"
>>>>>> and it receives the information of the web.xml and the packaging
>>>>> configured
>>>>>
>>>>>> in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
>>>>>> http://marketplace.eclipse.org/node/96737)
>>>>>>
>>>>>> The only entries to be custom configured are in
>>>>>> org.eclipse.core.resources.prefs containing .deprecations and I wonder
>>>>>> if
>>>>>> they are required anymore.
>>>>>>
>>>>>> The only thing to be done after importing the project into workspace is
>>>>> to
>>>>>
>>>>>> configure it as maven project. The .settings folder is created through
>>>>> the
>>>>>
>>>>>> m2e plugin based on the pom.xml, web.xml.
>>>>>>
>>>>>> Did I overlook something?
>>>>>>
>>>>>> What do you think?
>>>>>>
>>>>>> kind regards
>>>>>>
>>>>>> Tobias
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Emond Papegaaij <em...@topicus.nl>.
Hi Tobias,
This is a limitation (and feature) of the plugin. It does not simply copy
files, but transfers settings. You can only use it with actual properties-
files and existing settings. Eclipse does not like it when plugins overwrite
settings files, so the plugin uses the actual eclipse preference API.
Best regards,
Emond
On Wednesday 04 March 2015 23:45:21 Tobias Soloschenko wrote:
> Hi Emond,
>
> I tried to get the plugin working for me but I failed. Maybe I missed
> something.
>
> https://github.com/klopfdreh/wicket/commit/1f3ca3ffe2ba7633339719824fb5e1219
> 7bcb243#diff-600376dffeb79835ede4a0b285078036R247
>
> Here is the root pom.xml
>
> https://github.com/klopfdreh/wicket/blob/1f3ca3ffe2ba7633339719824fb5e12197b
> cb243/pom.xml
>
> 1. I added a submodule wicket-eclipse-settings with a folder called
> files and put in an empty file "test"
> 2. I added the module to the list of modules
> <modules><module>wicket-eclipse-settings</module>........</modules>
> 3. Then I added the dependency of wicket-eclipse-settings to the project
> dependencies and the maven-eclipse-plugin dependencies and placed in
> additionalConfig to copy the "test"-file at the right position
>
> What I expected is that the test file is copied to
> <working-dir>/wicket-core/.settings/test when I run a "clean package" at
> wicket-core.
>
> It seems that package doesn't run the maven-eclipse-plugin at all
>
> kind regards
>
> Tobias
>
> P.S.: Sorry for some missing spaces - if it is fixed I will commit the
> pom well formatted - the commits can be squashed then.
>
> Am 04.03.15 um 10:28 schrieb Emond Papegaaij:
> > The maven-eclipse-plugin is not maintained at all. Everyone should use
> > m2e. We have developed an eclipse plugin to apply these settings
> > automatically when using m2e:
> > https://github.com/topicusonderwijs/m2e-settings
> >
> > I think we should create a wicket-eclipse-settings maven artifact and use
> > that.
> >
> > Best regards,
> > Emond
> >
> > On Wednesday 04 March 2015 10:09:31 Tobias Soloschenko wrote:
> >> Hi Martin,
> >>
> >> maybe we can use the maven-eclipse-plugin to apply formatting rules:
> >>
> >> http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-code-s
> >> tyl es.html
> >>
> >> The plugin itself is not well maintained, but we only need to apply the
> >> formatting rules to the IDE - I think on IDEA it is ignored, but we have
> >> to
> >> check it.
> >>
> >> Does this address your feature?
> >>
> >> kind regards
> >>
> >> Tobias
> >>
> >> 2015-03-04 9:30 GMT+01:00 Martin Grigorov <mg...@apache.org>:
> >>> Hi Tobias,
> >>>
> >>> I personally use Intellij IDEA and these files are in not in use by me.
> >>> But AFAIR the most useful feature in them is the code formatting rules.
> >>> We
> >>> try to keep Wicket code formatted the same style. IMO this helps a lot
> >>> in
> >>> maintenance. I personally get distracted when debugging something and
> >>> see
> >>> code snippet that is wrongly formatted, or doesn't use braces, or
> >>> something
> >>> similar.
> >>>
> >>> I think I am the only user of IDEA in the team (except Peter Ertl, but
> >>> he
> >>> is not very active lately) so I'm sure others will give their feedback
> >>> on
> >>> this soon.
> >>>
> >>> Martin Grigorov
> >>> Wicket Training and Consulting
> >>> https://twitter.com/mtgrigorov
> >>>
> >>> On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
> >>>
> >>> tobiassoloschenko@googlemail.com> wrote:
> >>>> Hi everyone,
> >>>>
> >>>> I saw that there were several commits to .settings the last time and I
> >>>> wondered why this folder is required in the repository anymore. Here is
> >>>> a
> >>>> list of the files in a .settings folder (wicket/.settings)
> >>>
> >>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.core.
> >>> re
> >>> sources.prefs
> >>>
> >>>
> >>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m2e.c
> >>> or
> >>> e.prefs
> >>>
> >>>
> >>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.pde.c
> >>> or
> >>> e.prefs
> >>>
> >>>
> >>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.c
> >>> om
> >>> mon.component
> >>>
> >>>
> >>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.c
> >>> om
> >>> mon.project.facet.core.xml>
> >>>
> >>>> I think because maven is used to configure the projects we can remove
> >>>
> >>> those
> >>>
> >>>> files from the repository and configure it all in maven.
> >>>>
> >>>> Encoding can be configured by (see
> >>>> http://maven.apache.org/general.html#encoding-warning):
> >>>>
> >>>> <properties>
> >>>>
> >>>> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
> >>>
> >>> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncodin
> >>> g>
> >>>
> >>>> </properties>
> >>>>
> >>>> Java Compile-Level can be configured with the compiler-plugin:
> >>>> <plugins>
> >>>>
> >>>> <plugin>
> >>>>
> >>>> <groupId>org.apache.maven.plugins</groupId>
> >>>> <artifactId>maven-compiler-plugin</artifactId>
> >>>> <version>3.2</version>
> >>>> <configuration>
> >>>>
> >>>> <source>1.7</source>
> >>>> <target>1.7</target>
> >>>>
> >>>> </configuration>
> >>>>
> >>>> </plugin>
> >>>>
> >>>> </plugins>
> >>>>
> >>>> The project facets are configured by "Maven Integration for Eclipse
> >>>> WTP"
> >>>> and it receives the information of the web.xml and the packaging
> >>>
> >>> configured
> >>>
> >>>> in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
> >>>> http://marketplace.eclipse.org/node/96737)
> >>>>
> >>>> The only entries to be custom configured are in
> >>>> org.eclipse.core.resources.prefs containing .deprecations and I wonder
> >>>> if
> >>>> they are required anymore.
> >>>>
> >>>> The only thing to be done after importing the project into workspace is
> >>>
> >>> to
> >>>
> >>>> configure it as maven project. The .settings folder is created through
> >>>
> >>> the
> >>>
> >>>> m2e plugin based on the pom.xml, web.xml.
> >>>>
> >>>> Did I overlook something?
> >>>>
> >>>> What do you think?
> >>>>
> >>>> kind regards
> >>>>
> >>>> Tobias
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Tobias Soloschenko <to...@googlemail.com>.
Hi Emond,
I tried to get the plugin working for me but I failed. Maybe I missed
something.
https://github.com/klopfdreh/wicket/commit/1f3ca3ffe2ba7633339719824fb5e12197bcb243#diff-600376dffeb79835ede4a0b285078036R247
Here is the root pom.xml
https://github.com/klopfdreh/wicket/blob/1f3ca3ffe2ba7633339719824fb5e12197bcb243/pom.xml
1. I added a submodule wicket-eclipse-settings with a folder called
files and put in an empty file "test"
2. I added the module to the list of modules
<modules><module>wicket-eclipse-settings</module>........</modules>
3. Then I added the dependency of wicket-eclipse-settings to the project
dependencies and the maven-eclipse-plugin dependencies and placed in
additionalConfig to copy the "test"-file at the right position
What I expected is that the test file is copied to
<working-dir>/wicket-core/.settings/test when I run a "clean package" at
wicket-core.
It seems that package doesn't run the maven-eclipse-plugin at all
kind regards
Tobias
P.S.: Sorry for some missing spaces - if it is fixed I will commit the
pom well formatted - the commits can be squashed then.
Am 04.03.15 um 10:28 schrieb Emond Papegaaij:
> The maven-eclipse-plugin is not maintained at all. Everyone should use m2e. We
> have developed an eclipse plugin to apply these settings automatically when
> using m2e:
> https://github.com/topicusonderwijs/m2e-settings
>
> I think we should create a wicket-eclipse-settings maven artifact and use
> that.
>
> Best regards,
> Emond
>
> On Wednesday 04 March 2015 10:09:31 Tobias Soloschenko wrote:
>> Hi Martin,
>>
>> maybe we can use the maven-eclipse-plugin to apply formatting rules:
>>
>> http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-code-styl
>> es.html
>>
>> The plugin itself is not well maintained, but we only need to apply the
>> formatting rules to the IDE - I think on IDEA it is ignored, but we have to
>> check it.
>>
>> Does this address your feature?
>>
>> kind regards
>>
>> Tobias
>>
>> 2015-03-04 9:30 GMT+01:00 Martin Grigorov <mg...@apache.org>:
>>> Hi Tobias,
>>>
>>> I personally use Intellij IDEA and these files are in not in use by me.
>>> But AFAIR the most useful feature in them is the code formatting rules. We
>>> try to keep Wicket code formatted the same style. IMO this helps a lot in
>>> maintenance. I personally get distracted when debugging something and see
>>> code snippet that is wrongly formatted, or doesn't use braces, or
>>> something
>>> similar.
>>>
>>> I think I am the only user of IDEA in the team (except Peter Ertl, but he
>>> is not very active lately) so I'm sure others will give their feedback on
>>> this soon.
>>>
>>> Martin Grigorov
>>> Wicket Training and Consulting
>>> https://twitter.com/mtgrigorov
>>>
>>> On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
>>>
>>> tobiassoloschenko@googlemail.com> wrote:
>>>> Hi everyone,
>>>>
>>>> I saw that there were several commits to .settings the last time and I
>>>> wondered why this folder is required in the repository anymore. Here is
>>>> a
>>>> list of the files in a .settings folder (wicket/.settings)
>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.core.re
>>> sources.prefs
>>>
>>>
>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m2e.cor
>>> e.prefs
>>>
>>>
>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.pde.cor
>>> e.prefs
>>>
>>>
>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.com
>>> mon.component
>>>
>>>
>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.com
>>> mon.project.facet.core.xml>
>>>> I think because maven is used to configure the projects we can remove
>>> those
>>>
>>>> files from the repository and configure it all in maven.
>>>>
>>>> Encoding can be configured by (see
>>>> http://maven.apache.org/general.html#encoding-warning):
>>>>
>>>> <properties>
>>>>
>>>> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
>>> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
>>>
>>>> </properties>
>>>>
>>>> Java Compile-Level can be configured with the compiler-plugin:
>>>> <plugins>
>>>>
>>>> <plugin>
>>>>
>>>> <groupId>org.apache.maven.plugins</groupId>
>>>> <artifactId>maven-compiler-plugin</artifactId>
>>>> <version>3.2</version>
>>>> <configuration>
>>>>
>>>> <source>1.7</source>
>>>> <target>1.7</target>
>>>>
>>>> </configuration>
>>>>
>>>> </plugin>
>>>>
>>>> </plugins>
>>>>
>>>> The project facets are configured by "Maven Integration for Eclipse WTP"
>>>> and it receives the information of the web.xml and the packaging
>>> configured
>>>
>>>> in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
>>>> http://marketplace.eclipse.org/node/96737)
>>>>
>>>> The only entries to be custom configured are in
>>>> org.eclipse.core.resources.prefs containing .deprecations and I wonder
>>>> if
>>>> they are required anymore.
>>>>
>>>> The only thing to be done after importing the project into workspace is
>>> to
>>>
>>>> configure it as maven project. The .settings folder is created through
>>> the
>>>
>>>> m2e plugin based on the pom.xml, web.xml.
>>>>
>>>> Did I overlook something?
>>>>
>>>> What do you think?
>>>>
>>>> kind regards
>>>>
>>>> Tobias
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Tobias Soloschenko <to...@googlemail.com>.
It copies preconfigured settings files from a given directory to .settings of a maven project. I just wanted to discuss it first, before creating a ticket. :-)
I'm going to file in a ticket this afternoon and try to find some time to provide a PR.
kind regards
Tobias
> Am 04.03.2015 um 12:19 schrieb Martin Grigorov <mg...@apache.org>:
>
> @Tobias: please file a ticket and assign it to Emond :-)
> Or provide the PR yourself if you understand what
> https://github.com/topicusonderwijs/m2e-settings does.
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Wed, Mar 4, 2015 at 11:41 AM, Tobias Soloschenko <
> tobiassoloschenko@googlemail.com> wrote:
>
>> Good point to use a separate artifact, because users of IDEA do not
>> require those settings - but as Martin mentioned it should be enforced that
>> eclipse user must run the configuration of that artifact to ensure the code
>> style.
>>
>> kind regards
>>
>> Tobias
>>
>>>> Am 04.03.2015 um 10:28 schrieb Emond Papegaaij <
>>> emond.papegaaij@topicus.nl>:
>>>
>>> The maven-eclipse-plugin is not maintained at all. Everyone should use
>> m2e. We
>>> have developed an eclipse plugin to apply these settings automatically
>> when
>>> using m2e:
>>> https://github.com/topicusonderwijs/m2e-settings
>>>
>>> I think we should create a wicket-eclipse-settings maven artifact and use
>>> that.
>>>
>>> Best regards,
>>> Emond
>>>
>>>> On Wednesday 04 March 2015 10:09:31 Tobias Soloschenko wrote:
>>>> Hi Martin,
>>>>
>>>> maybe we can use the maven-eclipse-plugin to apply formatting rules:
>> http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-code-styl
>>>> es.html
>>>>
>>>> The plugin itself is not well maintained, but we only need to apply the
>>>> formatting rules to the IDE - I think on IDEA it is ignored, but we
>> have to
>>>> check it.
>>>>
>>>> Does this address your feature?
>>>>
>>>> kind regards
>>>>
>>>> Tobias
>>>>
>>>> 2015-03-04 9:30 GMT+01:00 Martin Grigorov <mg...@apache.org>:
>>>>> Hi Tobias,
>>>>>
>>>>> I personally use Intellij IDEA and these files are in not in use by me.
>>>>> But AFAIR the most useful feature in them is the code formatting
>> rules. We
>>>>> try to keep Wicket code formatted the same style. IMO this helps a lot
>> in
>>>>> maintenance. I personally get distracted when debugging something and
>> see
>>>>> code snippet that is wrongly formatted, or doesn't use braces, or
>>>>> something
>>>>> similar.
>>>>>
>>>>> I think I am the only user of IDEA in the team (except Peter Ertl, but
>> he
>>>>> is not very active lately) so I'm sure others will give their feedback
>> on
>>>>> this soon.
>>>>>
>>>>> Martin Grigorov
>>>>> Wicket Training and Consulting
>>>>> https://twitter.com/mtgrigorov
>>>>>
>>>>> On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
>>>>>
>>>>> tobiassoloschenko@googlemail.com> wrote:
>>>>>> Hi everyone,
>>>>>>
>>>>>> I saw that there were several commits to .settings the last time and I
>>>>>> wondered why this folder is required in the repository anymore. Here
>> is
>>>>>> a
>>>>>> list of the files in a .settings folder (wicket/.settings)
>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.core.re
>>>>> sources.prefs
>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m2e.cor
>>>>> e.prefs
>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.pde.cor
>>>>> e.prefs
>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.com
>>>>> mon.component
>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.com
>>>>> mon.project.facet.core.xml>
>>>>>> I think because maven is used to configure the projects we can remove
>>>>>
>>>>> those
>>>>>
>>>>>> files from the repository and configure it all in maven.
>>>>>>
>>>>>> Encoding can be configured by (see
>>>>>> http://maven.apache.org/general.html#encoding-warning):
>>>>>>
>>>>>> <properties>
>>>>>>
>>>>>> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
>> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
>>>>>
>>>>>> </properties>
>>>>>>
>>>>>> Java Compile-Level can be configured with the compiler-plugin:
>>>>>> <plugins>
>>>>>>
>>>>>> <plugin>
>>>>>>
>>>>>> <groupId>org.apache.maven.plugins</groupId>
>>>>>> <artifactId>maven-compiler-plugin</artifactId>
>>>>>> <version>3.2</version>
>>>>>> <configuration>
>>>>>>
>>>>>> <source>1.7</source>
>>>>>> <target>1.7</target>
>>>>>>
>>>>>> </configuration>
>>>>>>
>>>>>> </plugin>
>>>>>>
>>>>>> </plugins>
>>>>>>
>>>>>> The project facets are configured by "Maven Integration for Eclipse
>> WTP"
>>>>>> and it receives the information of the web.xml and the packaging
>>>>>
>>>>> configured
>>>>>
>>>>>> in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
>>>>>> http://marketplace.eclipse.org/node/96737)
>>>>>>
>>>>>> The only entries to be custom configured are in
>>>>>> org.eclipse.core.resources.prefs containing .deprecations and I wonder
>>>>>> if
>>>>>> they are required anymore.
>>>>>>
>>>>>> The only thing to be done after importing the project into workspace
>> is
>>>>>
>>>>> to
>>>>>
>>>>>> configure it as maven project. The .settings folder is created through
>>>>>
>>>>> the
>>>>>
>>>>>> m2e plugin based on the pom.xml, web.xml.
>>>>>>
>>>>>> Did I overlook something?
>>>>>>
>>>>>> What do you think?
>>>>>>
>>>>>> kind regards
>>>>>>
>>>>>> Tobias
>>
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Tobias Soloschenko <to...@googlemail.com>.
done: https://issues.apache.org/jira/browse/WICKET-5848
2015-03-04 12:19 GMT+01:00 Martin Grigorov <mg...@apache.org>:
> @Tobias: please file a ticket and assign it to Emond :-)
> Or provide the PR yourself if you understand what
> https://github.com/topicusonderwijs/m2e-settings does.
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Wed, Mar 4, 2015 at 11:41 AM, Tobias Soloschenko <
> tobiassoloschenko@googlemail.com> wrote:
>
> > Good point to use a separate artifact, because users of IDEA do not
> > require those settings - but as Martin mentioned it should be enforced
> that
> > eclipse user must run the configuration of that artifact to ensure the
> code
> > style.
> >
> > kind regards
> >
> > Tobias
> >
> > > Am 04.03.2015 um 10:28 schrieb Emond Papegaaij <
> > emond.papegaaij@topicus.nl>:
> > >
> > > The maven-eclipse-plugin is not maintained at all. Everyone should use
> > m2e. We
> > > have developed an eclipse plugin to apply these settings automatically
> > when
> > > using m2e:
> > > https://github.com/topicusonderwijs/m2e-settings
> > >
> > > I think we should create a wicket-eclipse-settings maven artifact and
> use
> > > that.
> > >
> > > Best regards,
> > > Emond
> > >
> > >> On Wednesday 04 March 2015 10:09:31 Tobias Soloschenko wrote:
> > >> Hi Martin,
> > >>
> > >> maybe we can use the maven-eclipse-plugin to apply formatting rules:
> > >>
> > >>
> >
> http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-code-styl
> > >> es.html
> > >>
> > >> The plugin itself is not well maintained, but we only need to apply
> the
> > >> formatting rules to the IDE - I think on IDEA it is ignored, but we
> > have to
> > >> check it.
> > >>
> > >> Does this address your feature?
> > >>
> > >> kind regards
> > >>
> > >> Tobias
> > >>
> > >> 2015-03-04 9:30 GMT+01:00 Martin Grigorov <mg...@apache.org>:
> > >>> Hi Tobias,
> > >>>
> > >>> I personally use Intellij IDEA and these files are in not in use by
> me.
> > >>> But AFAIR the most useful feature in them is the code formatting
> > rules. We
> > >>> try to keep Wicket code formatted the same style. IMO this helps a
> lot
> > in
> > >>> maintenance. I personally get distracted when debugging something and
> > see
> > >>> code snippet that is wrongly formatted, or doesn't use braces, or
> > >>> something
> > >>> similar.
> > >>>
> > >>> I think I am the only user of IDEA in the team (except Peter Ertl,
> but
> > he
> > >>> is not very active lately) so I'm sure others will give their
> feedback
> > on
> > >>> this soon.
> > >>>
> > >>> Martin Grigorov
> > >>> Wicket Training and Consulting
> > >>> https://twitter.com/mtgrigorov
> > >>>
> > >>> On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
> > >>>
> > >>> tobiassoloschenko@googlemail.com> wrote:
> > >>>> Hi everyone,
> > >>>>
> > >>>> I saw that there were several commits to .settings the last time
> and I
> > >>>> wondered why this folder is required in the repository anymore. Here
> > is
> > >>>> a
> > >>>> list of the files in a .settings folder (wicket/.settings)
> > >>>
> > >>>
> >
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.core.re
> > >>> sources.prefs
> > >>>
> > >>>
> > >>>
> >
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m2e.cor
> > >>> e.prefs
> > >>>
> > >>>
> > >>>
> >
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.pde.cor
> > >>> e.prefs
> > >>>
> > >>>
> > >>>
> >
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.com
> > >>> mon.component
> > >>>
> > >>>
> > >>>
> >
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.com
> > >>> mon.project.facet.core.xml>
> > >>>> I think because maven is used to configure the projects we can
> remove
> > >>>
> > >>> those
> > >>>
> > >>>> files from the repository and configure it all in maven.
> > >>>>
> > >>>> Encoding can be configured by (see
> > >>>> http://maven.apache.org/general.html#encoding-warning):
> > >>>>
> > >>>> <properties>
> > >>>>
> > >>>>
> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
> > >>>
> > >>>
> >
> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
> > >>>
> > >>>> </properties>
> > >>>>
> > >>>> Java Compile-Level can be configured with the compiler-plugin:
> > >>>> <plugins>
> > >>>>
> > >>>> <plugin>
> > >>>>
> > >>>> <groupId>org.apache.maven.plugins</groupId>
> > >>>> <artifactId>maven-compiler-plugin</artifactId>
> > >>>> <version>3.2</version>
> > >>>> <configuration>
> > >>>>
> > >>>> <source>1.7</source>
> > >>>> <target>1.7</target>
> > >>>>
> > >>>> </configuration>
> > >>>>
> > >>>> </plugin>
> > >>>>
> > >>>> </plugins>
> > >>>>
> > >>>> The project facets are configured by "Maven Integration for Eclipse
> > WTP"
> > >>>> and it receives the information of the web.xml and the packaging
> > >>>
> > >>> configured
> > >>>
> > >>>> in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
> > >>>> http://marketplace.eclipse.org/node/96737)
> > >>>>
> > >>>> The only entries to be custom configured are in
> > >>>> org.eclipse.core.resources.prefs containing .deprecations and I
> wonder
> > >>>> if
> > >>>> they are required anymore.
> > >>>>
> > >>>> The only thing to be done after importing the project into workspace
> > is
> > >>>
> > >>> to
> > >>>
> > >>>> configure it as maven project. The .settings folder is created
> through
> > >>>
> > >>> the
> > >>>
> > >>>> m2e plugin based on the pom.xml, web.xml.
> > >>>>
> > >>>> Did I overlook something?
> > >>>>
> > >>>> What do you think?
> > >>>>
> > >>>> kind regards
> > >>>>
> > >>>> Tobias
> > >
> >
>
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Martin Grigorov <mg...@apache.org>.
@Tobias: please file a ticket and assign it to Emond :-)
Or provide the PR yourself if you understand what
https://github.com/topicusonderwijs/m2e-settings does.
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Wed, Mar 4, 2015 at 11:41 AM, Tobias Soloschenko <
tobiassoloschenko@googlemail.com> wrote:
> Good point to use a separate artifact, because users of IDEA do not
> require those settings - but as Martin mentioned it should be enforced that
> eclipse user must run the configuration of that artifact to ensure the code
> style.
>
> kind regards
>
> Tobias
>
> > Am 04.03.2015 um 10:28 schrieb Emond Papegaaij <
> emond.papegaaij@topicus.nl>:
> >
> > The maven-eclipse-plugin is not maintained at all. Everyone should use
> m2e. We
> > have developed an eclipse plugin to apply these settings automatically
> when
> > using m2e:
> > https://github.com/topicusonderwijs/m2e-settings
> >
> > I think we should create a wicket-eclipse-settings maven artifact and use
> > that.
> >
> > Best regards,
> > Emond
> >
> >> On Wednesday 04 March 2015 10:09:31 Tobias Soloschenko wrote:
> >> Hi Martin,
> >>
> >> maybe we can use the maven-eclipse-plugin to apply formatting rules:
> >>
> >>
> http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-code-styl
> >> es.html
> >>
> >> The plugin itself is not well maintained, but we only need to apply the
> >> formatting rules to the IDE - I think on IDEA it is ignored, but we
> have to
> >> check it.
> >>
> >> Does this address your feature?
> >>
> >> kind regards
> >>
> >> Tobias
> >>
> >> 2015-03-04 9:30 GMT+01:00 Martin Grigorov <mg...@apache.org>:
> >>> Hi Tobias,
> >>>
> >>> I personally use Intellij IDEA and these files are in not in use by me.
> >>> But AFAIR the most useful feature in them is the code formatting
> rules. We
> >>> try to keep Wicket code formatted the same style. IMO this helps a lot
> in
> >>> maintenance. I personally get distracted when debugging something and
> see
> >>> code snippet that is wrongly formatted, or doesn't use braces, or
> >>> something
> >>> similar.
> >>>
> >>> I think I am the only user of IDEA in the team (except Peter Ertl, but
> he
> >>> is not very active lately) so I'm sure others will give their feedback
> on
> >>> this soon.
> >>>
> >>> Martin Grigorov
> >>> Wicket Training and Consulting
> >>> https://twitter.com/mtgrigorov
> >>>
> >>> On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
> >>>
> >>> tobiassoloschenko@googlemail.com> wrote:
> >>>> Hi everyone,
> >>>>
> >>>> I saw that there were several commits to .settings the last time and I
> >>>> wondered why this folder is required in the repository anymore. Here
> is
> >>>> a
> >>>> list of the files in a .settings folder (wicket/.settings)
> >>>
> >>>
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.core.re
> >>> sources.prefs
> >>>
> >>>
> >>>
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m2e.cor
> >>> e.prefs
> >>>
> >>>
> >>>
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.pde.cor
> >>> e.prefs
> >>>
> >>>
> >>>
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.com
> >>> mon.component
> >>>
> >>>
> >>>
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.com
> >>> mon.project.facet.core.xml>
> >>>> I think because maven is used to configure the projects we can remove
> >>>
> >>> those
> >>>
> >>>> files from the repository and configure it all in maven.
> >>>>
> >>>> Encoding can be configured by (see
> >>>> http://maven.apache.org/general.html#encoding-warning):
> >>>>
> >>>> <properties>
> >>>>
> >>>> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
> >>>
> >>>
> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
> >>>
> >>>> </properties>
> >>>>
> >>>> Java Compile-Level can be configured with the compiler-plugin:
> >>>> <plugins>
> >>>>
> >>>> <plugin>
> >>>>
> >>>> <groupId>org.apache.maven.plugins</groupId>
> >>>> <artifactId>maven-compiler-plugin</artifactId>
> >>>> <version>3.2</version>
> >>>> <configuration>
> >>>>
> >>>> <source>1.7</source>
> >>>> <target>1.7</target>
> >>>>
> >>>> </configuration>
> >>>>
> >>>> </plugin>
> >>>>
> >>>> </plugins>
> >>>>
> >>>> The project facets are configured by "Maven Integration for Eclipse
> WTP"
> >>>> and it receives the information of the web.xml and the packaging
> >>>
> >>> configured
> >>>
> >>>> in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
> >>>> http://marketplace.eclipse.org/node/96737)
> >>>>
> >>>> The only entries to be custom configured are in
> >>>> org.eclipse.core.resources.prefs containing .deprecations and I wonder
> >>>> if
> >>>> they are required anymore.
> >>>>
> >>>> The only thing to be done after importing the project into workspace
> is
> >>>
> >>> to
> >>>
> >>>> configure it as maven project. The .settings folder is created through
> >>>
> >>> the
> >>>
> >>>> m2e plugin based on the pom.xml, web.xml.
> >>>>
> >>>> Did I overlook something?
> >>>>
> >>>> What do you think?
> >>>>
> >>>> kind regards
> >>>>
> >>>> Tobias
> >
>
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Tobias Soloschenko <to...@googlemail.com>.
Good point to use a separate artifact, because users of IDEA do not require those settings - but as Martin mentioned it should be enforced that eclipse user must run the configuration of that artifact to ensure the code style.
kind regards
Tobias
> Am 04.03.2015 um 10:28 schrieb Emond Papegaaij <em...@topicus.nl>:
>
> The maven-eclipse-plugin is not maintained at all. Everyone should use m2e. We
> have developed an eclipse plugin to apply these settings automatically when
> using m2e:
> https://github.com/topicusonderwijs/m2e-settings
>
> I think we should create a wicket-eclipse-settings maven artifact and use
> that.
>
> Best regards,
> Emond
>
>> On Wednesday 04 March 2015 10:09:31 Tobias Soloschenko wrote:
>> Hi Martin,
>>
>> maybe we can use the maven-eclipse-plugin to apply formatting rules:
>>
>> http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-code-styl
>> es.html
>>
>> The plugin itself is not well maintained, but we only need to apply the
>> formatting rules to the IDE - I think on IDEA it is ignored, but we have to
>> check it.
>>
>> Does this address your feature?
>>
>> kind regards
>>
>> Tobias
>>
>> 2015-03-04 9:30 GMT+01:00 Martin Grigorov <mg...@apache.org>:
>>> Hi Tobias,
>>>
>>> I personally use Intellij IDEA and these files are in not in use by me.
>>> But AFAIR the most useful feature in them is the code formatting rules. We
>>> try to keep Wicket code formatted the same style. IMO this helps a lot in
>>> maintenance. I personally get distracted when debugging something and see
>>> code snippet that is wrongly formatted, or doesn't use braces, or
>>> something
>>> similar.
>>>
>>> I think I am the only user of IDEA in the team (except Peter Ertl, but he
>>> is not very active lately) so I'm sure others will give their feedback on
>>> this soon.
>>>
>>> Martin Grigorov
>>> Wicket Training and Consulting
>>> https://twitter.com/mtgrigorov
>>>
>>> On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
>>>
>>> tobiassoloschenko@googlemail.com> wrote:
>>>> Hi everyone,
>>>>
>>>> I saw that there were several commits to .settings the last time and I
>>>> wondered why this folder is required in the repository anymore. Here is
>>>> a
>>>> list of the files in a .settings folder (wicket/.settings)
>>>
>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.core.re
>>> sources.prefs
>>>
>>>
>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m2e.cor
>>> e.prefs
>>>
>>>
>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.pde.cor
>>> e.prefs
>>>
>>>
>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.com
>>> mon.component
>>>
>>>
>>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.com
>>> mon.project.facet.core.xml>
>>>> I think because maven is used to configure the projects we can remove
>>>
>>> those
>>>
>>>> files from the repository and configure it all in maven.
>>>>
>>>> Encoding can be configured by (see
>>>> http://maven.apache.org/general.html#encoding-warning):
>>>>
>>>> <properties>
>>>>
>>>> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
>>>
>>> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
>>>
>>>> </properties>
>>>>
>>>> Java Compile-Level can be configured with the compiler-plugin:
>>>> <plugins>
>>>>
>>>> <plugin>
>>>>
>>>> <groupId>org.apache.maven.plugins</groupId>
>>>> <artifactId>maven-compiler-plugin</artifactId>
>>>> <version>3.2</version>
>>>> <configuration>
>>>>
>>>> <source>1.7</source>
>>>> <target>1.7</target>
>>>>
>>>> </configuration>
>>>>
>>>> </plugin>
>>>>
>>>> </plugins>
>>>>
>>>> The project facets are configured by "Maven Integration for Eclipse WTP"
>>>> and it receives the information of the web.xml and the packaging
>>>
>>> configured
>>>
>>>> in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
>>>> http://marketplace.eclipse.org/node/96737)
>>>>
>>>> The only entries to be custom configured are in
>>>> org.eclipse.core.resources.prefs containing .deprecations and I wonder
>>>> if
>>>> they are required anymore.
>>>>
>>>> The only thing to be done after importing the project into workspace is
>>>
>>> to
>>>
>>>> configure it as maven project. The .settings folder is created through
>>>
>>> the
>>>
>>>> m2e plugin based on the pom.xml, web.xml.
>>>>
>>>> Did I overlook something?
>>>>
>>>> What do you think?
>>>>
>>>> kind regards
>>>>
>>>> Tobias
>
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Emond Papegaaij <em...@topicus.nl>.
The maven-eclipse-plugin is not maintained at all. Everyone should use m2e. We
have developed an eclipse plugin to apply these settings automatically when
using m2e:
https://github.com/topicusonderwijs/m2e-settings
I think we should create a wicket-eclipse-settings maven artifact and use
that.
Best regards,
Emond
On Wednesday 04 March 2015 10:09:31 Tobias Soloschenko wrote:
> Hi Martin,
>
> maybe we can use the maven-eclipse-plugin to apply formatting rules:
>
> http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-code-styl
> es.html
>
> The plugin itself is not well maintained, but we only need to apply the
> formatting rules to the IDE - I think on IDEA it is ignored, but we have to
> check it.
>
> Does this address your feature?
>
> kind regards
>
> Tobias
>
> 2015-03-04 9:30 GMT+01:00 Martin Grigorov <mg...@apache.org>:
> > Hi Tobias,
> >
> > I personally use Intellij IDEA and these files are in not in use by me.
> > But AFAIR the most useful feature in them is the code formatting rules. We
> > try to keep Wicket code formatted the same style. IMO this helps a lot in
> > maintenance. I personally get distracted when debugging something and see
> > code snippet that is wrongly formatted, or doesn't use braces, or
> > something
> > similar.
> >
> > I think I am the only user of IDEA in the team (except Peter Ertl, but he
> > is not very active lately) so I'm sure others will give their feedback on
> > this soon.
> >
> > Martin Grigorov
> > Wicket Training and Consulting
> > https://twitter.com/mtgrigorov
> >
> > On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
> >
> > tobiassoloschenko@googlemail.com> wrote:
> > > Hi everyone,
> > >
> > > I saw that there were several commits to .settings the last time and I
> > > wondered why this folder is required in the repository anymore. Here is
> > > a
> > > list of the files in a .settings folder (wicket/.settings)
> >
> > https://github.com/apache/wicket/blob/master/.settings/org.eclipse.core.re
> > sources.prefs
> >
> >
> > https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m2e.cor
> > e.prefs
> >
> >
> > https://github.com/apache/wicket/blob/master/.settings/org.eclipse.pde.cor
> > e.prefs
> >
> >
> > https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.com
> > mon.component
> >
> >
> > https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.com
> > mon.project.facet.core.xml>
> > > I think because maven is used to configure the projects we can remove
> >
> > those
> >
> > > files from the repository and configure it all in maven.
> > >
> > > Encoding can be configured by (see
> > > http://maven.apache.org/general.html#encoding-warning):
> > >
> > > <properties>
> > >
> > > <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
> >
> > <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
> >
> > > </properties>
> > >
> > > Java Compile-Level can be configured with the compiler-plugin:
> > > <plugins>
> > >
> > > <plugin>
> > >
> > > <groupId>org.apache.maven.plugins</groupId>
> > > <artifactId>maven-compiler-plugin</artifactId>
> > > <version>3.2</version>
> > > <configuration>
> > >
> > > <source>1.7</source>
> > > <target>1.7</target>
> > >
> > > </configuration>
> > >
> > > </plugin>
> > >
> > > </plugins>
> > >
> > > The project facets are configured by "Maven Integration for Eclipse WTP"
> > > and it receives the information of the web.xml and the packaging
> >
> > configured
> >
> > > in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
> > > http://marketplace.eclipse.org/node/96737)
> > >
> > > The only entries to be custom configured are in
> > > org.eclipse.core.resources.prefs containing .deprecations and I wonder
> > > if
> > > they are required anymore.
> > >
> > > The only thing to be done after importing the project into workspace is
> >
> > to
> >
> > > configure it as maven project. The .settings folder is created through
> >
> > the
> >
> > > m2e plugin based on the pom.xml, web.xml.
> > >
> > > Did I overlook something?
> > >
> > > What do you think?
> > >
> > > kind regards
> > >
> > > Tobias
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Tobias Soloschenko <to...@googlemail.com>.
Hi Martin,
maybe we can use the maven-eclipse-plugin to apply formatting rules:
http://maven.apache.org/plugins/maven-eclipse-plugin/examples/load-code-styles.html
The plugin itself is not well maintained, but we only need to apply the
formatting rules to the IDE - I think on IDEA it is ignored, but we have to
check it.
Does this address your feature?
kind regards
Tobias
2015-03-04 9:30 GMT+01:00 Martin Grigorov <mg...@apache.org>:
> Hi Tobias,
>
> I personally use Intellij IDEA and these files are in not in use by me.
> But AFAIR the most useful feature in them is the code formatting rules. We
> try to keep Wicket code formatted the same style. IMO this helps a lot in
> maintenance. I personally get distracted when debugging something and see
> code snippet that is wrongly formatted, or doesn't use braces, or something
> similar.
>
> I think I am the only user of IDEA in the team (except Peter Ertl, but he
> is not very active lately) so I'm sure others will give their feedback on
> this soon.
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
> tobiassoloschenko@googlemail.com> wrote:
>
> > Hi everyone,
> >
> > I saw that there were several commits to .settings the last time and I
> > wondered why this folder is required in the repository anymore. Here is a
> > list of the files in a .settings folder (wicket/.settings)
> >
> >
> >
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.core.resources.prefs
> >
> >
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m2e.core.prefs
> >
> >
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.pde.core.prefs
> >
> >
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.common.component
> >
> >
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.common.project.facet.core.xml
> >
> > I think because maven is used to configure the projects we can remove
> those
> > files from the repository and configure it all in maven.
> >
> > Encoding can be configured by (see
> > http://maven.apache.org/general.html#encoding-warning):
> >
> > <properties>
> > <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
> >
> >
> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
> > </properties>
> >
> > Java Compile-Level can be configured with the compiler-plugin:
> >
> > <plugins>
> > <plugin>
> > <groupId>org.apache.maven.plugins</groupId>
> > <artifactId>maven-compiler-plugin</artifactId>
> > <version>3.2</version>
> > <configuration>
> > <source>1.7</source>
> > <target>1.7</target>
> > </configuration>
> > </plugin>
> > </plugins>
> >
> > The project facets are configured by "Maven Integration for Eclipse WTP"
> > and it receives the information of the web.xml and the packaging
> configured
> > in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
> > http://marketplace.eclipse.org/node/96737)
> >
> > The only entries to be custom configured are in
> > org.eclipse.core.resources.prefs containing .deprecations and I wonder if
> > they are required anymore.
> >
> > The only thing to be done after importing the project into workspace is
> to
> > configure it as maven project. The .settings folder is created through
> the
> > m2e plugin based on the pom.xml, web.xml.
> >
> > Did I overlook something?
> >
> > What do you think?
> >
> > kind regards
> >
> > Tobias
> >
>
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Sven Meier <sv...@meiers.net>.
Hi,
code formatting is stored in org.eclipse.jdt.ui.prefs - but we no longer
have these files under version control since commit
2ab4c7c00d2207679c6a10d2aee8b7c5fd624ba3.
So +1 from me to remove the remaining settings. I see nothing of value
in there.
Sven
Am 04.03.2015 um 09:30 schrieb Martin Grigorov:
> Hi Tobias,
>
> I personally use Intellij IDEA and these files are in not in use by me.
> But AFAIR the most useful feature in them is the code formatting rules. We
> try to keep Wicket code formatted the same style. IMO this helps a lot in
> maintenance. I personally get distracted when debugging something and see
> code snippet that is wrongly formatted, or doesn't use braces, or something
> similar.
>
> I think I am the only user of IDEA in the team (except Peter Ertl, but he
> is not very active lately) so I'm sure others will give their feedback on
> this soon.
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
> tobiassoloschenko@googlemail.com> wrote:
>
>> Hi everyone,
>>
>> I saw that there were several commits to .settings the last time and I
>> wondered why this folder is required in the repository anymore. Here is a
>> list of the files in a .settings folder (wicket/.settings)
>>
>>
>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.core.resources.prefs
>>
>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m2e.core.prefs
>>
>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.pde.core.prefs
>>
>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.common.component
>>
>> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.common.project.facet.core.xml
>>
>> I think because maven is used to configure the projects we can remove those
>> files from the repository and configure it all in maven.
>>
>> Encoding can be configured by (see
>> http://maven.apache.org/general.html#encoding-warning):
>>
>> <properties>
>> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
>>
>> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
>> </properties>
>>
>> Java Compile-Level can be configured with the compiler-plugin:
>>
>> <plugins>
>> <plugin>
>> <groupId>org.apache.maven.plugins</groupId>
>> <artifactId>maven-compiler-plugin</artifactId>
>> <version>3.2</version>
>> <configuration>
>> <source>1.7</source>
>> <target>1.7</target>
>> </configuration>
>> </plugin>
>> </plugins>
>>
>> The project facets are configured by "Maven Integration for Eclipse WTP"
>> and it receives the information of the web.xml and the packaging configured
>> in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
>> http://marketplace.eclipse.org/node/96737)
>>
>> The only entries to be custom configured are in
>> org.eclipse.core.resources.prefs containing .deprecations and I wonder if
>> they are required anymore.
>>
>> The only thing to be done after importing the project into workspace is to
>> configure it as maven project. The .settings folder is created through the
>> m2e plugin based on the pom.xml, web.xml.
>>
>> Did I overlook something?
>>
>> What do you think?
>>
>> kind regards
>>
>> Tobias
>>
Re: [DISCUSSION] Remove .settings of projects in github
Posted by Martin Grigorov <mg...@apache.org>.
Hi Tobias,
I personally use Intellij IDEA and these files are in not in use by me.
But AFAIR the most useful feature in them is the code formatting rules. We
try to keep Wicket code formatted the same style. IMO this helps a lot in
maintenance. I personally get distracted when debugging something and see
code snippet that is wrongly formatted, or doesn't use braces, or something
similar.
I think I am the only user of IDEA in the team (except Peter Ertl, but he
is not very active lately) so I'm sure others will give their feedback on
this soon.
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Wed, Mar 4, 2015 at 9:50 AM, Tobias Soloschenko <
tobiassoloschenko@googlemail.com> wrote:
> Hi everyone,
>
> I saw that there were several commits to .settings the last time and I
> wondered why this folder is required in the repository anymore. Here is a
> list of the files in a .settings folder (wicket/.settings)
>
>
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.core.resources.prefs
>
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.m2e.core.prefs
>
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.pde.core.prefs
>
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.common.component
>
> https://github.com/apache/wicket/blob/master/.settings/org.eclipse.wst.common.project.facet.core.xml
>
> I think because maven is used to configure the projects we can remove those
> files from the repository and configure it all in maven.
>
> Encoding can be configured by (see
> http://maven.apache.org/general.html#encoding-warning):
>
> <properties>
> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
>
> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
> </properties>
>
> Java Compile-Level can be configured with the compiler-plugin:
>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <version>3.2</version>
> <configuration>
> <source>1.7</source>
> <target>1.7</target>
> </configuration>
> </plugin>
> </plugins>
>
> The project facets are configured by "Maven Integration for Eclipse WTP"
> and it receives the information of the web.xml and the packaging configured
> in the pom (war/jar). It is preinstalled in Eclipse JEE. (see
> http://marketplace.eclipse.org/node/96737)
>
> The only entries to be custom configured are in
> org.eclipse.core.resources.prefs containing .deprecations and I wonder if
> they are required anymore.
>
> The only thing to be done after importing the project into workspace is to
> configure it as maven project. The .settings folder is created through the
> m2e plugin based on the pom.xml, web.xml.
>
> Did I overlook something?
>
> What do you think?
>
> kind regards
>
> Tobias
>