You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/13 04:41:03 UTC
[GitHub] [incubator-tvm] lixiaoquan opened a new pull request #5795: [Relay] Keep fixed dim when unifying dynamic shape
lixiaoquan opened a new pull request #5795:
URL: https://github.com/apache/incubator-tvm/pull/5795
For this function:
```
fn (%True: Tensor[(?, 1), float32], %False: Tensor[(?, ?), float32]) {
free_var %f: fn () -> bool
%0 = %f();
if (%0) {
%True
} else {
%False
}
}
```
Original type inference result:
```
fn (%True: Tensor[(?, ?), float32], %False: Tensor[(?, ?), float32], %f: fn () -> bool) -> Tensor[(?, ?), float32] {
%0 = %f() /* ty=bool */;
if (%0) {
%True
} else {
%False
}
}
```
Type inference result with this patch, which keeps the fixed dim
```
fn (%True: Tensor[(?, 1), float32], %False: Tensor[(?, 1), float32], %f: fn () -> bool) -> Tensor[(?, 1), float32] {
%0 = %f() /* ty=bool */;
if (%0) {
%True
} else {
%False
}
}
```
cc @icemelon9 @kevinthesun @zhiics Could you please review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] MarisaKirisame commented on pull request #5795: [Relay] Keep fixed dim when unifying dynamic shape
Posted by GitBox <gi...@apache.org>.
MarisaKirisame commented on pull request #5795:
URL: https://github.com/apache/incubator-tvm/pull/5795#issuecomment-652665390
LGTM. @jroesch please take a look to make sure it is good. I am confused about the semantic of Any.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] MarisaKirisame merged pull request #5795: [Relay] Keep fixed dim when unifying dynamic shape
Posted by GitBox <gi...@apache.org>.
MarisaKirisame merged pull request #5795:
URL: https://github.com/apache/incubator-tvm/pull/5795
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #5795: [Relay] Keep fixed dim when unifying dynamic shape
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5795:
URL: https://github.com/apache/incubator-tvm/pull/5795#issuecomment-646354939
@icemelon9 please manage this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org