You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Bernardo Gomez Palacio <be...@gmail.com> on 2014/05/05 19:58:05 UTC
Review Request 21077: [MESOS-1259]:Enrich the Java Docs in the src/java
files. -- ExecutorDriver.java
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21077/
-----------------------------------------------------------
Review request for mesos and Mesos ReviewBot.
Bugs: MESOS-1259
https://issues.apache.org/jira/browse/MESOS-1259
Repository: mesos-git
Description
-------
[MESOS-1259]:Enrich the Java Docs in the src/java files. -- ExecutorDriver.java
Diffs
-----
src/java/src/org/apache/mesos/ExecutorDriver.java 56345dfb531492b32e032611e6fb8e68b234c5cc
Diff: https://reviews.apache.org/r/21077/diff/
Testing
-------
1. ./bootstrap && mkdir build && cd build && ../configure && make
2. cd src/java/target/apidocs
3. Open index.html in your browser. i.e. open index.html
4. Verify the Executor API.
Thanks,
Bernardo Gomez Palacio
Re: Review Request 21077: [MESOS-1259]:Enrich the Java Docs in the src/java
files. -- ExecutorDriver.java
Posted by Bernardo Gomez Palacio <be...@gmail.com>.
> On May 16, 2014, 4:13 p.m., Niklas Nielsen wrote:
> > BTW It looks like you have a common diff for all the JavaDoc RR's - would you mind split up of pack in one review? :)
Originally it was one review per file but apparently I don't know how to use the post-reviews.py since it applied the same diff.
- Bernardo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21077/#review43215
-----------------------------------------------------------
On May 15, 2014, 8:58 p.m., Bernardo Gomez Palacio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21077/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 8:58 p.m.)
>
>
> Review request for mesos and Mesos ReviewBot.
>
>
> Bugs: MESOS-1299
> https://issues.apache.org/jira/browse/MESOS-1299
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> [MESOS-1259]:Enrich the Java Docs in the src/java files. -- ExecutorDriver.java
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
> src/java/src/org/apache/mesos/ExecutorDriver.java 56345dfb531492b32e032611e6fb8e68b234c5cc
> src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
> src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cdb33b3c80ea43866d304b3f1ff1a3e7c00
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
> src/java/src/org/apache/mesos/Scheduler.java 3043f60f408e11f5dae4d1c01b51840d4d289ba3
> src/java/src/org/apache/mesos/SchedulerDriver.java ae2d915d9afb3d35d42a24b56115a386ea960154
> src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
> src/java/src/org/apache/mesos/state/Variable.java 8e1ca69e673cedab8f05c53a376d6d421d09078b
>
> Diff: https://reviews.apache.org/r/21077/diff/
>
>
> Testing
> -------
>
> 1. ./bootstrap && mkdir build && cd build && ../configure && make
> 2. cd src/java/target/apidocs
> 3. Open index.html in your browser. i.e. open index.html
> 4. Verify the Executor API.
>
>
> Thanks,
>
> Bernardo Gomez Palacio
>
>
Re: Review Request 21077: [MESOS-1259]:Enrich the Java Docs in the src/java
files. -- ExecutorDriver.java
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21077/#review43215
-----------------------------------------------------------
BTW It looks like you have a common diff for all the JavaDoc RR's - would you mind split up of pack in one review? :)
- Niklas Nielsen
On May 15, 2014, 1:58 p.m., Bernardo Gomez Palacio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21077/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 1:58 p.m.)
>
>
> Review request for mesos and Mesos ReviewBot.
>
>
> Bugs: MESOS-1299
> https://issues.apache.org/jira/browse/MESOS-1299
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> [MESOS-1259]:Enrich the Java Docs in the src/java files. -- ExecutorDriver.java
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
> src/java/src/org/apache/mesos/ExecutorDriver.java 56345dfb531492b32e032611e6fb8e68b234c5cc
> src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
> src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cdb33b3c80ea43866d304b3f1ff1a3e7c00
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
> src/java/src/org/apache/mesos/Scheduler.java 3043f60f408e11f5dae4d1c01b51840d4d289ba3
> src/java/src/org/apache/mesos/SchedulerDriver.java ae2d915d9afb3d35d42a24b56115a386ea960154
> src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
> src/java/src/org/apache/mesos/state/Variable.java 8e1ca69e673cedab8f05c53a376d6d421d09078b
>
> Diff: https://reviews.apache.org/r/21077/diff/
>
>
> Testing
> -------
>
> 1. ./bootstrap && mkdir build && cd build && ../configure && make
> 2. cd src/java/target/apidocs
> 3. Open index.html in your browser. i.e. open index.html
> 4. Verify the Executor API.
>
>
> Thanks,
>
> Bernardo Gomez Palacio
>
>
Re: Review Request 21077: [MESOS-1259]:Enrich the Java Docs in the src/java
files. -- ExecutorDriver.java
Posted by Bernardo Gomez Palacio <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21077/
-----------------------------------------------------------
(Updated May 15, 2014, 8:58 p.m.)
Review request for mesos and Mesos ReviewBot.
Bugs: MESOS-1299
https://issues.apache.org/jira/browse/MESOS-1299
Repository: mesos-git
Description
-------
[MESOS-1259]:Enrich the Java Docs in the src/java files. -- ExecutorDriver.java
Diffs (updated)
-----
src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
src/java/src/org/apache/mesos/ExecutorDriver.java 56345dfb531492b32e032611e6fb8e68b234c5cc
src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cdb33b3c80ea43866d304b3f1ff1a3e7c00
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
src/java/src/org/apache/mesos/Scheduler.java 3043f60f408e11f5dae4d1c01b51840d4d289ba3
src/java/src/org/apache/mesos/SchedulerDriver.java ae2d915d9afb3d35d42a24b56115a386ea960154
src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
src/java/src/org/apache/mesos/state/Variable.java 8e1ca69e673cedab8f05c53a376d6d421d09078b
Diff: https://reviews.apache.org/r/21077/diff/
Testing
-------
1. ./bootstrap && mkdir build && cd build && ../configure && make
2. cd src/java/target/apidocs
3. Open index.html in your browser. i.e. open index.html
4. Verify the Executor API.
Thanks,
Bernardo Gomez Palacio
Re: Review Request 21077: [MESOS-1259]:Enrich the Java Docs in the src/java
files. -- ExecutorDriver.java
Posted by Bernardo Gomez Palacio <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21077/
-----------------------------------------------------------
(Updated May 5, 2014, 6:43 p.m.)
Review request for mesos and Mesos ReviewBot.
Changes
-------
Subtask of MESOS-1259
Bugs: MESOS-1299
https://issues.apache.org/jira/browse/MESOS-1299
Repository: mesos-git
Description
-------
[MESOS-1259]:Enrich the Java Docs in the src/java files. -- ExecutorDriver.java
Diffs
-----
src/java/src/org/apache/mesos/ExecutorDriver.java 56345dfb531492b32e032611e6fb8e68b234c5cc
Diff: https://reviews.apache.org/r/21077/diff/
Testing
-------
1. ./bootstrap && mkdir build && cd build && ../configure && make
2. cd src/java/target/apidocs
3. Open index.html in your browser. i.e. open index.html
4. Verify the Executor API.
Thanks,
Bernardo Gomez Palacio