You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by Steve Salevan <st...@gmail.com> on 2015/07/09 22:29:10 UTC

Review Request 36370: Tidying RPM packaging README and specfile

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36370/
-----------------------------------------------------------

Review request for Aurora, Jake Farrell, Kevin Sweeney, Bill Farner, and Zameer Manji.


Bugs: AURORA-1391
    https://issues.apache.org/jira/browse/AURORA-1391


Repository: aurora


Description
-------

This RB removes the hard dependency on daemonize for all non-EL6 builds and tidies the README.md for better readability.  Let me know what you think and thanks!


Diffs
-----

  build-support/packaging/rpm/README.md PRE-CREATION 
  build-support/packaging/rpm/aurora.spec PRE-CREATION 

Diff: https://reviews.apache.org/r/36370/diff/


Testing
-------

Rebuilt packages


Thanks,

Steve Salevan

Re: Review Request 36370: Tidying RPM packaging README and specfile

Posted by Zameer Manji <zm...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36370/#review91186
-----------------------------------------------------------

Ship it!


Ship It!

- Zameer Manji


On July 9, 2015, 1:29 p.m., Steve Salevan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36370/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 1:29 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell, Kevin Sweeney, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1391
>     https://issues.apache.org/jira/browse/AURORA-1391
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This RB removes the hard dependency on daemonize for all non-EL6 builds and tidies the README.md for better readability.  Let me know what you think and thanks!
> 
> 
> Diffs
> -----
> 
>   build-support/packaging/rpm/README.md PRE-CREATION 
>   build-support/packaging/rpm/aurora.spec PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36370/diff/
> 
> 
> Testing
> -------
> 
> Rebuilt packages
> 
> 
> Thanks,
> 
> Steve Salevan
> 
>

Re: Review Request 36370: Tidying RPM packaging README and specfile

Posted by Bill Farner <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36370/#review91207
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On July 9, 2015, 8:29 p.m., Steve Salevan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36370/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 8:29 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell, Kevin Sweeney, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1391
>     https://issues.apache.org/jira/browse/AURORA-1391
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This RB removes the hard dependency on daemonize for all non-EL6 builds and tidies the README.md for better readability.  Let me know what you think and thanks!
> 
> 
> Diffs
> -----
> 
>   build-support/packaging/rpm/README.md PRE-CREATION 
>   build-support/packaging/rpm/aurora.spec PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36370/diff/
> 
> 
> Testing
> -------
> 
> Rebuilt packages
> 
> 
> Thanks,
> 
> Steve Salevan
> 
>

Re: Review Request 36370: Tidying RPM packaging README and specfile

Posted by Aurora ReviewBot <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36370/#review91194
-----------------------------------------------------------

Ship it!


Master (e996ca5) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On July 9, 2015, 8:29 p.m., Steve Salevan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36370/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 8:29 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell, Kevin Sweeney, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1391
>     https://issues.apache.org/jira/browse/AURORA-1391
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This RB removes the hard dependency on daemonize for all non-EL6 builds and tidies the README.md for better readability.  Let me know what you think and thanks!
> 
> 
> Diffs
> -----
> 
>   build-support/packaging/rpm/README.md PRE-CREATION 
>   build-support/packaging/rpm/aurora.spec PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36370/diff/
> 
> 
> Testing
> -------
> 
> Rebuilt packages
> 
> 
> Thanks,
> 
> Steve Salevan
> 
>