You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/12/22 15:43:00 UTC
[jira] [Commented] (ISIS-1785) DomainService#menuOrder and
DomainServiceLayout#menuOrder are not equivalent
[ https://issues.apache.org/jira/browse/ISIS-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301575#comment-16301575 ]
ASF subversion and git services commented on ISIS-1785:
-------------------------------------------------------
Commit cb30f14b9d820d3e2e5b53e1ec3e50998d7b1120 in isis's branch refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=cb30f14 ]
ISIS-1785: fixes comparison, the undefined value is (Integer.MAX_VALUE - 100), not Integer.MAX_VALUE (this in DomainServiceMenuOrder)
Other changes in this commit are just cosmetic refactorings etc
> DomainService#menuOrder and DomainServiceLayout#menuOrder are not equivalent
> ----------------------------------------------------------------------------
>
> Key: ISIS-1785
> URL: https://issues.apache.org/jira/browse/ISIS-1785
> Project: Isis
> Issue Type: Bug
> Reporter: Rosco Kalis
> Assignee: Dan Haywood
> Fix For: 1.16.0
>
>
> The Apache Isis documentation mentions that these two options are equivalent:
> {code}
> * <p>
> * Either this attribute or {@link DomainServiceLayout#menuOrder()} can be used; they are equivalent.
> * Typically this attribute is used for services with a {@link #nature() nature} of
> * {@link NatureOfService#DOMAIN domain} (these are not visible in the UI) whereas
> * {@link DomainServiceLayout#menuOrder()} is used for services with a nature of
> * {@link NatureOfService#VIEW_MENU_ONLY} (which do appear in the UI)
> * </p>
> {code}
> However, using DomainService#menuOrder on NatureOfService#VIEW_MENU_ONLY services did not appear to work correctly. DomainServiceLayout#menuOrder does appear to be working.
> Our application was using DomainService#menuOrder in this [commit|https://github.com/incodehq/ecpcrm/tree/711461c7224ee3e564fb8e6709d34673fb62938d], after which we changed to DomainServiceLayout#menuOrder in the next [commit|https://github.com/incodehq/ecpcrm/tree/154cc56607342870aad1832371e58c1b10eece25]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)