You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/21 23:06:16 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #15991: Bump pyupgrade v2.13.0 to v2.18.1

mik-laj commented on a change in pull request #15991:
URL: https://github.com/apache/airflow/pull/15991#discussion_r637291625



##########
File path: airflow/executors/base_executor.py
##########
@@ -168,7 +168,7 @@ def order_queued_tasks_by_priority(self) -> List[Tuple[TaskInstanceKey, QueuedTa
         :return: List of tuples from the queued_tasks according to the priority.
         """
         return sorted(
-            [(k, v) for k, v in self.queued_tasks.items()],  # pylint: disable=unnecessary-comprehension
+            ((k, v) for k, v in self.queued_tasks.items()),  # pylint: disable=unnecessary-comprehension

Review comment:
       Right. This has been disabled and should be fixed. https://github.com/apache/airflow/pull/6888




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org