You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@causeway.apache.org by da...@apache.org on 2023/06/16 22:53:27 UTC

[causeway] 01/09: CAUSEWAY-3395 : removes BufferedImage from auto gen of showcase

This is an automated email from the ASF dual-hosted git repository.

danhaywood pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/causeway.git

commit 8ff198aea8e73753e41b0fbf6338bf8c4dd8b8e7
Author: danhaywood <da...@haywood-associates.co.uk>
AuthorDate: Fri Jun 16 23:49:50 2023 +0100

    CAUSEWAY-3395 : removes BufferedImage from auto gen of showcase
---
 .../main/java/demoapp/dom/types/package-info.java  |  4 +++-
 .../demoshowcases/value/ValueShowCase.java         | 25 +++++++++++-----------
 2 files changed, 16 insertions(+), 13 deletions(-)

diff --git a/examples/demo/domain/src/main/java/demoapp/dom/types/package-info.java b/examples/demo/domain/src/main/java/demoapp/dom/types/package-info.java
index ed4e6a5b5f..b8bb5d7dd4 100644
--- a/examples/demo/domain/src/main/java/demoapp/dom/types/package-info.java
+++ b/examples/demo/domain/src/main/java/demoapp/dom/types/package-info.java
@@ -1,8 +1,10 @@
 /**
- * These files were (almost completely) GENERATED by org.apache.causeway.tooling.metaprog.demoshowcases.value.ValueTypeGenTemplateTest.
+ * Many of these files were GENERATED by org.apache.causeway.tooling.metaprog.demoshowcases.value.ValueTypeGenTemplateTest.
  *
  * The exception is for some datatypes that have custom `jdo` or `jpa` packages; a packages-info.java file indicates this.
  *
+ * Oh, and where bugs have been raised, the generated .adoc files have been edited there also.
+ *
  * <p>
  * Do NOT edit!
  * </p>
diff --git a/tooling/metaprog/src/main/java/org/apache/causeway/tooling/metaprog/demoshowcases/value/ValueShowCase.java b/tooling/metaprog/src/main/java/org/apache/causeway/tooling/metaprog/demoshowcases/value/ValueShowCase.java
index a0afc3dd5a..203978e389 100644
--- a/tooling/metaprog/src/main/java/org/apache/causeway/tooling/metaprog/demoshowcases/value/ValueShowCase.java
+++ b/tooling/metaprog/src/main/java/org/apache/causeway/tooling/metaprog/demoshowcases/value/ValueShowCase.java
@@ -92,17 +92,18 @@ public enum ValueShowCase {
             .causewaySpecific(true)
             .templateVariant(TemplateVariant.DEFAULT)
     ),
-    JAVAAWTBUFFEREDIMAGE(Config.builder()
-            .showcaseName("BufferedImage")
-            .javaPackage("demoapp.dom.types.javaawt.images")
-            .showcaseValueFullyQualifiedType("java.awt.image.BufferedImage")
-            .showcaseValueSemantics("org.apache.causeway.core.metamodel.valuesemantics.BufferedImageValueSemantics")
-            .frameworkSupportForJpa(true)
-            .frameworkSupportForJdo(true)
-            .frameworkSupportForJaxb(true)
-            .templates(Template.REGULAR_SET_NO_SAMPLES)
-            .templateVariant(TemplateVariant.DEFAULT)
-    ),
+    // removed, due to https://issues.apache.org/jira/browse/CAUSEWAY-3487 ... no support for editable properties, view model or title.
+//    JAVAAWTBUFFEREDIMAGE(Config.builder()
+//            .showcaseName("BufferedImage")
+//            .javaPackage("demoapp.dom.types.javaawt.images")
+//            .showcaseValueFullyQualifiedType("java.awt.image.BufferedImage")
+//            .showcaseValueSemantics("org.apache.causeway.core.metamodel.valuesemantics.BufferedImageValueSemantics")
+//            .frameworkSupportForJpa(true)
+//            .frameworkSupportForJdo(true)
+//            .frameworkSupportForJaxb(true)
+//            .templates(Template.REGULAR_SET_NO_SAMPLES)
+//            .templateVariant(TemplateVariant.DEFAULT)
+//    ),
     JAVAMATHBIGDECIMAL(Config.builder()
             .showcaseName("BigDecimal")
             .javaPackage("demoapp.dom.types.javamath.bigdecimals")
@@ -118,7 +119,7 @@ public enum ValueShowCase {
             .templateVariant(TemplateVariant.DEFAULT)
     ),
     JAVANETURL(Config.builder()
-            .showcaseName("URLs")
+            .showcaseName("Url")
             .javaPackage("demoapp.dom.types.javanet.urls")
             .showcaseValueFullyQualifiedType("java.net.URL")
             .showcaseValueSemantics("org.apache.causeway.core.metamodel.valuesemantics.URLValueSemantics")