You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/04/07 17:05:31 UTC

[Impala-ASF-CR] IMPALA-9607: Fix test column storage attributes Kudu test 

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15674


Change subject: IMPALA-9607: Fix test_column_storage_attributes Kudu test
......................................................................

IMPALA-9607: Fix test_column_storage_attributes Kudu test

This patch fixes the test_column_storage_attributes test for Kudu tables
by removing the type attributes from the VARCHAR column name.

I tested this fix in my development environment by running test_kudu.py
with `--exploration_strategy exhaustive`.

Change-Id: I1b69a342a5b144beceefd17fb5a84547a1ae0103
---
M tests/query_test/test_kudu.py
1 file changed, 5 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/15674/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b69a342a5b144beceefd17fb5a84547a1ae0103
Gerrit-Change-Number: 15674
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[Impala-ASF-CR] IMPALA-9607: Fix test column storage attributes Kudu test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15674 )

Change subject: IMPALA-9607: Fix test_column_storage_attributes Kudu test
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5736/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b69a342a5b144beceefd17fb5a84547a1ae0103
Gerrit-Change-Number: 15674
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 17:21:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9607: Fix test column storage attributes Kudu test

Posted by "Alice Fan (Code Review)" <ge...@cloudera.org>.
Alice Fan has posted comments on this change. ( http://gerrit.cloudera.org:8080/15674 )

Change subject: IMPALA-9607: Fix test_column_storage_attributes Kudu test
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b69a342a5b144beceefd17fb5a84547a1ae0103
Gerrit-Change-Number: 15674
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Apr 2020 04:42:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9607: Fix test column storage attributes Kudu test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15674 )

Change subject: IMPALA-9607: Fix test_column_storage_attributes Kudu test
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b69a342a5b144beceefd17fb5a84547a1ae0103
Gerrit-Change-Number: 15674
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Apr 2020 02:51:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9607: Fix test column storage attributes Kudu test

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15674 )

Change subject: IMPALA-9607: Fix test_column_storage_attributes Kudu test
......................................................................


Patch Set 2: Code-Review+2

Thanks for the fix!


-- 
To view, visit http://gerrit.cloudera.org:8080/15674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b69a342a5b144beceefd17fb5a84547a1ae0103
Gerrit-Change-Number: 15674
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Apr 2020 12:43:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9607: Fix test column storage attributes Kudu test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15674 )

Change subject: IMPALA-9607: Fix test_column_storage_attributes Kudu test
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5621/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b69a342a5b144beceefd17fb5a84547a1ae0103
Gerrit-Change-Number: 15674
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 22:16:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9607: Fix test column storage attributes Kudu test

Posted by "Alice Fan (Code Review)" <ge...@cloudera.org>.
Alice Fan has posted comments on this change. ( http://gerrit.cloudera.org:8080/15674 )

Change subject: IMPALA-9607: Fix test_column_storage_attributes Kudu test
......................................................................


Patch Set 1: Code-Review+1

Thanks Grant for the quick fix.


-- 
To view, visit http://gerrit.cloudera.org:8080/15674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b69a342a5b144beceefd17fb5a84547a1ae0103
Gerrit-Change-Number: 15674
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 19:13:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9607: Fix test column storage attributes Kudu test

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15674 )

Change subject: IMPALA-9607: Fix test_column_storage_attributes Kudu test
......................................................................

IMPALA-9607: Fix test_column_storage_attributes Kudu test

This patch fixes the test_column_storage_attributes test for Kudu tables
by removing the type attributes from the VARCHAR column name.

I tested this fix in my development environment by running test_kudu.py
with `--exploration_strategy exhaustive`.

Change-Id: I1b69a342a5b144beceefd17fb5a84547a1ae0103
Reviewed-on: http://gerrit.cloudera.org:8080/15674
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Alice Fan <fa...@gmail.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
---
M tests/query_test/test_kudu.py
1 file changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Alice Fan: Looks good to me, but someone else must approve
  Csaba Ringhofer: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/15674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b69a342a5b144beceefd17fb5a84547a1ae0103
Gerrit-Change-Number: 15674
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>