You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by "lixmgl (via GitHub)" <gi...@apache.org> on 2023/06/26 16:15:51 UTC

[GitHub] [yunikorn-core] lixmgl commented on pull request #581: [YUNIKORN-1800] Extend Application event wrapper with new events

lixmgl commented on PR #581:
URL: https://github.com/apache/yunikorn-core/pull/581#issuecomment-1607808506

   > Two things right now:
   > 
   > 1. Fix the unit tests: you're calling a locked method `Application.GetAllocatedResource()` while already having the lock
   > 2. Add new test cases to `application_test.go`
   
   Yes @pbacsko will update the unit tests in next round.
   Question for State change: New: Since NEW is the initial state
   Do we need to send event when state change: new?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org