You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by zhouxinyu <gi...@git.apache.org> on 2017/01/10 02:43:39 UTC

[GitHub] incubator-rocketmq issue #3: [ROCKETMQ-6] Use logger for exceptions instead ...

Github user zhouxinyu commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/3
  
    Hi, @shroman 
    
    About `e.printStackTrace()`, the error message should log to file surely, but can we keep the `e.printStackTrace()` if the call stack is in broker start process. IMO, print the error message to `stderr` will be more visualized, the developers can quick locate the reason why broker start failed.
    
    And I have another question, why this PR prefer to use `+`  to concat string instead of using format string?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---