You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/03/17 01:40:24 UTC

[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #3471: [Enhancement] Method invocation may produce NPE[MeshMessageProtocolAdaptor]

Alonexc opened a new issue, #3471:
URL: https://github.com/apache/incubator-eventmesh/issues/3471

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   ![image](https://user-images.githubusercontent.com/91315508/225789965-3271da85-0a5e-4b9e-b16e-c22b2720e85e.png)
   ![image](https://user-images.githubusercontent.com/91315508/225789973-8ebfbf95-13be-4ba4-b2f4-385fdb30dd6e.png)
   located at:
   eventmesh-protocol-plugin/eventmesh-protocol-meshmessage/src/main/java/org/apache/eventmesh/protocol/meshmessage/MeshMessageProtocolAdaptor.java line 119,131
   
   
   ### Describe the solution you'd like
   
   ![image](https://user-images.githubusercontent.com/91315508/225790003-c165cd3a-20c0-42c4-8711-b353b6c05166.png)
   ![image](https://user-images.githubusercontent.com/91315508/225790013-99aba3b7-839d-4875-abf1-676c43ca4c30.png)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] pandaapo commented on issue #3471: [Enhancement] Method invocation may produce NPE[MeshMessageProtocolAdaptor]

Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on issue #3471:
URL: https://github.com/apache/eventmesh/issues/3471#issuecomment-1517979122

   https://github.com/apache/eventmesh/blob/7d3bbde05289982d19ab39ff1a8f1c55a382e5d5/eventmesh-protocol-plugin/eventmesh-protocol-meshmessage/src/main/java/org/apache/eventmesh/protocol/meshmessage/MeshMessageProtocolAdaptor.java#L118-L119
   
   If `cloudEvent.getExtension(Constants.PROTOCOL_DESC)` is null, the logic before `:` will be executed.
   
   https://github.com/apache/eventmesh/blob/7d3bbde05289982d19ab39ff1a8f1c55a382e5d5/eventmesh-protocol-plugin/eventmesh-protocol-meshmessage/src/main/java/org/apache/eventmesh/protocol/meshmessage/MeshMessageProtocolAdaptor.java#L131
   
   If `cloudEvent.getData()` is null, the method will be return in line 129.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] Alonexc commented on issue #3471: [Enhancement] Method invocation may produce NPE[MeshMessageProtocolAdaptor]

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on issue #3471:
URL: https://github.com/apache/eventmesh/issues/3471#issuecomment-1518907163

   Yes, I will close this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] Alonexc closed issue #3471: [Enhancement] Method invocation may produce NPE[MeshMessageProtocolAdaptor]

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc closed issue #3471: [Enhancement] Method invocation may produce NPE[MeshMessageProtocolAdaptor]
URL: https://github.com/apache/eventmesh/issues/3471


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org