[GitHub] [accumulo] keith-turner commented on a change in pull request #1586: Fix for #1578

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #1586: Fix for #1578
URL: https://github.com/apache/accumulo/pull/1586#discussion_r408150853
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/util/Admin.java
 ##########
 @@ -275,6 +277,8 @@ public void execute(final String[] args) {
     } catch (Exception e) {
       log.error("{}", e.getMessage(), e);
       System.exit(3);
+    } finally {
+      SingletonManager.setMode(Mode.CLOSED);
 
 Review comment:
   > Does this prevent this code from being called from a process that might have other Accumulo client Connectors?
   
   Yes I think it would.  I don't think this situation happens currently.  If it ever did in the future, a clear error message would occur making it easy to track down.  Since this not public API, its always easy to change this code later if the hypothetical situation does happen.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services