You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "nickva (via GitHub)" <gi...@apache.org> on 2023/05/20 16:29:38 UTC
[GitHub] [couchdb] nickva opened a new pull request, #4608: Add a few more commit and query engine metrics
nickva opened a new pull request, #4608:
URL: https://github.com/apache/couchdb/pull/4608
fsync times can vary widely, especially on a remote block storage, so add a histogram and count for fsync calls. At a higher level, we can coalesce similar update doc requests from multiple clients, so add metrics to track that as well.
Improving couch_proc_manager, and experimenting with quickjs js engine [1], noticed we lacked metrics in that area. Add metrics to track query process acquires, start/stops (including crashes) as well as how many prompt and prompt errors we have. These should help gain some confidence when upgrading to a new engine version or engine type by comparng the before and after metrics output.
Trying to test some of these new metrics, noticed couch_file tests did most of the test logic in the setup part, which resulted in plenty of log noise during the test runs about started/stopped applications, so updated a few tests which were affected by this PR to use the ?TDEF_FE macro. That should make test output a bit smaller and neater.
[1] https://github.com/apache/couchdb/issues/4448#issuecomment-1447196423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva merged pull request #4608: Add a few more commit and query engine metrics
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva merged PR #4608:
URL: https://github.com/apache/couchdb/pull/4608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] pgj commented on a diff in pull request #4608: Add a few more commit and query engine metrics
Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #4608:
URL: https://github.com/apache/couchdb/pull/4608#discussion_r1199641682
##########
src/couch/priv/stats_descriptions.cfg:
##########
@@ -290,6 +302,30 @@
{type, histogram},
{desc, <<"duration of validate_doc_update function calls">>}
]}.
+{[couchdb, query_server, acquired_processes], [
+ {type, counter},
+ {desc, <<"number of acquired external processes">>}
+]}.
+{[couchdb, query_server, process_starts], [
+ {type, counter},
+ {desc, <<"number of os process starts">>}
Review Comment:
Does "os" refer to the operating system here? If yes, it should be spelled as "OS" instead -- I see that the format allows using abbreviations like that (e.g. LRU).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] rnewson commented on a diff in pull request #4608: Add a few more commit and query engine metrics
Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on code in PR #4608:
URL: https://github.com/apache/couchdb/pull/4608#discussion_r1199644913
##########
src/couch/priv/stats_descriptions.cfg:
##########
@@ -290,6 +302,30 @@
{type, histogram},
{desc, <<"duration of validate_doc_update function calls">>}
]}.
+{[couchdb, query_server, acquired_processes], [
+ {type, counter},
+ {desc, <<"number of acquired external processes">>}
+]}.
+{[couchdb, query_server, process_starts], [
+ {type, counter},
+ {desc, <<"number of os process starts">>}
Review Comment:
it does, and agree OS would be clearer, unless existing stats say "os".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a diff in pull request #4608: Add a few more commit and query engine metrics
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #4608:
URL: https://github.com/apache/couchdb/pull/4608#discussion_r1199648230
##########
src/couch/priv/stats_descriptions.cfg:
##########
@@ -290,6 +302,30 @@
{type, histogram},
{desc, <<"duration of validate_doc_update function calls">>}
]}.
+{[couchdb, query_server, acquired_processes], [
+ {type, counter},
+ {desc, <<"number of acquired external processes">>}
+]}.
+{[couchdb, query_server, process_starts], [
+ {type, counter},
+ {desc, <<"number of os process starts">>}
Review Comment:
Good point. It was OS at first, but then I noticed the surrounding descriptions were all lower-cased so went with that pattern, higher up in the file we do have a few "HTTP" and "CouchDB" so "OS" would work. I'll change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] pgj commented on a diff in pull request #4608: Add a few more commit and query engine metrics
Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #4608:
URL: https://github.com/apache/couchdb/pull/4608#discussion_r1199641682
##########
src/couch/priv/stats_descriptions.cfg:
##########
@@ -290,6 +302,30 @@
{type, histogram},
{desc, <<"duration of validate_doc_update function calls">>}
]}.
+{[couchdb, query_server, acquired_processes], [
+ {type, counter},
+ {desc, <<"number of acquired external processes">>}
+]}.
+{[couchdb, query_server, process_starts], [
+ {type, counter},
+ {desc, <<"number of os process starts">>}
Review Comment:
Does "os" refer to the operating system here? If yes, it should be spelled as "OS" instead -- I see that the format allows using abbreviations like that (e.g. LRU)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org