[GitHub] [spark] LuciferYang commented on a diff in pull request #41671: [SPARK-44104][BUILD] Enabled `protobuf` module mima check for Spark 3.5.0

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #41671:
URL: https://github.com/apache/spark/pull/41671#discussion_r1234837563


##########
project/MimaExcludes.scala:
##########
@@ -93,6 +93,10 @@ object MimaExcludes {
     ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.ErrorInfo$"),
     ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.ErrorSubInfo$"),
 
+    // SPARK-44104: shaded protobuf code and Apis with parameters relocated
+    ProblemFilters.exclude[Problem]("org.sparkproject.spark_protobuf.protobuf.*"),
+    ProblemFilters.exclude[Problem]("org.apache.spark.sql.protobuf.utils.SchemaConverters.*"),
+

Review Comment:
   For example,
   
   https://github.com/apache/spark/blob/6b36a9368d6e97f7f1f94c4ca7f6ee76dcd0015f/connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/utils/SchemaConverters.scala#L65-L68
   
   `FieldDescriptor` already be relocated  in 3.4.0 protobuf.jar, so it's not possible to perform a mima check now
   
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org