You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "1fanwang (via GitHub)" <gi...@apache.org> on 2026/09/11 23:19:57 UTC
[PR] ui: show project instance volumes in default view [cloudstack]
1fanwang opened a new pull request, #14158:
URL: https://github.com/apache/cloudstack/pull/14158
### Description
Opening a project instance from Default view shows an empty Volumes tab even though its disks exist. The tab now includes accessible project resources while keeping the instance ID filter, so the disks appear without switching projects.
Fixes: https://github.com/apache/cloudstack/issues/14070
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
The reproduction checks the rendered table rows; the layout is unchanged.
### How Has This Been Tested?
The committed regression mounts Vue against a local HTTP fixture with CloudStack's project filtering. It exercises the API client, Axios project selection, and rendered rows without replacing those functions.
I also ran the mounted tab against CloudStack 4.22.1.0 with real MySQL and API-created instances on its Simulator hypervisor. The [live reproduction and logs](https://gist.github.com/73c9a09f40ae15eae5f29a5c5957d28b) cover that run.
| # | Scenario | Command | Result |
|---|---|---|---|
| 1 | Project instance in Default view | Command below, before fix | Zero rendered rows |
| 2 | Same component after fix | Same command | Root and data disks |
<details><summary>Raw logs</summary>
From `ui`; the test and its HTTP fixture are both in this diff:
```sh
npm run test:unit -- --runInBand --coverage=false --verbose tests/unit/components/view/VolumesTab.spec.js
```
Before:
```text
Expected length: 2
Received length: 0
Received array: []
```
After:
```text
β shows volume rows for project instance in Default view (40ms)
Tests: 8 passed, 8 total
```
</details>
#### How did you try to break this feature and the system with this change?
I also selected a different project and exercised account and system VMs. Regression cases cover disk order and prefetched rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: show project instance volumes in default view [cloudstack]
Posted by "RosiKyu (via GitHub)" <gi...@apache.org>.
RosiKyu commented on PR #14158:
URL: https://github.com/apache/cloudstack/pull/14158#issuecomment-5913556149
@1fanwang could you please request a review for this PR so we can potentially review,test and get this into 24.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: show project instance volumes in default view [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14158:
URL: https://github.com/apache/cloudstack/pull/14158#issuecomment-6513018013
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/14158 (QA-JID-1002)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: show project instance volumes in default view [cloudstack]
Posted by "DaanHoogland (via GitHub) via commits" <co...@cloudstack.apache.org>.
DaanHoogland commented on PR #14158:
URL: https://github.com/apache/cloudstack/pull/14158#issuecomment-6639855236
@1fanwang @RosiKyu @nvazquez I am adding #14581 that targets 4.20 and includes all fixes here. Can we close this in favour of that? it also addresses #14572 and #14573.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: show project instance volumes in default view [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #14158:
URL: https://github.com/apache/cloudstack/pull/14158#discussion_r4387515702
##########
ui/src/components/view/VolumesTab.vue:
##########
@@ -132,7 +132,7 @@ export default {
}
},
getVolumes () {
- getAPI('listVolumes', { listall: true, listsystemvms: true, virtualmachineid: this.vm.id }).then(json => {
+ getAPI('listVolumes', { listall: true, listsystemvms: true, projectid: '-1', virtualmachineid: this.vm.id }).then(json => {
Review Comment:
@Damans227 you tested right? (clgtm)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: show project instance volumes in default view [cloudstack]
Posted by "1fanwang (via GitHub) via commits" <co...@cloudstack.apache.org>.
1fanwang commented on PR #14158:
URL: https://github.com/apache/cloudstack/pull/14158#issuecomment-6768038816
> Can we close this in favour of that?
Yes, I have closed this in favour of https://github.com/apache/cloudstack/pull/14581.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: show project instance volumes in default view [cloudstack]
Posted by "Damans227 (via GitHub)" <gi...@apache.org>.
Damans227 commented on code in PR #14158:
URL: https://github.com/apache/cloudstack/pull/14158#discussion_r4259395884
##########
ui/src/components/view/VolumesTab.vue:
##########
@@ -132,7 +132,7 @@ export default {
}
},
getVolumes () {
- getAPI('listVolumes', { listall: true, listsystemvms: true, virtualmachineid: this.vm.id }).then(json => {
+ getAPI('listVolumes', { listall: true, listsystemvms: true, projectid: '-1', virtualmachineid: this.vm.id }).then(json => {
Review Comment:
can we send the vm's own projectid only when it has one? with -1 a domain admin looking at another user's vm in their domain gets an empty tab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: show project instance volumes in default view [cloudstack]
Posted by "Damans227 (via GitHub)" <gi...@apache.org>.
Damans227 commented on code in PR #14158:
URL: https://github.com/apache/cloudstack/pull/14158#discussion_r4260226609
##########
ui/src/components/view/VolumesTab.vue:
##########
@@ -132,7 +132,7 @@ export default {
}
},
getVolumes () {
- getAPI('listVolumes', { listall: true, listsystemvms: true, virtualmachineid: this.vm.id }).then(json => {
+ getAPI('listVolumes', { listall: true, listsystemvms: true, projectid: '-1', virtualmachineid: this.vm.id }).then(json => {
Review Comment:
that covers it, the tab now sends the vm's own project in 7e0ef8e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: show project instance volumes in default view [cloudstack]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #14158:
URL: https://github.com/apache/cloudstack/pull/14158#issuecomment-5641746184
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:
- In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
- Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
- Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
- Please follow [ASF Code of Conduct](https://github.com/apache/.github/blob/main/.github/CODE_OF_CONDUCT.md) for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
- Be sure to read the [CloudStack Coding Conventions](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions).
Apache CloudStack is a community-driven project and together we are making it better π.
In case of doubts contact the developers at:
Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
Slack: https://apachecloudstack.slack.com/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: show project instance volumes in default view [cloudstack]
Posted by "1fanwang (via GitHub)" <gi...@apache.org>.
1fanwang commented on PR #14158:
URL: https://github.com/apache/cloudstack/pull/14158#issuecomment-5944341425
> @1fanwang could you please request a review for this PR so we can potentially review,test and get this into 24.0?
@RosiKyu I tried, but GitHub only lets committers request reviewers on apache/cloudstack, so the request fails from my account. Could you add yourself or whoever owns the UI? The PR is ready, and the test and its HTTP fixture are in the diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: show project instance volumes in default view [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #14158:
URL: https://github.com/apache/cloudstack/pull/14158#issuecomment-6512707657
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: show project instance volumes in default view [cloudstack]
Posted by "1fanwang (via GitHub) via commits" <co...@cloudstack.apache.org>.
1fanwang closed pull request #14158: ui: show project instance volumes in default view
URL: https://github.com/apache/cloudstack/pull/14158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: show project instance volumes in default view [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #14158:
URL: https://github.com/apache/cloudstack/pull/14158#issuecomment-6439462648
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/14158?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 4.09%. Comparing base ([`9030443`](https://app.codecov.io/gh/apache/cloudstack/commit/9030443eac555c26b06bbf8e82249f2aac385fcc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7e0ef8e`](https://app.codecov.io/gh/apache/cloudstack/commit/7e0ef8ec8684ce9e6e7d4f629adf46eb39f6ff88?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 59 commits behind head on 4.22.
> :exclamation: There is a different number of reports uploaded between BASE (9030443) and HEAD (7e0ef8e). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (9030443) | HEAD (7e0ef8e) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.22 #14158 +/- ##
=============================================
- Coverage 17.94% 4.09% -13.85%
=============================================
Files 5928 449 -5479
Lines 535174 38283 -496891
Branches 65494 7082 -58412
=============================================
- Hits 96019 1569 -94450
+ Misses 428226 36500 -391726
+ Partials 10929 214 -10715
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/14158/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/14158/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.09% <ΓΈ> (+0.07%)` | :arrow_up: |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/14158/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/cloudstack/pull/14158?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: show project instance volumes in default view [cloudstack]
Posted by "Damans227 (via GitHub)" <gi...@apache.org>.
Damans227 commented on code in PR #14158:
URL: https://github.com/apache/cloudstack/pull/14158#discussion_r4388364056
##########
ui/src/components/view/VolumesTab.vue:
##########
@@ -132,7 +132,7 @@ export default {
}
},
getVolumes () {
- getAPI('listVolumes', { listall: true, listsystemvms: true, virtualmachineid: this.vm.id }).then(json => {
+ getAPI('listVolumes', { listall: true, listsystemvms: true, projectid: '-1', virtualmachineid: this.vm.id }).then(json => {
Review Comment:
no, i only read the code. @1fanwang can you test it and post a screenshot of the volumes tab for a project vm opened from the default view?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: show project instance volumes in default view [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #14158:
URL: https://github.com/apache/cloudstack/pull/14158#issuecomment-6512721256
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ui: show project instance volumes in default view [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #14158:
URL: https://github.com/apache/cloudstack/pull/14158#issuecomment-6512713203
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org