You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Igor Galić <i....@brainsware.org> on 2013/04/20 12:41:22 UTC
Re: [6/6] git commit: TS-1820 Cleanup the comments some, and
eliminate a few unused parameters where it was obvious
----- Original Message -----
> TS-1820 Cleanup the comments some, and eliminate a few unused
> parameters where it was obvious
[snip]
> //----------------------------------------------------------------------------
> void
> -TSPluginInit(int, const char *[]) // UNUSED int argc, const char *argv[]
> +TSPluginInit(int /* argc ATS_UNUSED */, const char */* argv ATS_UNUSED */[])
> {
> global_contp = TSContCreate(cache_print_plugin, TSMutexCreate());
> TSHttpHookAdd(TS_HTTP_READ_REQUEST_HDR_HOOK, global_contp);
I'm confused, I thought that's the way to pass parameters to a plugin via the config.
Has Phil taught me wrong?
-- i
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
Re: [6/6] git commit: TS-1820 Cleanup the comments some, and eliminate
a few unused parameters where it was obvious
Posted by Leif Hedstrom <zw...@apache.org>.
On 4/20/13 4:41 AM, Igor Galić wrote:
>
> ----- Original Message -----
>> TS-1820 Cleanup the comments some, and eliminate a few unused
>> parameters where it was obvious
> [snip]
>> //----------------------------------------------------------------------------
>> void
>> -TSPluginInit(int, const char *[]) // UNUSED int argc, const char *argv[]
>> +TSPluginInit(int /* argc ATS_UNUSED */, const char */* argv ATS_UNUSED */[])
>> {
>> global_contp = TSContCreate(cache_print_plugin, TSMutexCreate());
>> TSHttpHookAdd(TS_HTTP_READ_REQUEST_HDR_HOOK, global_contp);
>
> I'm confused, I thought that's the way to pass parameters to a plugin via the config.
> Has Phil taught me wrong?
No why? This plugin simply isn't using the arguments.
-- Leif