You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/10 00:51:37 UTC
[GitHub] [beam] boyuanzz opened a new pull request #11373: [BEAM-9562]
Update Element.timer to Element.timers
boyuanzz opened a new pull request #11373: [BEAM-9562] Update Element.timer to Element.timers
URL: https://github.com/apache/beam/pull/11373
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11373: [BEAM-9562] Update
Element.timer to Element.timers
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11373: [BEAM-9562] Update Element.timer to Element.timers
URL: https://github.com/apache/beam/pull/11373#issuecomment-611839103
please regenerate the go protos
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] boyuanzz commented on a change in pull request #11373:
[BEAM-9562] Update Element.timer and Element.Timer to Element.timers and
Element.Timers
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on a change in pull request #11373: [BEAM-9562] Update Element.timer and Element.Timer to Element.timers and Element.Timers
URL: https://github.com/apache/beam/pull/11373#discussion_r406921308
##########
File path: sdks/go/pkg/beam/model/pipeline_v1/beam_runner_api.pb.go
##########
@@ -6242,11 +6289,11 @@ var fileDescriptor_cf57597c3a9659a9 = []byte{
// Reference imports to suppress errors if they are not otherwise used.
var _ context.Context
-var _ grpc.ClientConn
+var _ grpc.ClientConnInterface
Review comment:
It's fixed by following https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/model/PROTOBUF.md#generated-go-code-fails-to-build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on a change in pull request #11373:
[BEAM-9562] Update Element.timer to Element.timers
Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #11373: [BEAM-9562] Update Element.timer to Element.timers
URL: https://github.com/apache/beam/pull/11373#discussion_r406567717
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -516,7 +516,7 @@ message Elements {
repeated Data data = 1;
// (Optional) A list of timer byte streams.
- repeated Timer timer = 2;
+ repeated Timer timers = 2;
Review comment:
@robertwb did you want to rename this field or the proto message Timer -> Timers or both?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] boyuanzz commented on a change in pull request #11373:
[BEAM-9562] Update Element.timer and Element.Timer to Element.timers and
Element.Timers
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on a change in pull request #11373: [BEAM-9562] Update Element.timer and Element.Timer to Element.timers and Element.Timers
URL: https://github.com/apache/beam/pull/11373#discussion_r406918619
##########
File path: sdks/go/pkg/beam/model/pipeline_v1/beam_runner_api.pb.go
##########
@@ -6242,11 +6289,11 @@ var fileDescriptor_cf57597c3a9659a9 = []byte{
// Reference imports to suppress errors if they are not otherwise used.
var _ context.Context
-var _ grpc.ClientConn
+var _ grpc.ClientConnInterface
Review comment:
@lostluck I'm not sure why this line and L6296 were changed. Do you have any idea?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] robertwb commented on a change in pull request #11373:
[BEAM-9562] Update Element.timer and Element.Timer to Element.timers and
Element.Timers
Posted by GitBox <gi...@apache.org>.
robertwb commented on a change in pull request #11373: [BEAM-9562] Update Element.timer and Element.Timer to Element.timers and Element.Timers
URL: https://github.com/apache/beam/pull/11373#discussion_r406912246
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -516,7 +516,7 @@ message Elements {
repeated Data data = 1;
// (Optional) A list of timer byte streams.
- repeated Timer timer = 2;
+ repeated Timer timers = 2;
Review comment:
Both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] boyuanzz merged pull request #11373: [BEAM-9562] Update
Element.timer and Element.Timer to Element.timers and Element.Timers
Posted by GitBox <gi...@apache.org>.
boyuanzz merged pull request #11373: [BEAM-9562] Update Element.timer and Element.Timer to Element.timers and Element.Timers
URL: https://github.com/apache/beam/pull/11373
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services