You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Appy (JIRA)" <ji...@apache.org> on 2016/06/03 03:22:59 UTC

[jira] [Commented] (HBASE-15845) Shell Cleanup : move formatter to commands.rb; move one of the two hbase.rb to hbase_constants.rb

    [ https://issues.apache.org/jira/browse/HBASE-15845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313520#comment-15313520 ] 

Appy commented on HBASE-15845:
------------------------------

I'll rebase the patch after first round of review in case something changed in shell code.

> Shell Cleanup : move formatter to commands.rb; move one of the two hbase.rb to hbase_constants.rb
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15845
>                 URL: https://issues.apache.org/jira/browse/HBASE-15845
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Appy
>            Priority: Minor
>         Attachments: HBASE-15845-master-v1.patch
>
>
> -  Renaming hbase.rb to hbase_constants.rb because there are two hbase.rb files right now which is confusing.
> - Remove omnipresence of formatter object since it is kind of a use-and-throw class. Commands should create
>       an instance, use it to format the output and discard it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)