You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/02/28 17:41:34 UTC
[GitHub] [tinkerpop] danielcweber opened a new pull request #1256: Reuse a
byte buffer instead of re-allocating it on every loop.
danielcweber opened a new pull request #1256: Reuse a byte buffer instead of re-allocating it on every loop.
URL: https://github.com/apache/tinkerpop/pull/1256
For large result sets, this will release a little bit of GC pressure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] spmallette commented on issue #1256: Reuse a byte
buffer instead of re-allocating it on every loop.
Posted by GitBox <gi...@apache.org>.
spmallette commented on issue #1256: Reuse a byte buffer instead of re-allocating it on every loop.
URL: https://github.com/apache/tinkerpop/pull/1256#issuecomment-594081740
> Should we maybe rename the inactive release branches (3.0-dev - 3.2-dev) to avoid confusion?
i'd say that most of the time, the problem is folks heading straight to `master` with their PR rather than to an older dev branch so i'm not sure we have a problem with inactive branches at this point. imo, i'd just leave them named as they are until we have a consistent problem with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] danielcweber commented on issue #1256: Reuse a byte
buffer instead of re-allocating it on every loop.
Posted by GitBox <gi...@apache.org>.
danielcweber commented on issue #1256: Reuse a byte buffer instead of re-allocating it on every loop.
URL: https://github.com/apache/tinkerpop/pull/1256#issuecomment-593424398
Seems that the data received from the test gremlin server got some extra fields (gremlin.pageRankVertexProgram.pageRank, gremlin.pageRankVertexProgram.edgeCount)
Expected: Dictionary<String, IList<Object>> [[age, System.Collections.Generic.List`1[System.Object]], [name, System.Collections.Generic.List`1[System.Object]]]
Actual: Dictionary<String, IList<Object>> [[name, System.Collections.Generic.List`1[System.Object]], [age, System.Collections.Generic.List`1[System.Object]], [gremlin.pageRankVertexProgram.pageRank, System.Collections.Generic.List`1[System.Object]], [gremlin.pageRankVertexProgram.edgeCount, System.Collections.Generic.List`1[System.Object]]]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] danielcweber commented on issue #1256: Reuse a byte
buffer instead of re-allocating it on every loop.
Posted by GitBox <gi...@apache.org>.
danielcweber commented on issue #1256: Reuse a byte buffer instead of re-allocating it on every loop.
URL: https://github.com/apache/tinkerpop/pull/1256#issuecomment-592662545
Failing test is unrelated and already failing on master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] danielcweber commented on issue #1256: Reuse a byte
buffer instead of re-allocating it on every loop.
Posted by GitBox <gi...@apache.org>.
danielcweber commented on issue #1256: Reuse a byte buffer instead of re-allocating it on every loop.
URL: https://github.com/apache/tinkerpop/pull/1256#issuecomment-593833417
Rebased, base branch changed to 3.3-dev.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] spmallette commented on issue #1256: Reuse a byte
buffer instead of re-allocating it on every loop.
Posted by GitBox <gi...@apache.org>.
spmallette commented on issue #1256: Reuse a byte buffer instead of re-allocating it on every loop.
URL: https://github.com/apache/tinkerpop/pull/1256#issuecomment-593537619
Is this meant for `master` branch? should it target something earlier?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] FlorianHockmann merged pull request #1256: Reuse a byte
buffer instead of re-allocating it on every loop.
Posted by GitBox <gi...@apache.org>.
FlorianHockmann merged pull request #1256: Reuse a byte buffer instead of re-allocating it on every loop.
URL: https://github.com/apache/tinkerpop/pull/1256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] danielcweber edited a comment on issue #1256: Reuse a
byte buffer instead of re-allocating it on every loop.
Posted by GitBox <gi...@apache.org>.
danielcweber edited a comment on issue #1256: Reuse a byte buffer instead of re-allocating it on every loop.
URL: https://github.com/apache/tinkerpop/pull/1256#issuecomment-593424398
Seems that the data received from the test gremlin server got some extra fields (gremlin.pageRankVertexProgram.pageRank, gremlin.pageRankVertexProgram.edgeCount)
So the difference of Travis vs. local machine is probably in the test server environment.
Expected: Dictionary<String, IList<Object>> [[age, System.Collections.Generic.List`1[System.Object]], [name, System.Collections.Generic.List`1[System.Object]]]
Actual: Dictionary<String, IList<Object>> [[name, System.Collections.Generic.List`1[System.Object]], [age, System.Collections.Generic.List`1[System.Object]], [gremlin.pageRankVertexProgram.pageRank, System.Collections.Generic.List`1[System.Object]], [gremlin.pageRankVertexProgram.edgeCount, System.Collections.Generic.List`1[System.Object]]]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] FlorianHockmann commented on issue #1256: Reuse a byte
buffer instead of re-allocating it on every loop.
Posted by GitBox <gi...@apache.org>.
FlorianHockmann commented on issue #1256: Reuse a byte buffer instead of re-allocating it on every loop.
URL: https://github.com/apache/tinkerpop/pull/1256#issuecomment-593831207
Our policy is to target the lowest still active release branch possible. We'll then merge a PR into that branch and afterwards merge that release branch into higher release branches and ultimately master. That way, a fix lands in all possible release branches.
In your case, `3.3-dev` should be the correct release branch as it already contains that code and because we stopped working on the `3.2-dev` branch.
@spmallette: Should we maybe rename the inactive release branches (`3.0-dev` - `3.2-dev`) to avoid confusion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] danielcweber commented on issue #1256: Reuse a byte
buffer instead of re-allocating it on every loop.
Posted by GitBox <gi...@apache.org>.
danielcweber commented on issue #1256: Reuse a byte buffer instead of re-allocating it on every loop.
URL: https://github.com/apache/tinkerpop/pull/1256#issuecomment-593540365
It's not fixing a bug or something urgent. Not sure what the criteria should be for it to target something earlier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services