You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Rob Weir <ap...@robweir.com> on 2011/06/24 20:26:59 UTC
Re: [PATCH] Corrected two typos on website
Good job, both.
My little mystery was trying to figure out why SVN was not letting me
apply the patch. Then I figured it out. The patch had already been
applied. ;-)
Perhaps a convention in the future would be that the committer who
wants to review and merge a patch first "claims" the patch on the
list, by responding to the [PATCH] note, saying "I have this one" or
something equivalent.
-Rob
On Fri, Jun 24, 2011 at 2:20 PM, Dick Groskamp <th...@quicknet.nl> wrote:
> Op 24-6-2011 20:18, Marcus (OOo) schreef:
>>
>> Thanks for the fix. :-)
>>
>> As I don't know yet how to add a patch to SVN, I've corrected the text
>> directly. I hope it's OK for you. Of course I've mentioned you in the commit
>> message.
>>
>> Marcus
>
> No problem. Just stumbled over them when I was playing with SVN.
> (I'm also on the learning curve like yourself I presume ;-) )
>
> --
> DiGro
>
> Windows 7 and OpenOffice.org 3.3
> Scanned with Ziggo uitgebreide Internetbeveiliging (F-Secure)
>
>
Re: [PATCH] Corrected two typos on website
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Is there a problem here that needs to be solved?
In my book one typo fix that got race conditioned doesn't qualify for
the p-word.
Rob Weir wrote on Fri, Jun 24, 2011 at 14:26:59 -0400:
> Good job, both.
>
> My little mystery was trying to figure out why SVN was not letting me
> apply the patch. Then I figured it out. The patch had already been
> applied. ;-)
>
> Perhaps a convention in the future would be that the committer who
> wants to review and merge a patch first "claims" the patch on the
> list, by responding to the [PATCH] note, saying "I have this one" or
> something equivalent.
>
> -Rob
>
> On Fri, Jun 24, 2011 at 2:20 PM, Dick Groskamp <th...@quicknet.nl> wrote:
> > Op 24-6-2011 20:18, Marcus (OOo) schreef:
> >>
> >> Thanks for the fix. :-)
> >>
> >> As I don't know yet how to add a patch to SVN, I've corrected the text
> >> directly. I hope it's OK for you. Of course I've mentioned you in the commit
> >> message.
> >>
> >> Marcus
> >
> > No problem. Just stumbled over them when I was playing with SVN.
> > (I'm also on the learning curve like yourself I presume ;-) )
> >
> > --
> > DiGro
> >
> > Windows 7 and OpenOffice.org 3.3
> > Scanned with Ziggo uitgebreide Internetbeveiliging (F-Secure)
> >
> >
Re: [PATCH] Corrected two typos on website
Posted by "Marcus (OOo)" <ma...@wtnet.de>.
I thought about this. But it was a 5 second thing, so I just did it and
said it then.
OK; next time the other way round. ;-)
Marcus
Am 06/24/2011 08:26 PM, schrieb Rob Weir:
> Good job, both.
>
> My little mystery was trying to figure out why SVN was not letting me
> apply the patch. Then I figured it out. The patch had already been
> applied. ;-)
>
> Perhaps a convention in the future would be that the committer who
> wants to review and merge a patch first "claims" the patch on the
> list, by responding to the [PATCH] note, saying "I have this one" or
> something equivalent.
>
> -Rob
>
> On Fri, Jun 24, 2011 at 2:20 PM, Dick Groskamp<th...@quicknet.nl> wrote:
>> Op 24-6-2011 20:18, Marcus (OOo) schreef:
>>>
>>> Thanks for the fix. :-)
>>>
>>> As I don't know yet how to add a patch to SVN, I've corrected the text
>>> directly. I hope it's OK for you. Of course I've mentioned you in the commit
>>> message.
>>>
>>> Marcus
>>
>> No problem. Just stumbled over them when I was playing with SVN.
>> (I'm also on the learning curve like yourself I presume ;-) )
>>
>> --
>> DiGro
>>
>> Windows 7 and OpenOffice.org 3.3
>> Scanned with Ziggo uitgebreide Internetbeveiliging (F-Secure)