[GitHub] [airflow] ferruzzi commented on a diff in pull request #23907: Light Refactor and Clean-up AWS Provider

[GitBox <gi...@apache.org>]

ferruzzi commented on code in PR #23907:
URL: https://github.com/apache/airflow/pull/23907#discussion_r881819741


##########
airflow/providers/amazon/aws/hooks/glue.py:
##########
@@ -74,7 +74,7 @@ def __init__(
                 raise ValueError("Cannot specify num_of_dpus with custom WorkerType")
         elif not worker_type_exists and num_workers_exists:
             raise ValueError("Need to specify custom WorkerType when specifying NumberOfWorkers")
-        elif worker_type_exists and not num_workers_exists:
+        elif worker_type_exists:

Review Comment:
   I might argue that while these are functionally the same, the old way was a little more clear about the intent.  Just a thought.



##########
tests/providers/amazon/aws/log/test_s3_task_handler.py:
##########
@@ -75,10 +76,8 @@ def setUp(self):
 
     def tearDown(self):
         if self.s3_task_handler.handler:
-            try:
+            with contextlib.suppress(Exception):

Review Comment:
   Oh.  That's a new one to me.  Nice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org