You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "Attyuttam (via GitHub)" <gi...@apache.org> on 2025/11/26 05:39:53 UTC

[PR] Fix 11312 [cloudstack]

Attyuttam opened a new pull request, #12136:
URL: https://github.com/apache/cloudstack/pull/12136

   ### Description
   
   This PR...
   improves the README.md file based on the suggestions provided
   
   <!--- ******************************************************************************* -->
   <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ******************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] Build/CI
   - [ ] Test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   ### Screenshots (if appropriate):
   
   ### How Has This Been Tested?
   
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   
   #### How did you try to break this feature and the system with this change?
   
   <!-- see how your change affects other areas of the code, etc. -->
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix 11312 [cloudstack]

Posted by "Attyuttam (via GitHub)" <gi...@apache.org>.
Attyuttam commented on PR #12136:
URL: https://github.com/apache/cloudstack/pull/12136#issuecomment-6460442781

   > Hi @Attyuttam can you please address the review comments?
   
   sure, I will incorporate them. Thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix 11312 [cloudstack]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12136:
URL: https://github.com/apache/cloudstack/pull/12136#issuecomment-4139607965

   This PR is stale because it has been open for 120 days with no activity. It may be removed by administrators of this project at any time. Remove the stale label or comment to request for removal of it to prevent this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix 11312 [cloudstack]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #12136:
URL: https://github.com/apache/cloudstack/pull/12136#issuecomment-3580233846

   ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/12136?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 3.58%. Comparing base ([`8171d95`](https://app.codecov.io/gh/apache/cloudstack/commit/8171d9568c941877e0290f77051ed45f31a73544?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06bfa2f`](https://app.codecov.io/gh/apache/cloudstack/commit/06bfa2f219a1dd6eebc936edfdc4f9fbd10ea603?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (8171d95) and HEAD (06bfa2f). Click for more details.
   > 
   > <details><summary>HEAD has 3 uploads less than BASE</summary>
   >
   >| Flag | BASE (8171d95) | HEAD (06bfa2f) |
   >|------|------|------|
   >|uitests|2|1|
   >|unittests|2|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##               main   #12136       +/-   ##
   =============================================
   - Coverage     17.56%    3.58%   -13.98%     
   =============================================
     Files          5912      445     -5467     
     Lines        529383    37536   -491847     
     Branches      64660     6901    -57759     
   =============================================
   - Hits          92984     1347    -91637     
   + Misses       425941    36025   -389916     
   + Partials      10458      164    -10294     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/12136/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/12136/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.58% <ø> (ø)` | |
   | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/12136/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/12136?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix 11312 [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12136:
URL: https://github.com/apache/cloudstack/pull/12136#issuecomment-4153486244

   @Attyuttam , if you are still interested in this, can you address the comments of Co-Pilot and either implement or refuse them with proper comments, please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix 11312 [cloudstack]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #12136:
URL: https://github.com/apache/cloudstack/pull/12136#discussion_r2563978638


##########
README.md:
##########
@@ -72,20 +84,46 @@ For more information on Apache CloudStack, please visit the [website](https://cl
 
 ## Who Uses CloudStack?
 
-* There are more than 150 known organizations using Apache CloudStack (or a commercial distribution of CloudStack). Our users include many major service providers running CloudStack to offer public cloud services, product vendors who incorporate or integrate with CloudStack in their own products, organizations who have used CloudStack to build their own private clouds, and systems integrators that offer CloudStack related services.
+*   **Trusted by Global Leaders**: CloudStack is the backbone of infrastructure for major service providers, telecom operators, and enterprises worldwide.
+    > "CloudStack has enabled us to scale our public cloud offering with ease and reliability." - *Major Cloud Provider*
 
-* See our [case studies](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Case+Studies) highlighting successful deployments of Apache CloudStack.
+*   **Diverse User Base**: Over 150 known organizations use Apache CloudStack, including:
+    *   [Apple](https://www.apple.com)
+    *   [Disney](https://www.disney.com)
+    *   [Huawei](https://www.huawei.com)
+    *   *...and many more.*

Review Comment:
   Listing specific company names like Apple, Disney, and Huawei without verification or sources is potentially problematic. Unless these companies have publicly confirmed they use CloudStack, this could be considered false advertising and could expose the project to legal issues. Either provide verified sources for these claims or remove the specific company names and rely on the existing "over 150 known organizations" statement with links to the official users page.
   ```suggestion
   *   **Diverse User Base**: Over 150 known organizations use Apache CloudStack. See the up-to-date list of current [users](https://cloudstack.apache.org/users.html).
   ```



##########
README.md:
##########
@@ -72,20 +84,46 @@ For more information on Apache CloudStack, please visit the [website](https://cl
 
 ## Who Uses CloudStack?
 
-* There are more than 150 known organizations using Apache CloudStack (or a commercial distribution of CloudStack). Our users include many major service providers running CloudStack to offer public cloud services, product vendors who incorporate or integrate with CloudStack in their own products, organizations who have used CloudStack to build their own private clouds, and systems integrators that offer CloudStack related services.
+*   **Trusted by Global Leaders**: CloudStack is the backbone of infrastructure for major service providers, telecom operators, and enterprises worldwide.
+    > "CloudStack has enabled us to scale our public cloud offering with ease and reliability." - *Major Cloud Provider*

Review Comment:
   The quote attributed to "Major Cloud Provider" is unverified and appears to be placeholder text. Using fabricated testimonials can damage credibility. Either use a real, attributed quote or remove this testimonial entirely.
   ```suggestion
   
   ```



##########
README.md:
##########
@@ -72,20 +84,46 @@ For more information on Apache CloudStack, please visit the [website](https://cl
 
 ## Who Uses CloudStack?
 
-* There are more than 150 known organizations using Apache CloudStack (or a commercial distribution of CloudStack). Our users include many major service providers running CloudStack to offer public cloud services, product vendors who incorporate or integrate with CloudStack in their own products, organizations who have used CloudStack to build their own private clouds, and systems integrators that offer CloudStack related services.
+*   **Trusted by Global Leaders**: CloudStack is the backbone of infrastructure for major service providers, telecom operators, and enterprises worldwide.
+    > "CloudStack has enabled us to scale our public cloud offering with ease and reliability." - *Major Cloud Provider*
 
-* See our [case studies](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Case+Studies) highlighting successful deployments of Apache CloudStack.
+*   **Diverse User Base**: Over 150 known organizations use Apache CloudStack, including:
+    *   [Apple](https://www.apple.com)
+    *   [Disney](https://www.disney.com)
+    *   [Huawei](https://www.huawei.com)
+    *   *...and many more.*
 
-* See the up-to-date list of current [users](https://cloudstack.apache.org/users.html).
+*   See our [case studies](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Case+Studies) highlighting successful deployments of Apache CloudStack.
 
-* If you are using CloudStack in your organization and your company is not listed above, please complete our brief adoption [survey](https://cloudstack.apache.org/survey.html). We're happy to keep your company name anonymous if you require.
+*   See the up-to-date list of current [users](https://cloudstack.apache.org/users.html).
 
-## Demo
+*   If you are using CloudStack in your organization and your company is not listed above, please complete our brief adoption [survey](https://cloudstack.apache.org/survey.html). We're happy to keep your company name anonymous if you require.
 
-![Screenshot](ui/docs/screenshot-dashboard.png)
 
-See the project user-interface QA website that runs CloudStack against simulator hypervisor:
-https://qa.cloudstack.cloud/simulator/ (admin:password)
+## Quick Start / Try It Now
+
+The easiest way to try CloudStack is using the all-in-one Docker container. This is for **evaluation purposes only**.
+
+1.  **Pull the Simulator Image**:
+    ```bash
+    docker pull apache/cloudstack-simulator
+    ```
+
+2.  **Run the Container**:
+    ```bash
+    docker run --name simulator -p 8080:5050 -d apache/cloudstack-simulator

Review Comment:
   The port mapping appears incorrect. The command maps host port 8080 to container port 5050 (`-p 8080:5050`), but typically CloudStack's management server runs on port 8080 inside the container. This could lead to connection issues. Verify the correct port mapping for the apache/cloudstack-simulator image, or update the documentation to reflect the actual ports used.
   ```suggestion
       docker run --name simulator -p 8080:8080 -d apache/cloudstack-simulator
   ```



##########
README.md:
##########
@@ -72,20 +84,46 @@ For more information on Apache CloudStack, please visit the [website](https://cl
 
 ## Who Uses CloudStack?
 
-* There are more than 150 known organizations using Apache CloudStack (or a commercial distribution of CloudStack). Our users include many major service providers running CloudStack to offer public cloud services, product vendors who incorporate or integrate with CloudStack in their own products, organizations who have used CloudStack to build their own private clouds, and systems integrators that offer CloudStack related services.
+*   **Trusted by Global Leaders**: CloudStack is the backbone of infrastructure for major service providers, telecom operators, and enterprises worldwide.
+    > "CloudStack has enabled us to scale our public cloud offering with ease and reliability." - *Major Cloud Provider*
 

Review Comment:
   [nitpick] The phrase "Trusted by Global Leaders" is marketing language that makes unsubstantiated claims. This heading should be more factual, such as "User Base" or simply removed in favor of the existing bullet points that follow.
   ```suggestion
   
   ```



##########
README.md:
##########
@@ -49,17 +52,26 @@
 
 <!-- END doctoc generated TOC please keep comment here to allow auto update -->
 
-Apache CloudStack is open source software designed to deploy and manage large
-networks of virtual machines, as a highly available, highly scalable
-Infrastructure as a Service (IaaS) cloud computing platform. CloudStack is used
-by a number of service providers to offer public cloud services, and by many
-companies to provide an on-premises (private) cloud offering, or as part of a
-hybrid cloud solution.
+Apache CloudStack empowers organizations to build and manage highly available, scalable, and secure private, public, and hybrid clouds with unparalleled ease. Transform your infrastructure into a flexible, on-demand service with CloudStack's comprehensive IaaS platform.

Review Comment:
   [nitpick] The marketing language "with unparalleled ease" is subjective and potentially exaggerated. Consider using more objective language such as "Apache CloudStack enables organizations to build and manage highly available, scalable, and secure private, public, and hybrid clouds" without the superlative claim.
   ```suggestion
   Apache CloudStack enables organizations to build and manage highly available, scalable, and secure private, public, and hybrid clouds. Transform your infrastructure into a flexible, on-demand service with CloudStack's comprehensive IaaS platform.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix 11312 [cloudstack]

Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #12136:
URL: https://github.com/apache/cloudstack/pull/12136#issuecomment-6459007366

   Hi @Attyuttam can you please address the review comments?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org