You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Paul Sundling <to...@tkz.net> on 2004/01/12 21:18:16 UTC
Checkstyle headers
I've created the a regular expression version of the license file and
did in fact find a bunch of inconsistencies with the license. Here are
the most popular ones:
starting at line 2: Don't have all the CVS variables like Revision,
Date and Header
starting at line 26: mispelled acknowledgement
starting at line 38: use of names (instead of name)
starting at line 39: Apache Group (instead of Apache Software Foundation)
starting at line 10: different copyright dates, including single years
and a variety of year combinations
All of these are pretty straightforward as far as how to fix them.
except for line 10. Would it be good to update all of them to have the
same date ranges (2000-2004) or just use a regular expression to account
for the combinations? I assume LICENSE.txt itself should be updated to
2004 in any case. Let me know ASAP which way to go and I'll have a
patch pronto. Since I've gone to all the trouble of a regexp version
of the license I may as well fix the problems. It seems to me that if
the license in the file is meant to represent the copyright dates of the
project, I should change the files. If the copyright dates are meant to
represent the individual files, then I should leave them alone.
So vote for :
1. regexp expression in CheckStyle.xml and leave dates alone in the
source files
2. update all the dates to the same range in the source files
Paul Sundling
P.S. Here are all the combinations for reference:
* Copyright (c) 1999-2001 The Apache Software Foundation. All rights
* Copyright (c) 1999-2001 The Apache Software Foundation. All rights
* Copyright (c) 1999-2002 The Apache Software Foundation. All rights
* Copyright (c) 1999-2003 The Apache Software Foundation.
All rights
* Copyright (c) 1999-2003 The Apache Software Foundation. All rights
* Copyright (c) 1999-2003 The Apache Software Foundation. All rights
* Copyright (c) 1999 The Apache Software Foundation. All rights
* Copyright (c) 1999 The Apache Software Foundation. All rights
* Copyright (c) 2000-2003 The Apache Software Foundation. All rights
* Copyright (c) 2000-2004 The Apache Software Foundation. All rights
* Copyright (c) 2001-2003 The Apache Software Foundation. All rights
* Copyright (c) 2002-2003 The Apache Software Foundation. All rights
* Copyright (c) 2003-2004 The Apache Software Foundation. All rights
* Copyright (c) 2003 The Apache Software Foundation. All rights
* Copyright (c) 2003 The Apache Software Foundation. All rights
* Copyright (c) 2003 The Apache Software Foundation. All rights
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: Checkstyle headers
Posted by Joe Germuska <Jo...@Germuska.com>.
>All of these are pretty straightforward as far as how to fix them.
>except for line 10. Would it be good to update all of them to have
>the same date ranges (2000-2004) or just use a regular expression to
>account for the combinations? I assume LICENSE.txt itself should be
>updated to 2004 in any case. Let me know ASAP which way to go and
>I'll have a patch pronto. Since I've gone to all the trouble of a
>regexp version of the license I may as well fix the problems. It
>seems to me that if the license in the file is meant to represent
>the copyright dates of the project, I should change the files. If
>the copyright dates are meant to represent the individual files,
>then I should leave them alone.
From my understanding, it would be incorrect to apply the same year
span to every file. The copyright dates are intended to reflect
reality more accurately.
This was discussed at length recently on another Jakarta list, but
unfortunately, I'm not turning up any references...
Joe
--
Joe Germuska
Joe@Germuska.com
http://blog.germuska.com
"Imagine if every Thursday your shoes exploded if you tied them
the usual way. This happens to us all the time with computers, and
nobody thinks of complaining."
-- Jef Raskin
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: Checkstyle headers
Posted by Paul Sundling <to...@tkz.net>.
A quick diff tells me that the failures I noticed directly relate to the
few minor changes that were made. So only the latest version of the
license had acknowledgement spelled right. :) I should have to only
change about 4 lines or so of the old licenses as you can see from the
diff (about same number of lines from a version 1.1) :
diff -r1.2 -r1.3
1c1,6
< /* ====================================================================
---
> /*
> * $Header: /home/cvspublic/jakarta-struts/LICENSE.txt,v 1.3
2003/08/23 02:54:37 rleland Exp $
> * $Revision: 1.3 $
> * $Date: 2003/08/23 02:54:37 $
> *
> * ====================================================================
5c10
< * Copyright (c) 1999-2003 The Apache Software Foundation. All rights
---
> * Copyright (c) 2000-2003 The Apache Software Foundation. All rights
20,21c25,26
< * 3. The end-user documentation included with the redistribution,
< * if any, must include the following acknowlegement:
---
> * 3. The end-user documentation included with the redistribution, if
> * any, must include the following acknowledgement:
33c38
< * nor may "Apache" appear in their names without prior written
---
> * nor may "Apache" appear in their name, without prior written
David Graham wrote:
>The copyright dates apply to each file so you can't just update all of
>them to read the same. Files containing "Apache Group" are not valid
>Apache 1.1 licenses and need to be fully replaced with a valid version.
>
>David
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: Checkstyle headers
Posted by David Graham <gr...@yahoo.com>.
The copyright dates apply to each file so you can't just update all of
them to read the same. Files containing "Apache Group" are not valid
Apache 1.1 licenses and need to be fully replaced with a valid version.
David
--- Paul Sundling <to...@tkz.net> wrote:
> I've created the a regular expression version of the license file and
> did in fact find a bunch of inconsistencies with the license. Here are
> the most popular ones:
>
> starting at line 2: Don't have all the CVS variables like Revision,
> Date and Header
> starting at line 26: mispelled acknowledgement
> starting at line 38: use of names (instead of name)
> starting at line 39: Apache Group (instead of Apache Software
> Foundation)
> starting at line 10: different copyright dates, including single years
> and a variety of year combinations
>
> All of these are pretty straightforward as far as how to fix them.
> except for line 10. Would it be good to update all of them to have the
> same date ranges (2000-2004) or just use a regular expression to account
>
> for the combinations? I assume LICENSE.txt itself should be updated to
> 2004 in any case. Let me know ASAP which way to go and I'll have a
> patch pronto. Since I've gone to all the trouble of a regexp version
> of the license I may as well fix the problems. It seems to me that if
> the license in the file is meant to represent the copyright dates of the
>
> project, I should change the files. If the copyright dates are meant to
>
> represent the individual files, then I should leave them alone.
>
> So vote for :
> 1. regexp expression in CheckStyle.xml and leave dates alone in the
> source files
> 2. update all the dates to the same range in the source files
>
> Paul Sundling
>
> P.S. Here are all the combinations for reference:
> * Copyright (c) 1999-2001 The Apache Software Foundation. All rights
> * Copyright (c) 1999-2001 The Apache Software Foundation. All rights
> * Copyright (c) 1999-2002 The Apache Software Foundation. All rights
> * Copyright (c) 1999-2003 The Apache Software Foundation.
> All rights
> * Copyright (c) 1999-2003 The Apache Software Foundation. All rights
> * Copyright (c) 1999-2003 The Apache Software Foundation. All rights
> * Copyright (c) 1999 The Apache Software Foundation. All rights
> * Copyright (c) 1999 The Apache Software Foundation. All rights
> * Copyright (c) 2000-2003 The Apache Software Foundation. All rights
> * Copyright (c) 2000-2004 The Apache Software Foundation. All rights
> * Copyright (c) 2001-2003 The Apache Software Foundation. All rights
> * Copyright (c) 2002-2003 The Apache Software Foundation. All rights
> * Copyright (c) 2003-2004 The Apache Software Foundation. All rights
> * Copyright (c) 2003 The Apache Software Foundation. All rights
> * Copyright (c) 2003 The Apache Software Foundation. All rights
> * Copyright (c) 2003 The Apache Software Foundation. All rights
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
__________________________________
Do you Yahoo!?
Yahoo! Hotjobs: Enter the "Signing Bonus" Sweepstakes
http://hotjobs.sweepstakes.yahoo.com/signingbonus
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org