You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/11 20:49:14 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request, #14997: [feat][pulsar-io] ElasticSearch Sink: option to disable SSL certificate validation
nicoloboschi opened a new pull request, #14997:
URL: https://github.com/apache/pulsar/pull/14997
### Motivation
There's no way at the moment to connect to a ElasticSearch cluster without checking the SSL certificate.
This is very useful in dev environments when you have to use secure connections.
### Modifications
* New option `disableCertificateValidation` that set the client to not verify ssl certificates. Default is false.
- [x] `doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #14997: [feat][pulsar-io] ElasticSearch Sink: option to disable SSL certificate validation
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #14997:
URL: https://github.com/apache/pulsar/pull/14997#issuecomment-1148792944
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi closed pull request #14997: [feat][pulsar-io] ElasticSearch Sink: option to disable SSL certificate validation
Posted by GitBox <gi...@apache.org>.
nicoloboschi closed pull request #14997: [feat][pulsar-io] ElasticSearch Sink: option to disable SSL certificate validation
URL: https://github.com/apache/pulsar/pull/14997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #14997: [feat][pulsar-io] ElasticSearch Sink: option to disable SSL certificate validation
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #14997:
URL: https://github.com/apache/pulsar/pull/14997#issuecomment-1087788777
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #14997: [feat][pulsar-io] ElasticSearch Sink: option to disable SSL certificate validation
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #14997:
URL: https://github.com/apache/pulsar/pull/14997#issuecomment-1117221688
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #14997: [feat][pulsar-io] ElasticSearch Sink: option to disable SSL certificate validation
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #14997:
URL: https://github.com/apache/pulsar/pull/14997#issuecomment-1087463293
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #14997: [feat][pulsar-io] ElasticSearch Sink: option to disable SSL certificate validation
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #14997:
URL: https://github.com/apache/pulsar/pull/14997#issuecomment-1090469720
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #14997: [feat][pulsar-io] ElasticSearch Sink: option to disable SSL certificate validation
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #14997:
URL: https://github.com/apache/pulsar/pull/14997#issuecomment-1106482676
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #14997: [feat][pulsar-io] ElasticSearch Sink: option to disable SSL certificate validation
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #14997:
URL: https://github.com/apache/pulsar/pull/14997#discussion_r856361426
##########
pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/client/RestClient.java:
##########
@@ -172,6 +173,9 @@ private SSLContext buildSslContext(ElasticSearchConfig config) throws NoSuchAlgo
sslContextBuilder.loadTrustMaterial(new File(sslConfig.getTruststorePath()),
sslConfig.getTruststorePassword().toCharArray());
}
+ if (sslConfig.isDisableCertificateValidation()) {
+ sslContextBuilder.loadTrustMaterial(null, TrustAllStrategy.INSTANCE);
Review Comment:
Please add logging at warning level when certification validation is disabled. Please address this for hostnameVerification too if there's no logging currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #14997: [feat][pulsar-io] ElasticSearch Sink: option to disable SSL certificate validation
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #14997:
URL: https://github.com/apache/pulsar/pull/14997#issuecomment-1117221820
@lhotari PTAL again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #14997: [feat][pulsar-io] ElasticSearch Sink: option to disable SSL certificate validation
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #14997:
URL: https://github.com/apache/pulsar/pull/14997#issuecomment-1128647889
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi merged pull request #14997: [feat][pulsar-io] ElasticSearch Sink: option to disable SSL certificate validation
Posted by GitBox <gi...@apache.org>.
nicoloboschi merged PR #14997:
URL: https://github.com/apache/pulsar/pull/14997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #14997: [feat][pulsar-io] ElasticSearch Sink: option to disable SSL certificate validation
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #14997:
URL: https://github.com/apache/pulsar/pull/14997#issuecomment-1098945395
@lhotari @michaeljmarshall @dlg99 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org