You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/31 21:42:49 UTC
[GitHub] [beam] lukecwik opened a new pull request, #22981: [fixes #22980] Migrate BeamFnLoggingClient to the new execution state sampler.
lukecwik opened a new pull request, #22981:
URL: https://github.com/apache/beam/pull/22981
This fixes the logging issue to include the transform id.
There is now a public unit test that will prevent a similar regression in the future.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #22981: [fixes #22980] Migrate BeamFnLoggingClient to the new execution state sampler.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22981:
URL: https://github.com/apache/beam/pull/22981#issuecomment-1233662787
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22981: [fixes #22980] Migrate BeamFnLoggingClient to the new execution state sampler.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22981:
URL: https://github.com/apache/beam/pull/22981#issuecomment-1233450797
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #22981: [fixes #22980] Migrate BeamFnLoggingClient to the new execution state sampler.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22981:
URL: https://github.com/apache/beam/pull/22981#issuecomment-1233702612
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #22981: [fixes #22980] Migrate BeamFnLoggingClient to the new execution state sampler.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22981:
URL: https://github.com/apache/beam/pull/22981#issuecomment-1233529839
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #22981: [fixes #22980] Migrate BeamFnLoggingClient to the new execution state sampler.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22981:
URL: https://github.com/apache/beam/pull/22981#issuecomment-1233492608
Run Python_PVR_Flink PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik merged pull request #22981: [fixes #22980] Migrate BeamFnLoggingClient to the new execution state sampler.
Posted by GitBox <gi...@apache.org>.
lukecwik merged PR #22981:
URL: https://github.com/apache/beam/pull/22981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #22981: [fixes #22980] Migrate BeamFnLoggingClient to the new execution state sampler.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22981:
URL: https://github.com/apache/beam/pull/22981#issuecomment-1233748838
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #22981: [fixes #22980] Migrate BeamFnLoggingClient to the new execution state sampler.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22981:
URL: https://github.com/apache/beam/pull/22981#issuecomment-1233449886
R: @y1chi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #22981: [fixes #22980] Migrate BeamFnLoggingClient to the new execution state sampler.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22981:
URL: https://github.com/apache/beam/pull/22981#issuecomment-1233473390
Run Python_PVR_Flink PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #22981: [fixes #22980] Migrate BeamFnLoggingClient to the new execution state sampler.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #22981:
URL: https://github.com/apache/beam/pull/22981#issuecomment-1233584069
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org