You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by brad <gi...@git.apache.org> on 2017/09/21 22:09:13 UTC
[GitHub] cordova-plugin-inappbrowser pull request #243: CB-5758: (android/ios) suppor...
GitHub user brad opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/243
CB-5758: (android/ios) support trusting self-signed certificates
### Platforms affected
Android,iOS
### What does this PR do?
Gives the ability to trust self-signed certificates
### What testing has been done on this change?
Used in a production app for 2 years
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/orcasgit/cordova-plugin-inappbrowser trust-ca
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/243.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #243
----
commit 3f3f70d7f15dd1b27f958784b17878bcfe19f8ce
Author: Brad Pitcher <br...@gmail.com>
Date: 2015-07-10T22:25:20Z
give the ability to trust a certificate authority
commit 3b0e6be630daef42bd0ba59e56af2cd70b4e560a
Author: Brad Pitcher <br...@gmail.com>
Date: 2016-08-15T16:03:20Z
enable adding trusted CA in iOS
commit 5aebef06bb2e3dc8a9d5cbf13f37f289e7f16a12
Author: Brad Pitcher <br...@gmail.com>
Date: 2017-09-21T22:08:14Z
undo unneeded description change
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #243: CB-5758: (android/ios) support trust...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/243
The SSL code in Cordova proper pre-dates the whitelist, so all it does is ignore the error and proceed with the SSL without validating the certificate. I'm pretty sure we actually don't want this behaviour going forward, and if we allow any self-signed certificate trusting in the future, it will be with a flag as described in CB-12232
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #243: CB-5758: (android/ios) suppor...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/243#discussion_r141401812
--- Diff: src/android/InAppBrowser.java ---
@@ -879,6 +910,48 @@ private void sendUpdate(JSONObject obj, boolean keepCallback, PluginResult.Statu
}
}
+ private void addTrustedCA() throws IOException, NoSuchAlgorithmException, CertificateException, KeyManagementException, KeyStoreException {
+ Log.d(LOG_TAG, "Adding trusted certificate if it exists");
--- End diff --
We use our own LOG, not the Android log. This is causing compile errors in Travis CI.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org