You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2023/09/07 12:23:00 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #42849: [WIP][SQL] Fix an internal error from `reflect()`on `NULL` class and method
MaxGekk opened a new pull request, #42849:
URL: https://github.com/apache/spark/pull/42849
### What changes were proposed in this pull request?
In the PR, I propose to check the `class` and `method` arguments is not a NULL in `CallMethodViaReflection`. And if it is, throw an `AnalysisException` with new error class `DATATYPE_MISMATCH.UNEXPECTED_NULL`.
### Why are the changes needed?
To fix the issue demonstrated by the example:
```sql
$
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
By running new test:
```
$ build/sbt "test:testOnly *.MiscFunctionsSuite"
```
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #42849: [SPARK-45100][SQL] Fix an internal error from `reflect()`on `NULL` class and method
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #42849:
URL: https://github.com/apache/spark/pull/42849#issuecomment-1711261272
Merging to master/3.5. The changes cause conflicts in `branch-3.4` and `branch-3.3`. I will open separate PRs for them.
Thank you, @dongjoon-hyun @HyukjinKwon @yaooqinn for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #42849: [SPARK-45100][SQL] Fix an internal error from `reflect()`on `NULL` class and method
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #42849:
URL: https://github.com/apache/spark/pull/42849#issuecomment-1711088219
All GAs passed already (see https://github.com/MaxGekk/spark/actions/runs/6110323188/job/16592857682).
@yaooqinn @dongjoon-hyun @peter-toth Could you look at the PR when you have time, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #42849: [SPARK-45100][SQL] Fix an internal error from `reflect()`on `NULL` class and method
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #42849: [SPARK-45100][SQL] Fix an internal error from `reflect()`on `NULL` class and method
URL: https://github.com/apache/spark/pull/42849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org