You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/08/14 22:08:36 UTC

Review Request 24712: Improve coverage in the end-to-end test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24712/
-----------------------------------------------------------

Review request for Aurora, David McLaughlin, Joe Smith, and Bill Farner.


Bugs: aurora-646
    https://issues.apache.org/jira/browse/aurora-646


Repository: aurora


Description
-------

Adds the following to the end-to-end:
- "config list"
- "job status"
- "job list" with partial key
- "job kill", both failing with no instance list, and killing a specific instance
- "job restart"


Diffs
-----

  src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 8e18e52d9d55e42e39683b43c4cfdd784cf8dbde 

Diff: https://reviews.apache.org/r/24712/diff/


Testing
-------


Thanks,

Mark Chu-Carroll


Re: Review Request 24712: Improve coverage in the end-to-end test.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24712/#review50627
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On Aug. 14, 2014, 8:09 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24712/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 8:09 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Joe Smith, and Bill Farner.
> 
> 
> Bugs: aurora-646
>     https://issues.apache.org/jira/browse/aurora-646
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adds the following to the end-to-end:
> - "config list"
> - "job status"
> - "job list" with partial key
> - "job kill", both failing with no instance list, and killing a specific instance
> - "job restart"
> 
> 
> Diffs
> -----
> 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 8e18e52d9d55e42e39683b43c4cfdd784cf8dbde 
> 
> Diff: https://reviews.apache.org/r/24712/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Re: Review Request 24712: Improve coverage in the end-to-end test.

Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24712/#review50629
-----------------------------------------------------------

Ship it!


Ship It!

- Joe Smith


On Aug. 14, 2014, 1:09 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24712/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 1:09 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Joe Smith, and Bill Farner.
> 
> 
> Bugs: aurora-646
>     https://issues.apache.org/jira/browse/aurora-646
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adds the following to the end-to-end:
> - "config list"
> - "job status"
> - "job list" with partial key
> - "job kill", both failing with no instance list, and killing a specific instance
> - "job restart"
> 
> 
> Diffs
> -----
> 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 8e18e52d9d55e42e39683b43c4cfdd784cf8dbde 
> 
> Diff: https://reviews.apache.org/r/24712/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Re: Review Request 24712: Improve coverage in the end-to-end test.

Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24712/#review50630
-----------------------------------------------------------

Ship it!


Ship It!

- David McLaughlin


On Aug. 14, 2014, 8:09 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24712/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 8:09 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Joe Smith, and Bill Farner.
> 
> 
> Bugs: aurora-646
>     https://issues.apache.org/jira/browse/aurora-646
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adds the following to the end-to-end:
> - "config list"
> - "job status"
> - "job list" with partial key
> - "job kill", both failing with no instance list, and killing a specific instance
> - "job restart"
> 
> 
> Diffs
> -----
> 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 8e18e52d9d55e42e39683b43c4cfdd784cf8dbde 
> 
> Diff: https://reviews.apache.org/r/24712/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Re: Review Request 24712: Improve coverage in the end-to-end test.

Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24712/
-----------------------------------------------------------

(Updated Aug. 14, 2014, 4:09 p.m.)


Review request for Aurora, David McLaughlin, Joe Smith, and Bill Farner.


Bugs: aurora-646
    https://issues.apache.org/jira/browse/aurora-646


Repository: aurora


Description
-------

Adds the following to the end-to-end:
- "config list"
- "job status"
- "job list" with partial key
- "job kill", both failing with no instance list, and killing a specific instance
- "job restart"


Diffs
-----

  src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 8e18e52d9d55e42e39683b43c4cfdd784cf8dbde 

Diff: https://reviews.apache.org/r/24712/diff/


Testing
-------


Thanks,

Mark Chu-Carroll