You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2017/01/05 14:49:11 UTC

Review Request 55212: When deleting services UI shows a lot of configs to be changing but none changes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55212/
-----------------------------------------------------------

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-19387
    https://issues.apache.org/jira/browse/AMBARI-19387


Repository: ambari


Description
-------

It appears that UI feedback shows the sum total of configs recommended by stack advisor even if only a subset of the configs are actually applied.


Diffs
-----

  ambari-web/app/controllers/main/service/info/configs.js b5538e0 
  ambari-web/app/controllers/main/service/item.js 8921e22 
  ambari-web/app/mixins/common/configs/enhanced_configs.js f92aac1 
  ambari-web/test/controllers/main/service/info/config_test.js a06ff8a 
  ambari-web/test/mixins/common/configs/enhanced_configs_test.js a9c9770 

Diff: https://reviews.apache.org/r/55212/diff/


Testing
-------

20129 tests complete (21 seconds)
  153 tests pending


Thanks,

Andriy Babiichuk


Re: Review Request 55212: When deleting services UI shows a lot of configs to be changing but none changes

Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55212/#review160588
-----------------------------------------------------------


Ship it!




Ship It!

- Oleg Nechiporenko


On \u042f\u043d\u0432. 5, 2017, 2:49 \u043f.\u043f., Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55212/
> -----------------------------------------------------------
> 
> (Updated \u042f\u043d\u0432. 5, 2017, 2:49 \u043f.\u043f.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-19387
>     https://issues.apache.org/jira/browse/AMBARI-19387
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> It appears that UI feedback shows the sum total of configs recommended by stack advisor even if only a subset of the configs are actually applied.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/info/configs.js b5538e0 
>   ambari-web/app/controllers/main/service/item.js 8921e22 
>   ambari-web/app/mixins/common/configs/enhanced_configs.js f92aac1 
>   ambari-web/test/controllers/main/service/info/config_test.js a06ff8a 
>   ambari-web/test/mixins/common/configs/enhanced_configs_test.js a9c9770 
> 
> Diff: https://reviews.apache.org/r/55212/diff/
> 
> 
> Testing
> -------
> 
> 20129 tests complete (21 seconds)
>   153 tests pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>