[GitHub] [pulsar] Jason918 commented on a diff in pull request #15957: [fix][tests] TieredStorageConfigurationTests - clear system properties

[GitBox <gi...@apache.org>]

Jason918 commented on code in PR #15957:
URL: https://github.com/apache/pulsar/pull/15957#discussion_r894974820


##########
tiered-storage/jcloud/src/test/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/TieredStorageConfigurationTests.java:
##########
@@ -217,9 +217,10 @@ public void overridePropertiesTest() {
         System.setProperty("jclouds.region", "jclouds-region");
         TieredStorageConfiguration config = new TieredStorageConfiguration(map);
         Properties properties = config.getOverrides();
-        System.out.println(properties.toString());
         assertEquals(properties.get("jclouds.region"), "jclouds-region");
         assertEquals(config.getServiceEndpoint(), "http://localhost");
         assertEquals(properties.get("jclouds.SystemPropertyA"), "A");
+        System.clearProperty("jclouds.SystemPropertyA");
+        System.clearProperty("jclouds.region");

Review Comment:
   Is it better to store the previous value and reset to original state here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org