You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/17 15:38:27 UTC
[GitHub] [airflow] davidcaron opened a new pull request #14278: Fix render_template method name in plugin example
davidcaron opened a new pull request #14278:
URL: https://github.com/apache/airflow/pull/14278
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #14278: Fix render_template method name in plugin example
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #14278:
URL: https://github.com/apache/airflow/pull/14278#issuecomment-782335274
Hi @davidcaron ! Sorry I think I made a mistake. I was at branch `v1-10-stable` when I checked the code and raised the question above ([the line I was talking about](https://github.com/apache/airflow/blob/v1-10-stable/tests/plugins/test_plugin.py#L80), if you are interested). It's not applicable in `master` branch. My bad, sorry for it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14278: Fix render_template method name in plugin example
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14278:
URL: https://github.com/apache/airflow/pull/14278#issuecomment-782336475
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #14278: Fix render_template method name in plugin example
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #14278:
URL: https://github.com/apache/airflow/pull/14278
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] davidcaron commented on pull request #14278: Fix render_template method name in plugin example
Posted by GitBox <gi...@apache.org>.
davidcaron commented on pull request #14278:
URL: https://github.com/apache/airflow/pull/14278#issuecomment-782287048
@XD-DENG I'm... not sure which issue you are referring to (mind pointing me to it?), but while looking for it I found another place where `render` was used.
The confusion seems to comes from:
ok:
`flask_appbuilder.BaseView.render_template`
`flask_admin.BaseView.render`
not ok:
`flask_appbuilder.BaseView.render`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] davidcaron commented on pull request #14278: Fix render_template method name in plugin example
Posted by GitBox <gi...@apache.org>.
davidcaron commented on pull request #14278:
URL: https://github.com/apache/airflow/pull/14278#issuecomment-780644883
Wow, not sure if it's something I'm doing, but I'm sorry for resquesting all these reviews! I thought it was the `gh` cli tool first...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14278: Fix render_template method name in plugin example
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #14278:
URL: https://github.com/apache/airflow/pull/14278#issuecomment-782369873
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org