You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/11/22 03:41:54 UTC

[GitHub] [hudi] leesf commented on a diff in pull request #7272: [MINOR] Use direct marker for spark when timeline server is disabled

leesf commented on code in PR #7272:
URL: https://github.com/apache/hudi/pull/7272#discussion_r1028797745


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -2794,7 +2794,11 @@ public HoodieWriteConfig build() {
     private String getDefaultMarkersType(EngineType engineType) {
       switch (engineType) {
         case SPARK:
-          return MarkerType.TIMELINE_SERVER_BASED.toString();
+          if (writeConfig.isEmbeddedTimelineServerEnabled()) {
+            return MarkerType.TIMELINE_SERVER_BASED.toString();
+          } else {
+            return MarkerType.DIRECT.toString();

Review Comment:
   we could log.warn here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org