Re: [PR] [cdc-cli][cdc-composer] Add 'flink-config' for pipeline yaml [flink-cdc]

["joyCurry30 (via GitHub)" <gi...@apache.org>]

joyCurry30 commented on code in PR #2837:
URL: https://github.com/apache/flink-cdc/pull/2837#discussion_r1513695037


##########
flink-cdc-cli/src/main/java/com/ververica/cdc/cli/parser/YamlPipelineDefinitionParser.java:
##########
@@ -43,6 +43,7 @@ public class YamlPipelineDefinitionParser implements PipelineDefinitionParser {
     private static final String SINK_KEY = "sink";
     private static final String ROUTE_KEY = "route";
     private static final String PIPELINE_KEY = "pipeline";
+    private static final String FLINK_CONFIG_KEY = "flink-config";

Review Comment:
   Sorry for the late reply. Yes, I agreed with you, we should not give users too much concept. But how do we distinguish which configs belong to flink config? Use "flink.config" as the prefix to distinguish?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org