You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/03 17:30:41 UTC
[GitHub] [arrow] davisusanibar commented on a diff in pull request #14472: ARROW-18042: [Java] Distribute Apple M1 compatible JNI libraries via mavencentral
davisusanibar commented on code in PR #14472:
URL: https://github.com/apache/arrow/pull/14472#discussion_r1013214353
##########
dev/tasks/java-jars/github.yml:
##########
@@ -122,39 +147,38 @@ jobs:
- build-cpp-windows
steps:
{{ macros.github_checkout_arrow(fetch_depth=0)|indent }}
- - name: Download Linux C++ Libraries
- uses: actions/download-artifact@v2
- with:
- name: ubuntu-shared-lib
- - name: Download macOS C++ libraries
- uses: actions/download-artifact@v2
- with:
- name: macos-shared-lib
- - name: Download Windows C++ libraries
- uses: actions/download-artifact@v2
+ - name: Download Libraries
+ uses: actions/download-artifact@v3
with:
- name: windows-shared-lib
- - name: Descompress artifacts
+ path: artifacts
+ - name: Decompress artifacts
run: |
+ mv artifacts/*/*.tar.gz .
tar -xvzf arrow-shared-libs-linux.tar.gz
- tar -xvzf arrow-shared-libs-macos.tar.gz
+ tar -xvzf arrow-shared-libs-macos-x86_64.tar.gz
+ tar -xvzf arrow-shared-libs-macos-aarch_64.tar.gz
tar -xvzf arrow-shared-libs-windows.tar.gz
- name: Test that shared libraries exist
run: |
set -x
- test -f arrow/java-dist/libarrow_cdata_jni.dylib
- test -f arrow/java-dist/libarrow_cdata_jni.so
- test -f arrow/java-dist/arrow_cdata_jni.dll
- test -f arrow/java-dist/libarrow_dataset_jni.dylib
- test -f arrow/java-dist/libarrow_dataset_jni.so
- test -f arrow/java-dist/arrow_dataset_jni.dll
- test -f arrow/java-dist/libarrow_orc_jni.dylib
- test -f arrow/java-dist/libarrow_orc_jni.so
- test -f arrow/java-dist/arrow_orc_jni.dll
- test -f arrow/java-dist/libgandiva_jni.dylib
- test -f arrow/java-dist/libgandiva_jni.so
- test -f arrow/java-dist/libplasma_java.dylib
- test -f arrow/java-dist/libplasma_java.so
+ test -f arrow/java-dist/x86_64/libarrow_orc_jni.so
+ test -f arrow/java-dist/x86_64/libarrow_cdata_jni.so
+ test -f arrow/java-dist/x86_64/libgandiva_jni.so
+ test -f arrow/java-dist/x86_64/libarrow_dataset_jni.so
+ test -f arrow/java-dist/x86_64/libplasma_java.so
+ test -f arrow/java-dist/x86_64/libarrow_cdata_jni.dylib
+ test -f arrow/java-dist/x86_64/libplasma_java.dylib
+ test -f arrow/java-dist/x86_64/libarrow_dataset_jni.dylib
+ test -f arrow/java-dist/x86_64/libgandiva_jni.dylib
+ test -f arrow/java-dist/x86_64/libarrow_orc_jni.dylib
+ test -f arrow/java-dist/aarch_64/libarrow_cdata_jni.dylib
+ test -f arrow/java-dist/aarch_64/libplasma_java.dylib
+ test -f arrow/java-dist/aarch_64/libarrow_dataset_jni.dylib
+ test -f arrow/java-dist/aarch_64/libgandiva_jni.dylib
+ test -f arrow/java-dist/aarch_64/libarrow_orc_jni.dylib
+ test -f arrow/java-dist/x86_64/arrow_cdata_jni.dll
+ test -f arrow/java-dist/x86_64/arrow_dataset_jni.dll
+ test -f arrow/java-dist/x86_64/arrow_orc_jni.dll
Review Comment:
Will be also needed change Java JNI projects on the way that them [load JNI libs](https://github.com/apache/arrow/blob/67f5ac879a41baadf6e52749750755cf150fcfe5/java/c/src/main/java/org/apache/arrow/c/jni/JniLoader.java#L80:L94) (i.e. Add `System.getProperty("os.arch") + ...`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org