You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by scottyaslan <gi...@git.apache.org> on 2016/07/25 14:37:13 UTC
[GitHub] nifi pull request #715: [NIFI-2367] Overlapping links repositioned on error/...
GitHub user scottyaslan opened a pull request:
https://github.com/apache/nifi/pull/715
[NIFI-2367] Overlapping links repositioned on error/login pages
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scottyaslan/nifi responsiveDevBranch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/715.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #715
----
commit 36afba65f5574275e072d1083610f9c8cbb2b630
Author: Scott Aslan <ja...@hortonworks.com>
Date: 2016-07-25T14:35:50Z
[NIFI-2367] Overlapping links repositioned on error/login pages
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #715: [NIFI-2367] [NIFI-2025] [NIFI-2107] [NIFI-2355] [NIFI-2027]...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/715
Looks great @scottyaslan! This has been merged to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #715: [NIFI-2367] [NIFI-2025] [NIFI-2107] [NIFI-2355] [NIF...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/715
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #715: [NIFI-2367] [NIFI-2025] [NIFI-2107] [NIFI-2355] [NIFI-2027]...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/715
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #715: [NIFI-2367] [NIFI-2025] [NIFI-2107] [NIFI-2355] [NIF...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/715#discussion_r72430022
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-canvas-utils.js ---
@@ -516,10 +516,12 @@ nf.CanvasUtils = (function () {
});
// update the tooltip background
- selection.select('rect.bulletin-background').classed('has-bulletins', true);
+ selection.select('text.bulletin-icon').style("visibility", "visible");
+ selection.select('rect.bulletin-background').style("visibility", "visible").classed('has-bulletins', true);
--- End diff --
With this proposed change we could remove the has-bulletins class and just integrate those styles into the base style of the bulletin-background since we're only ever showing it when it has bulletins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---