You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Svetlana Konovalova (JIRA)" <ji...@apache.org> on 2007/01/29 12:47:49 UTC

[jira] Created: (HARMONY-3072) [website] Harmony site improvement

[website] Harmony site improvement
----------------------------------

                 Key: HARMONY-3072
                 URL: https://issues.apache.org/jira/browse/HARMONY-3072
             Project: Harmony
          Issue Type: Improvement
          Components: Website/Documentation
            Reporter: Svetlana Konovalova
            Priority: Minor


Let's  make the site better to increase visualization and readability.
please, find the details on the wiki page: http://wiki.apache.org/harmony/Website_Improvement 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3072) [website] Harmony site improvement

Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478412 ] 

Alexey A. Ivanov commented on HARMONY-3072:
-------------------------------------------

Yeah! The site looks great now!
Thanks Nadya and Sveta.

> [website] Harmony site improvement
> ----------------------------------
>
>                 Key: HARMONY-3072
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3072
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Website/Documentation
>            Reporter: Svetlana Konovalova
>         Assigned To: Nadya Morozova
>            Priority: Minor
>         Attachments: H-3071.site.css.March5.patch, H3072-site.css.patch, H3072_with_improved_notes.patch
>
>
> Let's  make the site better to increase visualization and readability.
> please, find the details on the wiki page: http://wiki.apache.org/harmony/Website_Improvement 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3072) [website] Harmony site improvement

Posted by "Svetlana Konovalova (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Svetlana Konovalova updated HARMONY-3072:
-----------------------------------------

    Attachment: H3072_with_improved_notes.patch

Attaching  H3072_with_improved_notes.patch to increase note and notetext font-size

> [website] Harmony site improvement
> ----------------------------------
>
>                 Key: HARMONY-3072
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3072
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Website/Documentation
>            Reporter: Svetlana Konovalova
>         Assigned To: Nadya Morozova
>            Priority: Minor
>         Attachments: H3072-site.css.patch, H3072_with_improved_notes.patch
>
>
> Let's  make the site better to increase visualization and readability.
> please, find the details on the wiki page: http://wiki.apache.org/harmony/Website_Improvement 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3072) [website] Harmony site improvement

Posted by "Svetlana Konovalova (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Svetlana Konovalova updated HARMONY-3072:
-----------------------------------------

    Attachment: H-3071.site.css.March5.patch

Nadya, Alexey,
I've edited the file in the following way:
1)Removed commented out properties
2)Added "margin-left: 10pt;" to tables. Now they start at the same level as h2. IMHO looks nice.
3)As for the problem with the text not enclosed in <p>. AFAIS the problem is mainly with "strong" text that is heading 3 in xml files. IMHO it makes sense to add the following property (as i did):
strong 
{
    margin-left: 10pt;
}
what do you think? 

> [website] Harmony site improvement
> ----------------------------------
>
>                 Key: HARMONY-3072
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3072
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Website/Documentation
>            Reporter: Svetlana Konovalova
>         Assigned To: Nadya Morozova
>            Priority: Minor
>         Attachments: H-3071.site.css.March5.patch, H3072-site.css.patch, H3072_with_improved_notes.patch
>
>
> Let's  make the site better to increase visualization and readability.
> please, find the details on the wiki page: http://wiki.apache.org/harmony/Website_Improvement 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3072) [website] Harmony site improvement

Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478043 ] 

Alexey A. Ivanov commented on HARMONY-3072:
-------------------------------------------

Nadya,

* I think it's better to add 'margin' to tables so that they start at the same level as text.
* There's no way to fix this issue by applying stylerules. If you add margin or padding to body, everything will move but these text blocks will continue to be outdented. The only way to fix the problem I see is to wrap such text blocks into <p>, thus improving the overall markup. (Another option is to get rid of indentation at all.)

Also the patches should be cleaned up to remove all commented out properties which were left to simplify comparing while editing CSS file.

> [website] Harmony site improvement
> ----------------------------------
>
>                 Key: HARMONY-3072
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3072
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Website/Documentation
>            Reporter: Svetlana Konovalova
>         Assigned To: Nadya Morozova
>            Priority: Minor
>         Attachments: H3072-site.css.patch, H3072_with_improved_notes.patch
>
>
> Let's  make the site better to increase visualization and readability.
> please, find the details on the wiki page: http://wiki.apache.org/harmony/Website_Improvement 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3072) [website] Harmony site improvement

Posted by "Svetlana Konovalova (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469743 ] 

Svetlana Konovalova commented on HARMONY-3072:
----------------------------------------------

H3072_with_improved_notes.patch includes H3072-site.css.patch

> [website] Harmony site improvement
> ----------------------------------
>
>                 Key: HARMONY-3072
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3072
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Website/Documentation
>            Reporter: Svetlana Konovalova
>         Assigned To: Nadya Morozova
>            Priority: Minor
>         Attachments: H3072-site.css.patch, H3072_with_improved_notes.patch
>
>
> Let's  make the site better to increase visualization and readability.
> please, find the details on the wiki page: http://wiki.apache.org/harmony/Website_Improvement 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-3072) [website] Harmony site improvement

Posted by "Nadya Morozova (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nadya Morozova reassigned HARMONY-3072:
---------------------------------------

    Assignee: Nadya Morozova

> [website] Harmony site improvement
> ----------------------------------
>
>                 Key: HARMONY-3072
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3072
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Website/Documentation
>            Reporter: Svetlana Konovalova
>         Assigned To: Nadya Morozova
>            Priority: Minor
>
> Let's  make the site better to increase visualization and readability.
> please, find the details on the wiki page: http://wiki.apache.org/harmony/Website_Improvement 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-3072) [website] Harmony site improvement

Posted by "Nadya Morozova (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nadya Morozova resolved HARMONY-3072.
-------------------------------------

    Resolution: Fixed

thanks for creating and prompt fixes. I committed the final patched version at revision: 515088. please verify when the changes appear on website.
as for the outdented text that is not fixable, i agree - we should enclose it in containers for proper rendering. this can be addressed in a separate JIRA.


> [website] Harmony site improvement
> ----------------------------------
>
>                 Key: HARMONY-3072
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3072
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Website/Documentation
>            Reporter: Svetlana Konovalova
>         Assigned To: Nadya Morozova
>            Priority: Minor
>         Attachments: H-3071.site.css.March5.patch, H3072-site.css.patch, H3072_with_improved_notes.patch
>
>
> Let's  make the site better to increase visualization and readability.
> please, find the details on the wiki page: http://wiki.apache.org/harmony/Website_Improvement 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3072) [website] Harmony site improvement

Posted by "Nadya Morozova (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478041 ] 

Nadya Morozova commented on HARMONY-3072:
-----------------------------------------

I tried out the patch. looks really nice, am ready to commit except for the following:
- tables are too outdented now, let's add a padding so they start at the same level as text
- text not enclosed in <p> or any other block tags is outdented; let's add a padding to the body (?) element to make sure no lines stick out :) 

more suggestions welcome

> [website] Harmony site improvement
> ----------------------------------
>
>                 Key: HARMONY-3072
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3072
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Website/Documentation
>            Reporter: Svetlana Konovalova
>         Assigned To: Nadya Morozova
>            Priority: Minor
>         Attachments: H3072-site.css.patch, H3072_with_improved_notes.patch
>
>
> Let's  make the site better to increase visualization and readability.
> please, find the details on the wiki page: http://wiki.apache.org/harmony/Website_Improvement 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3072) [website] Harmony site improvement

Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey A. Ivanov updated HARMONY-3072:
--------------------------------------

    Attachment: H3072-site.css.patch

This the patch to CSS as discussed on the http://wiki.apache.org/harmony/Website_Improvement.
I used the site.css file at http://people.apache.org/~nadinem/docs/ as the base for the patch since that file incorporates my previous suggestions.

I removed some declarations which were commented out earlier.
I commented out all 'font-family' declarations and 'font-size' ones where absolute units were used.
Also I removed the redundant 'li' element from the selector where 'list-style-type' is changed.


Any comments, further suggestions are welcome.

> [website] Harmony site improvement
> ----------------------------------
>
>                 Key: HARMONY-3072
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3072
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Website/Documentation
>            Reporter: Svetlana Konovalova
>         Assigned To: Nadya Morozova
>            Priority: Minor
>         Attachments: H3072-site.css.patch
>
>
> Let's  make the site better to increase visualization and readability.
> please, find the details on the wiki page: http://wiki.apache.org/harmony/Website_Improvement 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-3072) [website] Harmony site improvement

Posted by "Nadya Morozova (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nadya Morozova closed HARMONY-3072.
-----------------------------------


change verified by submitter and an active contributor. thanks everyone for the  great work.

> [website] Harmony site improvement
> ----------------------------------
>
>                 Key: HARMONY-3072
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3072
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Website/Documentation
>            Reporter: Svetlana Konovalova
>         Assigned To: Nadya Morozova
>            Priority: Minor
>         Attachments: H-3071.site.css.March5.patch, H3072-site.css.patch, H3072_with_improved_notes.patch
>
>
> Let's  make the site better to increase visualization and readability.
> please, find the details on the wiki page: http://wiki.apache.org/harmony/Website_Improvement 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3072) [website] Harmony site improvement

Posted by "Svetlana Konovalova (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469725 ] 

Svetlana Konovalova commented on HARMONY-3072:
----------------------------------------------

Alexey,
 Thanks a lot for such a nice patch! I like the majority of your changes.
Remarks:
1)notetext font is too small and it that's why notes are hard-to-read, especially in italic.
i suggest to increase font size a little. what would you say?
2) Is it possible to decrease the whitespace between the end of the paragraph and the following note?

Upon the whole, I like the patch and IMHO it is worth being applied))



> [website] Harmony site improvement
> ----------------------------------
>
>                 Key: HARMONY-3072
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3072
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Website/Documentation
>            Reporter: Svetlana Konovalova
>         Assigned To: Nadya Morozova
>            Priority: Minor
>         Attachments: H3072-site.css.patch
>
>
> Let's  make the site better to increase visualization and readability.
> please, find the details on the wiki page: http://wiki.apache.org/harmony/Website_Improvement 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3072) [website] Harmony site improvement

Posted by "Svetlana Konovalova (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478389 ] 

Svetlana Konovalova commented on HARMONY-3072:
----------------------------------------------

Nadya, 
the changes are on the website already. i like the way it looks now.:)

 I agree with your outdented text proposal.

Thanks, 
Sveta

> [website] Harmony site improvement
> ----------------------------------
>
>                 Key: HARMONY-3072
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3072
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Website/Documentation
>            Reporter: Svetlana Konovalova
>         Assigned To: Nadya Morozova
>            Priority: Minor
>         Attachments: H-3071.site.css.March5.patch, H3072-site.css.patch, H3072_with_improved_notes.patch
>
>
> Let's  make the site better to increase visualization and readability.
> please, find the details on the wiki page: http://wiki.apache.org/harmony/Website_Improvement 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.