You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Cheolsoo Park (JIRA)" <ji...@apache.org> on 2012/10/22 23:46:14 UTC
[jira] [Created] (PIG-2998) Fix TestScriptLangunage
Cheolsoo Park created PIG-2998:
----------------------------------
Summary: Fix TestScriptLangunage
Key: PIG-2998
URL: https://issues.apache.org/jira/browse/PIG-2998
Project: Pig
Issue Type: Sub-task
Reporter: Cheolsoo Park
Assignee: Cheolsoo Park
Fix For: 0.11
This is a regression from PIG-2931.
I made changes so that $ signs in a replacement string get escaped by PreprocessorContext. But they shouldn't be escaped if they're already escaped.
In particular, TestScriptLanguage#bindLocalVariableTest2 is failing in trunk because $ signs are escaped by Pig#bind() and then escaped again by PreprocessorContext.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2998) Fix TestScriptLanguage and
TestMacroExpansion
Posted by "Jonathan Coveney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483469#comment-13483469 ]
Jonathan Coveney commented on PIG-2998:
---------------------------------------
+1. Committed. Thanks Cheolsoo!
> Fix TestScriptLanguage and TestMacroExpansion
> ---------------------------------------------
>
> Key: PIG-2998
> URL: https://issues.apache.org/jira/browse/PIG-2998
> Project: Pig
> Issue Type: Sub-task
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Fix For: 0.11
>
> Attachments: PIG-2998.patch
>
>
> This is a regression from PIG-2931.
> I made changes so that $ signs in a replacement string get escaped by PreprocessorContext. But they shouldn't be escaped if they're already escaped.
> In particular, TestScriptLanguage#bindLocalVariableTest2 is failing in trunk because $ signs are escaped by Pig#bind() and then escaped again by PreprocessorContext.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2998) Fix TestScriptLanguage and
TestMacroExpansion
Posted by "Jonathan Coveney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Coveney updated PIG-2998:
----------------------------------
Summary: Fix TestScriptLanguage and TestMacroExpansion (was: Fix TestScriptLangunage and TestMacroExpansion)
> Fix TestScriptLanguage and TestMacroExpansion
> ---------------------------------------------
>
> Key: PIG-2998
> URL: https://issues.apache.org/jira/browse/PIG-2998
> Project: Pig
> Issue Type: Sub-task
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Fix For: 0.11
>
> Attachments: PIG-2998.patch
>
>
> This is a regression from PIG-2931.
> I made changes so that $ signs in a replacement string get escaped by PreprocessorContext. But they shouldn't be escaped if they're already escaped.
> In particular, TestScriptLanguage#bindLocalVariableTest2 is failing in trunk because $ signs are escaped by Pig#bind() and then escaped again by PreprocessorContext.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2998) Fix TestScriptLangunage
Posted by "Cheolsoo Park (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cheolsoo Park updated PIG-2998:
-------------------------------
Status: Patch Available (was: Open)
> Fix TestScriptLangunage
> -----------------------
>
> Key: PIG-2998
> URL: https://issues.apache.org/jira/browse/PIG-2998
> Project: Pig
> Issue Type: Sub-task
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Fix For: 0.11
>
> Attachments: PIG-2998.patch
>
>
> This is a regression from PIG-2931.
> I made changes so that $ signs in a replacement string get escaped by PreprocessorContext. But they shouldn't be escaped if they're already escaped.
> In particular, TestScriptLanguage#bindLocalVariableTest2 is failing in trunk because $ signs are escaped by Pig#bind() and then escaped again by PreprocessorContext.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2998) Fix TestScriptLanguage and
TestMacroExpansion
Posted by "Jonathan Coveney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Coveney updated PIG-2998:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.12
Status: Resolved (was: Patch Available)
> Fix TestScriptLanguage and TestMacroExpansion
> ---------------------------------------------
>
> Key: PIG-2998
> URL: https://issues.apache.org/jira/browse/PIG-2998
> Project: Pig
> Issue Type: Sub-task
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Fix For: 0.11, 0.12
>
> Attachments: PIG-2998.patch
>
>
> This is a regression from PIG-2931.
> I made changes so that $ signs in a replacement string get escaped by PreprocessorContext. But they shouldn't be escaped if they're already escaped.
> In particular, TestScriptLanguage#bindLocalVariableTest2 is failing in trunk because $ signs are escaped by Pig#bind() and then escaped again by PreprocessorContext.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2998) Fix TestScriptLangunage and
TestMacroExpansion
Posted by "Cheolsoo Park (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cheolsoo Park updated PIG-2998:
-------------------------------
Summary: Fix TestScriptLangunage and TestMacroExpansion (was: Fix TestScriptLangunage)
> Fix TestScriptLangunage and TestMacroExpansion
> ----------------------------------------------
>
> Key: PIG-2998
> URL: https://issues.apache.org/jira/browse/PIG-2998
> Project: Pig
> Issue Type: Sub-task
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Fix For: 0.11
>
> Attachments: PIG-2998.patch
>
>
> This is a regression from PIG-2931.
> I made changes so that $ signs in a replacement string get escaped by PreprocessorContext. But they shouldn't be escaped if they're already escaped.
> In particular, TestScriptLanguage#bindLocalVariableTest2 is failing in trunk because $ signs are escaped by Pig#bind() and then escaped again by PreprocessorContext.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2998) Fix TestScriptLangunage
Posted by "Cheolsoo Park (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cheolsoo Park updated PIG-2998:
-------------------------------
Attachment: PIG-2998.patch
Attached is a patch that fixes the failing test.
I changed replaceAll() as follows:
{code}
val = val.replaceAll("(?<!\\\\)\\$", "\\\\\\$");
{code}
So only $ signs that are not already escaped get escaped now.
Testing done:
ant test-commit
ant test -Dtestcase=TestScriptLanange
ant test -Dtestcase=TestParamSubPreproc
Thanks!
> Fix TestScriptLangunage
> -----------------------
>
> Key: PIG-2998
> URL: https://issues.apache.org/jira/browse/PIG-2998
> Project: Pig
> Issue Type: Sub-task
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Fix For: 0.11
>
> Attachments: PIG-2998.patch
>
>
> This is a regression from PIG-2931.
> I made changes so that $ signs in a replacement string get escaped by PreprocessorContext. But they shouldn't be escaped if they're already escaped.
> In particular, TestScriptLanguage#bindLocalVariableTest2 is failing in trunk because $ signs are escaped by Pig#bind() and then escaped again by PreprocessorContext.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira