You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2017/09/08 11:20:00 UTC
[jira] [Created] (HADOOP-14851) LambdaTestUtils.eventually()
doesn't spin on Assertion failures
Steve Loughran created HADOOP-14851:
---------------------------------------
Summary: LambdaTestUtils.eventually() doesn't spin on Assertion failures
Key: HADOOP-14851
URL: https://issues.apache.org/jira/browse/HADOOP-14851
Project: Hadoop Common
Issue Type: Bug
Components: test
Affects Versions: 2.8.1
Reporter: Steve Loughran
Assignee: Steve Loughran
This is funny. The {{LsmbdaTestUtils.eventually()}} method, meant to spin until a closure stops raising exceptions, doesn't catch {{Error}} and subclasses, so doesn't fail on an {{Assert.assert()}} failure, which raises an {{AssertionError}}. My bad :)
Example:
{code}
eventually(TIMEOUT,
() -> {
while (counter.incrementAndGet() < 5) {
assert false : "oops";
}
},
retryLogic);
{code}
Fix: catch Throwable, rethrow. Needs to add VirtualMachineError & subclasses to the set of errors not to spin on (OOM, stack overflow, ...)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org