You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Venki Korukanti <ve...@gmail.com> on 2014/04/30 17:21:30 UTC
Review Request 20894: DRILL-438: Add support for Views (CREATE,
DROP and select)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20894/
-----------------------------------------------------------
Review request for drill.
Repository: drill-git
Description
-------
Currently views are session only. They don't persist across sessions. There is a know issue DRILL-595 where if you have * in view's select statement, projecting individual columns doesn't work properly.
Diffs
-----
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseSchemaFactory.java 991685c
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePlugin.java a82c6c3
exec/java-exec/src/main/codegen/data/Parser.tdd 4f47795
exec/java-exec/src/main/codegen/includes/parserImpls.ftl cd5ee72
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java ddc5025
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java 7e3b63d
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillViewTable.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java 8892a8f
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillSqlCall.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateView.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDescribeTable.java 24c2d03
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDropView.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowSchemas.java 526ae04
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowTables.java aad5ca5
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlUseSchema.java a48963e
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java f27317c
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/ViewStore.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java 64087f5
exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaFactory.java 60ccbe8
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java 7a88098
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPlugin.java 97427f6
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java 93bac0c
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java 1551e5a
exec/java-exec/src/main/java/org/apache/drill/exec/store/hive/HiveStoragePlugin.java e6df669
exec/java-exec/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java 3608ea7
exec/java-exec/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSchemaFactory.java 7b30a41
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaStoragePlugin.java 313ea86
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockStorageEngine.java 10f6e08
exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java a3a5647
exec/java-exec/src/test/java/org/apache/drill/TestTpchSingleMode.java 1ccb65c
exec/java-exec/src/test/java/org/apache/drill/exec/store/TestOrphanSchema.java d7e74cb
exec/java-exec/src/test/java/org/apache/drill/exec/store/ischema/OrphanSchema.java 1f1b367
exec/java-exec/src/test/resources/queries/tpch/15.sql 251631d
sqlparser/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java 148c115
Diff: https://reviews.apache.org/r/20894/diff/
Testing
-------
Added several unittests in TestJdbcQuery.
Thanks,
Venki Korukanti
Re: Review Request 20894: DRILL-438: Add support for Views (CREATE,
DROP and select)
Posted by Venki Korukanti <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20894/
-----------------------------------------------------------
(Updated May 3, 2014, 3:05 p.m.)
Review request for drill.
Changes
-------
Fixed a bug where the view was accepting only a subset of select statements.
Repository: drill-git
Description
-------
Currently views are session only. They don't persist across sessions. There is a know issue DRILL-595 where if you have * in view's select statement, projecting individual columns doesn't work properly.
Diffs (updated)
-----
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseSchemaFactory.java 991685c
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePlugin.java a82c6c3
exec/java-exec/src/main/codegen/data/Parser.tdd 4f47795
exec/java-exec/src/main/codegen/includes/parserImpls.ftl cd5ee72
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java ddc5025
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java 7e3b63d
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java f46f012
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillViewTable.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java 8892a8f
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillSqlCall.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateView.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDescribeTable.java 24c2d03
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDropView.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowSchemas.java 526ae04
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowTables.java aad5ca5
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlUseSchema.java a48963e
exec/java-exec/src/main/java/org/apache/drill/exec/planner/types/DrillFixedRelDataTypeImpl.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/types/RelDataTypeHolder.java 8bc746e
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java f27317c
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/ViewStore.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java 64087f5
exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaFactory.java 60ccbe8
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java 7a88098
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPlugin.java 97427f6
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java 93bac0c
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java 1551e5a
exec/java-exec/src/main/java/org/apache/drill/exec/store/hive/HiveStoragePlugin.java e6df669
exec/java-exec/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java 3608ea7
exec/java-exec/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSchemaFactory.java 7b30a41
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaStoragePlugin.java 313ea86
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockStorageEngine.java 10f6e08
exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java a3a5647
exec/java-exec/src/test/java/org/apache/drill/TestTpchSingleMode.java 1ccb65c
exec/java-exec/src/test/java/org/apache/drill/exec/store/TestOrphanSchema.java d7e74cb
exec/java-exec/src/test/java/org/apache/drill/exec/store/ischema/OrphanSchema.java 1f1b367
exec/java-exec/src/test/resources/queries/tpch/15.sql 251631d
sqlparser/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java 148c115
Diff: https://reviews.apache.org/r/20894/diff/
Testing
-------
Added several unittests in TestJdbcQuery.
Thanks,
Venki Korukanti
Re: Review Request 20894: DRILL-438: Add support for Views (CREATE,
DROP and select)
Posted by Venki Korukanti <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20894/
-----------------------------------------------------------
(Updated May 1, 2014, 6:04 a.m.)
Review request for drill.
Changes
-------
Added tests related to views on fixed schema tables such as hive and fixed couple of bugs.
Repository: drill-git
Description
-------
Currently views are session only. They don't persist across sessions. There is a know issue DRILL-595 where if you have * in view's select statement, projecting individual columns doesn't work properly.
Diffs (updated)
-----
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseSchemaFactory.java 991685c
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePlugin.java a82c6c3
exec/java-exec/src/main/codegen/data/Parser.tdd 4f47795
exec/java-exec/src/main/codegen/includes/parserImpls.ftl cd5ee72
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java ddc5025
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java 7e3b63d
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java f46f012
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillViewTable.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java 8892a8f
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillSqlCall.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateView.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDescribeTable.java 24c2d03
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlDropView.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowSchemas.java 526ae04
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlShowTables.java aad5ca5
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlUseSchema.java a48963e
exec/java-exec/src/main/java/org/apache/drill/exec/planner/types/RelDataTypeHolder.java 8bc746e
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java f27317c
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/ViewStore.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java 64087f5
exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaFactory.java 60ccbe8
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java 7a88098
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPlugin.java 97427f6
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java 93bac0c
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java 1551e5a
exec/java-exec/src/main/java/org/apache/drill/exec/store/hive/HiveStoragePlugin.java e6df669
exec/java-exec/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java 3608ea7
exec/java-exec/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSchemaFactory.java 7b30a41
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaStoragePlugin.java 313ea86
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockStorageEngine.java 10f6e08
exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java a3a5647
exec/java-exec/src/test/java/org/apache/drill/TestTpchSingleMode.java 1ccb65c
exec/java-exec/src/test/java/org/apache/drill/exec/store/TestOrphanSchema.java d7e74cb
exec/java-exec/src/test/java/org/apache/drill/exec/store/ischema/OrphanSchema.java 1f1b367
exec/java-exec/src/test/resources/queries/tpch/15.sql 251631d
sqlparser/src/test/java/org/apache/drill/jdbc/test/TestJdbcQuery.java 148c115
Diff: https://reviews.apache.org/r/20894/diff/
Testing
-------
Added several unittests in TestJdbcQuery.
Thanks,
Venki Korukanti