You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/05/09 07:21:15 UTC
[GitHub] [skywalking] wankai123 opened a new pull request, #9013: VM monitoring adapt the latest version `0.50.0`of the `opentelemetry-collector`
wankai123 opened a new pull request, #9013:
URL: https://github.com/apache/skywalking/pull/9013
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/changelog/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9013: VM monitoring adapt the latest version `0.50.0`of the `opentelemetry-collector`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9013:
URL: https://github.com/apache/skywalking/pull/9013#discussion_r867708042
##########
docs/en/changes/changes.md:
##########
@@ -45,6 +45,7 @@
* Support autocomplete tags in logs query.
* Enhance Deprecated MetricQuery(v1) getValues querying to asynchronous concurrency query
* Fix the pod match error when the service has multiple selector in kubernetes environment.
+* VM monitoring adapt the latest version of the `opentelemetry-collector`.
Review Comment:
```suggestion
* VM monitoring adapts the 0.50.0 of the `opentelemetry-collector`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #9013: VM monitoring adapt the latest version `0.50.0`of the `opentelemetry-collector`
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #9013:
URL: https://github.com/apache/skywalking/pull/9013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] chenxiaohu commented on pull request #9013: VM monitoring adapt the latest version `0.50.0`of the `opentelemetry-collector`
Posted by GitBox <gi...@apache.org>.
chenxiaohu commented on PR #9013:
URL: https://github.com/apache/skywalking/pull/9013#issuecomment-1160040939
@wankai123 deploy.docker FEATURE_FLAGS=single-node,vm can not receive any data into oap but no error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9013: VM monitoring adapt the latest version `0.50.0`of the `opentelemetry-collector`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9013:
URL: https://github.com/apache/skywalking/pull/9013#discussion_r867707345
##########
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/oc/OCMetricHandler.java:
##########
@@ -54,14 +55,15 @@
@Slf4j
public class OCMetricHandler extends MetricsServiceGrpc.MetricsServiceImplBase implements Handler {
-
+ public static final String HOST_NAME_LABEL = "node_identifier_host_name";
Review Comment:
```suggestion
private static final String HOST_NAME_LABEL = "node_identifier_host_name";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org