You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:31:03 UTC
[GitHub] [fineract] percyashu opened a new pull request #1018: FINERACT-822 enable ImmutableEnumChecker error
percyashu opened a new pull request #1018:
URL: https://github.com/apache/fineract/pull/1018
FINERACT-822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on a change in pull request #1018: FINERACT-822 enable ImmutableEnumChecker error
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #1018:
URL: https://github.com/apache/fineract/pull/1018#discussion_r439099686
##########
File path: fineract-provider/build.gradle
##########
@@ -436,7 +436,8 @@ modernizer {
ignorePackages = []
ignoreClassNamePatterns = [
- '.*AbstractPersistableCustom'
+ '.*AbstractPersistableCustom',
+ '.*EntityTables'
Review comment:
understood. Thanks for the explanation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] percyashu commented on pull request #1018: FINERACT-822 enable ImmutableEnumChecker error
Posted by GitBox <gi...@apache.org>.
percyashu commented on pull request #1018:
URL: https://github.com/apache/fineract/pull/1018#issuecomment-643293478
@awasum @xurror @vorburger merge this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] percyashu commented on a change in pull request #1018: FINERACT-822 enable ImmutableEnumChecker error
Posted by GitBox <gi...@apache.org>.
percyashu commented on a change in pull request #1018:
URL: https://github.com/apache/fineract/pull/1018#discussion_r437294067
##########
File path: fineract-provider/build.gradle
##########
@@ -436,7 +436,8 @@ modernizer {
ignorePackages = []
ignoreClassNamePatterns = [
- '.*AbstractPersistableCustom'
+ '.*AbstractPersistableCustom',
+ '.*EntityTables'
Review comment:
Errorprone wants all fields in Enumeration to Immutable, hence Integer[] is require to be ImmutableList<Integer> and modernizer wants all ImmutableList.of to be List.of which Error prone doesn't consider as Immutable, hence had to add EntityTables to this list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #1018: FINERACT-822 enable ImmutableEnumChecker error
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1018:
URL: https://github.com/apache/fineract/pull/1018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1018: FINERACT-822 enable ImmutableEnumChecker error
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1018:
URL: https://github.com/apache/fineract/pull/1018#issuecomment-643331003
Squash this? Otherwise looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org