You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ivy-commits@incubator.apache.org by "Stephane Bailliez (JIRA)" <ji...@apache.org> on 2007/07/17 20:22:04 UTC
[jira] Created: (IVYDE-58) Compilation fails on Europa due to API
change
Compilation fails on Europa due to API change
---------------------------------------------
Key: IVYDE-58
URL: https://issues.apache.org/jira/browse/IVYDE-58
Project: IvyDE
Issue Type: Bug
Affects Versions: 1.3.0
Reporter: Stephane Bailliez
I was being stupid and checked out Europa, so after downloading several GB of data, I tried to compile IvyDE and the Eclipse API seems to have changed.
Patch to make it compile is below. (there might be something more obvious though, I'm not overly familiar with the api)
Index: D:/work/oss/apache-ivy/ivyde/trunk/src/java/org/apache/ivyde/eclipse/ui/search/FixedJavaSearchPage.java
===================================================================
--- D:/work/oss/apache-ivy/ivyde/trunk/src/java/org/apache/ivyde/eclipse/ui/search/FixedJavaSearchPage.java (revision 557007)
+++ D:/work/oss/apache-ivy/ivyde/trunk/src/java/org/apache/ivyde/eclipse/ui/search/FixedJavaSearchPage.java (working copy)
@@ -289,7 +289,7 @@
case ISearchPageContainer.SELECTED_PROJECTS_SCOPE: {
String[] projectNames= getContainer().getSelectedProjectNames();
scope= factory.createJavaProjectSearchScope(projectNames, includeJRE);
- scopeDescription= factory.getProjectScopeDescription(projectNames, includeJRE);
+ scopeDescription= factory.getProjectScopeDescription(projectNames, includeJRE ? JavaSearchScopeFactory.JRE : JavaSearchScopeFactory.NO_JRE);
break;
}
case ISearchPageContainer.WORKING_SET_SCOPE: {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVYDE-58) Compilation fails on Europa due to API
change
Posted by "Nicolas Lalevée (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547635 ]
Nicolas Lalevée commented on IVYDE-58:
--------------------------------------
Same issue there. Looking at eclipse code, it seems there is no reason to not keep the compatibility. Filled a bug:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=211684
> Compilation fails on Europa due to API change
> ---------------------------------------------
>
> Key: IVYDE-58
> URL: https://issues.apache.org/jira/browse/IVYDE-58
> Project: IvyDE
> Issue Type: Bug
> Affects Versions: 1.3.0
> Reporter: Stephane Bailliez
>
> I was being stupid and checked out Europa, so after downloading several GB of data, I tried to compile IvyDE and the Eclipse API seems to have changed.
> Patch to make it compile is below. (there might be something more obvious though, I'm not overly familiar with the api)
> Index: D:/work/oss/apache-ivy/ivyde/trunk/src/java/org/apache/ivyde/eclipse/ui/search/FixedJavaSearchPage.java
> ===================================================================
> --- D:/work/oss/apache-ivy/ivyde/trunk/src/java/org/apache/ivyde/eclipse/ui/search/FixedJavaSearchPage.java (revision 557007)
> +++ D:/work/oss/apache-ivy/ivyde/trunk/src/java/org/apache/ivyde/eclipse/ui/search/FixedJavaSearchPage.java (working copy)
> @@ -289,7 +289,7 @@
> case ISearchPageContainer.SELECTED_PROJECTS_SCOPE: {
> String[] projectNames= getContainer().getSelectedProjectNames();
> scope= factory.createJavaProjectSearchScope(projectNames, includeJRE);
> - scopeDescription= factory.getProjectScopeDescription(projectNames, includeJRE);
> + scopeDescription= factory.getProjectScopeDescription(projectNames, includeJRE ? JavaSearchScopeFactory.JRE : JavaSearchScopeFactory.NO_JRE);
> break;
> }
> case ISearchPageContainer.WORKING_SET_SCOPE: {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVYDE-58) Compilation fails on Europa due to API
change
Posted by "Xavier Hanin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547637 ]
Xavier Hanin commented on IVYDE-58:
-----------------------------------
Thanks for reporting the issue to eclipse Nicolas. For what it's worth the Ivy svn has just been moved to ant svn, so I suggest to change the link in the eclipse report to https://svn.apache.org/repos/asf/ant/ivy/ivyde/trunk/src/java/org/apache/ivyde/eclipse/ui/search/FixedJavaSearchPage.java
I'm not sure we will this class in IvyDE anyway, it's just a workaround for searches which are not performed consistently in eclipse depending on where you trigger the search from (I raised an issue in eclipse about that, without success, we didn't share the same point of view). So we may end up removing this undocumented "feature" of IvyDE.
> Compilation fails on Europa due to API change
> ---------------------------------------------
>
> Key: IVYDE-58
> URL: https://issues.apache.org/jira/browse/IVYDE-58
> Project: IvyDE
> Issue Type: Bug
> Affects Versions: 1.3.0
> Reporter: Stephane Bailliez
>
> I was being stupid and checked out Europa, so after downloading several GB of data, I tried to compile IvyDE and the Eclipse API seems to have changed.
> Patch to make it compile is below. (there might be something more obvious though, I'm not overly familiar with the api)
> Index: D:/work/oss/apache-ivy/ivyde/trunk/src/java/org/apache/ivyde/eclipse/ui/search/FixedJavaSearchPage.java
> ===================================================================
> --- D:/work/oss/apache-ivy/ivyde/trunk/src/java/org/apache/ivyde/eclipse/ui/search/FixedJavaSearchPage.java (revision 557007)
> +++ D:/work/oss/apache-ivy/ivyde/trunk/src/java/org/apache/ivyde/eclipse/ui/search/FixedJavaSearchPage.java (working copy)
> @@ -289,7 +289,7 @@
> case ISearchPageContainer.SELECTED_PROJECTS_SCOPE: {
> String[] projectNames= getContainer().getSelectedProjectNames();
> scope= factory.createJavaProjectSearchScope(projectNames, includeJRE);
> - scopeDescription= factory.getProjectScopeDescription(projectNames, includeJRE);
> + scopeDescription= factory.getProjectScopeDescription(projectNames, includeJRE ? JavaSearchScopeFactory.JRE : JavaSearchScopeFactory.NO_JRE);
> break;
> }
> case ISearchPageContainer.WORKING_SET_SCOPE: {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.