You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "robertmu (via GitHub)" <gi...@apache.org> on 2025/07/13 03:18:37 UTC
[PR] feat: Merge upstream changes from greenplum-db [cloudberry-go-libs]
robertmu opened a new pull request, #6:
URL: https://github.com/apache/cloudberry-go-libs/pull/6
feat: Merge upstream changes from greenplum-db
This merge brings in the latest updates from the upstream repository
(greenplum-db/gp-common-go-libs).
The primary reason for this merge is to update the dependencies required
by the `gpbackup` utility. The latest version of `gpbackup` relies on
these updated libraries. By syncing this repository first, we ensure a
smooth integration of the upcoming `gpbackup` merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] feat: Merge upstream changes from greenplum-db [cloudberry-go-libs]
Posted by "robertmu (via GitHub)" <gi...@apache.org>.
robertmu commented on PR #6:
URL: https://github.com/apache/cloudberry-go-libs/pull/6#issuecomment-3067133808
> Hi @robertmu, thank you for your PR. Please **rebase** the code rather than merge code. Linear commit history is recommend to make tracking changes easier.
The previous commit 3c26b84 incorrectly removed support for Greenplum versions prior to GPDB 6. However, due to customer needs, our tool must now be fully compatible with all versions supported by gpbackup.
If I were to fix this by rebasing my branch, commit 3c26b84 would be dropped from the commit history. This altered history would prevent me from pushing my changes back to the repository.
Therefore, I propose that we first revert the problematic commit. After that is done, I may proceed with the rebase safely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] feat: Merge upstream changes from greenplum-db [cloudberry-go-libs]
Posted by "gfphoenix78 (via GitHub)" <gi...@apache.org>.
gfphoenix78 commented on code in PR #6:
URL: https://github.com/apache/cloudberry-go-libs/pull/6#discussion_r2203299441
##########
CONTRIBUTING.md:
##########
@@ -1,77 +1,67 @@
-Cloudberry Database community welcomes contributions from anyone, new and
-experienced! We appreciate your interest in contributing. This guide will help
-you get started with the contribution.
+# Contributing
-## Code of Conduct
+We warmly welcome and appreciate contributions from the community! By participating you agree to the [code of conduct](https://github.com/greenplum-db/gpupgrade/blob/main/CODE-OF-CONDUCT.md).
Review Comment:
@tuhaihe Is it properly to use the external code-of-conduct from gpupgrade? I don't think so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] feat: Merge upstream changes from greenplum-db [cloudberry-go-libs]
Posted by "gfphoenix78 (via GitHub)" <gi...@apache.org>.
gfphoenix78 commented on PR #6:
URL: https://github.com/apache/cloudberry-go-libs/pull/6#issuecomment-3066991540
The file `CONTRIBUTING.md` changes too large. Please @tuhaihe have a look. The file contains greenplum links which seems not properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] feat: Merge upstream changes from greenplum-db [cloudberry-go-libs]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on code in PR #6:
URL: https://github.com/apache/cloudberry-go-libs/pull/6#discussion_r2203638788
##########
CONTRIBUTING.md:
##########
@@ -1,77 +1,67 @@
-Cloudberry Database community welcomes contributions from anyone, new and
-experienced! We appreciate your interest in contributing. This guide will help
-you get started with the contribution.
+# Contributing
-## Code of Conduct
+We warmly welcome and appreciate contributions from the community! By participating you agree to the [code of conduct](https://github.com/greenplum-db/gpupgrade/blob/main/CODE-OF-CONDUCT.md).
Review Comment:
No, it's not ok to adopt GP's style. We need to use the Apache one, like this:
```markdown
# Code of Conduct
Apache Cloudberry (Incubating) follows the ASF [Code of
Conduct](https://www.apache.org/foundation/policies/conduct).
If you observe behavior that violates those rules please follow the
[ASF reporting
guidelines](https://www.apache.org/foundation/policies/conduct#reporting-guidelines).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] feat: Merge upstream changes from greenplum-db [cloudberry-go-libs]
Posted by "gfphoenix78 (via GitHub)" <gi...@apache.org>.
gfphoenix78 commented on PR #6:
URL: https://github.com/apache/cloudberry-go-libs/pull/6#issuecomment-3066832428
Hi @robertmu, thank you for your PR. Please **rebase** the code rather than merge code. Linear commit history is recommend to make tracking changes easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] feat: Merge upstream changes from greenplum-db [cloudberry-go-libs]
Posted by "robertmu (via GitHub)" <gi...@apache.org>.
robertmu closed pull request #6: feat: Merge upstream changes from greenplum-db
URL: https://github.com/apache/cloudberry-go-libs/pull/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org