You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhan Reddy <mr...@gmail.com> on 2017/02/01 13:41:14 UTC
Review Request 56168: AMBARI-19819. Styling changes and spelling fixes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56168/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-19819
https://issues.apache.org/jira/browse/AMBARI-19819
Repository: ambari
Description
-------
Fixed style changes and spellings
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/asset-config.js 62d3be3
contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js fe6dfd1
contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js f897d48
contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js beb15f6
contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 91e1ce3
contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 54d13ff
contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 5080560
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/archive-config.hbs 166a202
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/arg-config.hbs e11d896
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs 7bc48d7
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs 7fd1236
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs 6ca85c6
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-coord-config.hbs 140ff0a
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-job-details.hbs 97eb859
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 1c80312
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-job-details.hbs 1418121
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/date-with-expr.hbs 4c86f3d
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs 8b2911b
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs f7a93e0
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/file-config.hbs 66d3460
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/global-config.hbs 923d89e
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/help-icon.hbs a853955
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hive-action.hbs eb959c3
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hive2-action.hbs 563cca8
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/instance-list-config.hbs 94f4e39
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs 7ffdf5f
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs c783ad0
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs 25d81dd
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/name-value-config.hbs f69a2d4
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/pig-action.hbs d0fe490
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config-fs.hbs 545664f
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config.hbs fab0d97
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/save-wf.hbs 913dc04
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/shell-action.hbs 4673c732
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs 5b7e7a3
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sub-workflow.hbs 2841188
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs bb089c0
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-config.hbs d425bd0
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs 89997aa
contrib/views/wfmanager/src/main/resources/ui/app/validators/operand-length.js b79596b
Diff: https://reviews.apache.org/r/56168/diff/
Testing
-------
Manual
Thanks,
Madhan Reddy
Re: Review Request 56168: AMBARI-19819. Styling changes and spelling
fixes
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56168/#review163812
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On Feb. 1, 2017, 1:41 p.m., Madhan Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56168/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 1:41 p.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19819
> https://issues.apache.org/jira/browse/AMBARI-19819
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed style changes and spellings
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/asset-config.js 62d3be3
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js fe6dfd1
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js f897d48
> contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js beb15f6
> contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 91e1ce3
> contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 54d13ff
> contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 5080560
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/archive-config.hbs 166a202
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/arg-config.hbs e11d896
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs 7bc48d7
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs 7fd1236
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs 6ca85c6
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-coord-config.hbs 140ff0a
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-job-details.hbs 97eb859
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 1c80312
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-job-details.hbs 1418121
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/date-with-expr.hbs 4c86f3d
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs 8b2911b
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs f7a93e0
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/file-config.hbs 66d3460
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/global-config.hbs 923d89e
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/help-icon.hbs a853955
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hive-action.hbs eb959c3
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hive2-action.hbs 563cca8
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/instance-list-config.hbs 94f4e39
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs 7ffdf5f
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs c783ad0
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs 25d81dd
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/name-value-config.hbs f69a2d4
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/pig-action.hbs d0fe490
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config-fs.hbs 545664f
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config.hbs fab0d97
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/save-wf.hbs 913dc04
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/shell-action.hbs 4673c732
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs 5b7e7a3
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sub-workflow.hbs 2841188
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs bb089c0
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-config.hbs d425bd0
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs 89997aa
> contrib/views/wfmanager/src/main/resources/ui/app/validators/operand-length.js b79596b
>
> Diff: https://reviews.apache.org/r/56168/diff/
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Madhan Reddy
>
>
Re: Review Request 56168: AMBARI-19819. Styling changes and spelling
fixes
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56168/#review163939
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On Feb. 1, 2017, 1:41 p.m., Madhan Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56168/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 1:41 p.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19819
> https://issues.apache.org/jira/browse/AMBARI-19819
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed style changes and spellings
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/asset-config.js 62d3be3
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js fe6dfd1
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js f897d48
> contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js beb15f6
> contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 91e1ce3
> contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 54d13ff
> contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 5080560
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/archive-config.hbs 166a202
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/arg-config.hbs e11d896
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs 7bc48d7
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs 7fd1236
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs 6ca85c6
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-coord-config.hbs 140ff0a
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-job-details.hbs 97eb859
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 1c80312
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-job-details.hbs 1418121
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/date-with-expr.hbs 4c86f3d
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs 8b2911b
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs f7a93e0
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/file-config.hbs 66d3460
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/global-config.hbs 923d89e
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/help-icon.hbs a853955
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hive-action.hbs eb959c3
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hive2-action.hbs 563cca8
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/instance-list-config.hbs 94f4e39
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs 7ffdf5f
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs c783ad0
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs 25d81dd
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/name-value-config.hbs f69a2d4
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/pig-action.hbs d0fe490
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config-fs.hbs 545664f
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config.hbs fab0d97
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/save-wf.hbs 913dc04
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/shell-action.hbs 4673c732
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs 5b7e7a3
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sub-workflow.hbs 2841188
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs bb089c0
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-config.hbs d425bd0
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs 89997aa
> contrib/views/wfmanager/src/main/resources/ui/app/validators/operand-length.js b79596b
>
> Diff: https://reviews.apache.org/r/56168/diff/
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Madhan Reddy
>
>